From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DBD8C433EF for ; Wed, 1 Dec 2021 12:28:13 +0000 (UTC) Received: from localhost ([::1]:53160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msOia-0008OT-GY for qemu-devel@archiver.kernel.org; Wed, 01 Dec 2021 07:28:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msOgw-0007Z6-Mp; Wed, 01 Dec 2021 07:26:30 -0500 Received: from mail08.asahi-net.or.jp ([202.224.55.48]:35216) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msOgu-0004g2-Cc; Wed, 01 Dec 2021 07:26:30 -0500 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) (Authenticated sender: PQ4Y-STU) by mail08.asahi-net.or.jp (Postfix) with ESMTPA id A4C8421781; Wed, 1 Dec 2021 21:26:23 +0900 (JST) Received: from SIOS1075.ysato.ml (al142214.dynamic.ppp.asahi-net.or.jp [111.234.142.214]) by sakura.ysato.name (Postfix) with ESMTPSA id BBEF91C0123; Wed, 1 Dec 2021 21:26:22 +0900 (JST) Date: Wed, 01 Dec 2021 21:26:22 +0900 Message-ID: <87h7bsa4up.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Peter Maydell Subject: Re: [PATCH for-7.0 3/4] target/rx/cpu.h: Don't include qemu-common.h In-Reply-To: <20211129200510.1233037-4-peter.maydell@linaro.org> References: <20211129200510.1233037-1-peter.maydell@linaro.org> <20211129200510.1233037-4-peter.maydell@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: softfail client-ip=202.224.55.48; envelope-from=ysato@users.sourceforge.jp; helo=mail08.asahi-net.or.jp X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Taylor Simpson , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Sergio Lopez Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 30 Nov 2021 05:05:09 +0900, Peter Maydell wrote: > > The qemu-common.h header is not supposed to be included from any > other header files, only from .c files (as documented in a comment at > the start of it). > > Nothing actually relies on target/rx/cpu.h including it, so we can > just drop the include. > > Signed-off-by: Peter Maydell Reviewed-by: Yoshinori Sato > --- > target/rx/cpu.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/rx/cpu.h b/target/rx/cpu.h > index 4ac71aec370..657db84ef0a 100644 > --- a/target/rx/cpu.h > +++ b/target/rx/cpu.h > @@ -20,7 +20,6 @@ > #define RX_CPU_H > > #include "qemu/bitops.h" > -#include "qemu-common.h" > #include "hw/registerfields.h" > #include "cpu-qom.h" > > -- > 2.25.1 > >