From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Ping-Ke Shih <pkshih@realtek.com>, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v7 08/24] rtw89: implement mac80211 ops
Date: Fri, 08 Oct 2021 19:45:14 +0200 [thread overview]
Message-ID: <87h7drl8b9.fsf@toke.dk> (raw)
In-Reply-To: <20211008035627.19463-9-pkshih@realtek.com>
Ping-Ke Shih <pkshih@realtek.com> writes:
> To yield better TX performance, wake TX queue is implemented.
I went looking for this, and was happy to find it! :)
Do you also support airtime reporting and/or AQL? And if not, any plans
to do so?
One small nit below:
> +static void rtw89_ops_wake_tx_queue(struct ieee80211_hw *hw,
> + struct ieee80211_txq *txq)
> +{
> + struct rtw89_dev *rtwdev = hw->priv;
> +
> + ieee80211_schedule_txq(hw, txq);
> + queue_work(rtwdev->txq_wq, &rtwdev->txq_work);
Why the call to ieee80211_schedule_txq()? mac80211 calls that before
calling wake_tx_queue() (through the schedule_and_wake_txq() helper), so
it seems a bit superfluous here?
-Toke
next prev parent reply other threads:[~2021-10-08 17:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 3:56 [PATCH v7 00/24] rtw89: add Realtek 802.11ax driver Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 01/24] rtw89: add CAM files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 02/24] rtw89: add BT coexistence files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 03/24] rtw89: add core and trx files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 04/24] rtw89: add debug files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 05/24] rtw89: add efuse files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 06/24] rtw89: add files to download and communicate with firmware Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 07/24] rtw89: add MAC files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 08/24] rtw89: implement mac80211 ops Ping-Ke Shih
2021-10-08 17:45 ` Toke Høiland-Jørgensen [this message]
2021-10-12 8:39 ` Pkshih
2021-10-08 3:56 ` [PATCH v7 09/24] rtw89: add pci files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 10/24] rtw89: add phy files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 11/24] rtw89: define register names Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 12/24] rtw89: add regulatory support Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 13/24] rtw89: 8852a: add 8852a specific files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 14/24] rtw89: 8852a: add 8852a RFK files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 15/24] rtw89: 8852a: add 8852a RFK tables Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 16/24] rtw89: 8852a: add 8852a tables (1 of 5) Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 17/24] rtw89: 8852a: add 8852a tables (2 " Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 18/24] rtw89: 8852a: add 8852a tables (3 " Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 19/24] rtw89: 8852a: add 8852a tables (4 " Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 20/24] rtw89: 8852a: add 8852a tables (5 " Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 21/24] rtw89: add ser to recover error reported by firmware Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 22/24] rtw89: add PS files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 23/24] rtw89: add SAR files Ping-Ke Shih
2021-10-08 3:56 ` [PATCH v7 24/24] rtw89: add Kconfig and Makefile Ping-Ke Shih
2021-10-09 8:21 ` [PATCH v7 00/24] rtw89: add Realtek 802.11ax driver Kalle Valo
2021-10-11 12:06 ` Kalle Valo
2021-10-12 1:32 ` Pkshih
2021-10-13 6:09 ` Kalle Valo
2021-10-13 8:55 ` Pkshih
2021-10-13 9:06 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7drl8b9.fsf@toke.dk \
--to=toke@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.