From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF18DC07E96 for ; Thu, 8 Jul 2021 07:33:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F27A61C53 for ; Thu, 8 Jul 2021 07:33:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F27A61C53 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B39FE6E879; Thu, 8 Jul 2021 07:33:07 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69F8D6E879 for ; Thu, 8 Jul 2021 07:33:06 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10038"; a="209421840" X-IronPort-AV: E=Sophos;i="5.84,222,1620716400"; d="scan'208";a="209421840" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 00:33:04 -0700 X-IronPort-AV: E=Sophos;i="5.84,222,1620716400"; d="scan'208";a="487450327" Received: from victorge-mobl1.ccr.corp.intel.com (HELO localhost) ([10.252.44.91]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 00:33:01 -0700 From: Jani Nikula To: Matt Roper , intel-gfx@lists.freedesktop.org In-Reply-To: <20210708053819.2120187-1-matthew.d.roper@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210708053819.2120187-1-matthew.d.roper@intel.com> Date: Thu, 08 Jul 2021 10:32:58 +0300 Message-ID: <87h7h56z11.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 0/7] Minor revid/stepping and workaround cleanup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 07 Jul 2021, Matt Roper wrote: > PCI revision IDs don't always map to GT and display IP steppings in an > intuitive/sensible way. On many of our recent platforms we've switched > to using revid->stepping lookup tables with the infrastructure in > intel_step.c to handle stepping lookups and comparisons. Since it's > confusing to have some of our platforms using the new lookup tables and > some still using old revid comparisons, let's migrate all the old > platforms over to the table approach since that's what we want to > standardize on going forward. The only place that revision ID's should > really get used directly now is when checking to see if we're running on > pre-production hardware. Anusha, Matt, please sort this out between the two of you. :) https://patchwork.freedesktop.org/series/92257/ BR, Jani. > > Let's also take the opportunity to drop a bit of effectively dead code > in the workarounds file too. > > Cc: Jani Nikula > > Matt Roper (7): > drm/i915: Make pre-production detection use direct revid comparison > drm/i915/skl: Use revid->stepping tables > drm/i915/icl: Use revid->stepping tables > drm/i915/jsl_ehl: Use revid->stepping tables > drm/i915/rkl: Use revid->stepping tables > drm/i915/dg1: Use revid->stepping tables > drm/i915/cnl: Drop all workarounds > > .../drm/i915/display/intel_display_power.c | 2 +- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- > drivers/gpu/drm/i915/display/intel_psr.c | 4 +- > drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 81 +++---------------- > drivers/gpu/drm/i915/i915_drv.c | 8 +- > drivers/gpu/drm/i915/i915_drv.h | 80 +++--------------- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > drivers/gpu/drm/i915/intel_step.c | 72 +++++++++++++++-- > drivers/gpu/drm/i915/intel_step.h | 7 ++ > 10 files changed, 107 insertions(+), 153 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx