From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B0796E845 for ; Wed, 16 Jun 2021 22:56:14 +0000 (UTC) Date: Wed, 16 Jun 2021 15:56:13 -0700 Message-ID: <87h7hx2zci.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: References: <20210614163704.365989-1-jason@jlekstrand.net> <20210614163902.366168-19-jason@jlekstrand.net> <87o8c65ywy.wl-ashutosh.dixit@intel.com> <87mtrq5xsl.wl-ashutosh.dixit@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 68/77] igt/dummyload: Require an intel_ctx_t for POLL_RUN and !ALL_ENGINES List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Jason Ekstrand Cc: IGT GPU Tools List-ID: On Wed, 16 Jun 2021 10:25:12 -0700, Jason Ekstrand wrote: > > I take that back. Now I remember how these interact. We need an > intel_ctx_t for ALL_ENGINES so we can iterate over it. We also need > an intel_ctx_t for POLL_RUN so we can check > gem_class_can_store_dword(). However, if you're using neither, we > technically don't need an intel_ctx_t. Does that make sense? Yes, thanks. You are right, the code is correct, no changes needed. ctx_id also survives and can be used when needed. Reviewed-by: Ashutosh Dixit _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev