From: Chandan Babu R <chandanrlinux@gmail.com>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v20 13/14] xfs: Fix default ASSERT in xfs_attr_set_iter
Date: Mon, 07 Jun 2021 14:03:13 +0530 [thread overview]
Message-ID: <87h7iakrau.fsf@garuda> (raw)
In-Reply-To: <20210607052747.31422-4-allison.henderson@oracle.com>
On 07 Jun 2021 at 10:57, Allison Henderson wrote:
> This ASSERT checks for the state value of RM_SHRINK in the set path
> which should never happen. Change to ASSERT(0);
>
Looks good.
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
> Suggested-by: Darrick J. Wong <djwong@kernel.org>
> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> fs/xfs/libxfs/xfs_attr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> index 2387a41..a0edebc 100644
> --- a/fs/xfs/libxfs/xfs_attr.c
> +++ b/fs/xfs/libxfs/xfs_attr.c
> @@ -612,7 +612,7 @@ xfs_attr_set_iter(
> error = xfs_attr_node_addname_clear_incomplete(dac);
> break;
> default:
> - ASSERT(dac->dela_state != XFS_DAS_RM_SHRINK);
> + ASSERT(0);
> break;
> }
> out:
--
chandan
next prev parent reply other threads:[~2021-06-07 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 5:27 [PATCH v20 10/14] xfs: Add delay ready attr set routines Allison Henderson
2021-06-07 5:27 ` [PATCH v20 11/14] xfs: Remove xfs_attr_rmtval_set Allison Henderson
2021-06-07 5:27 ` [PATCH v20 12/14] xfs: Clean up xfs_attr_node_addname_clear_incomplete Allison Henderson
2021-06-07 5:27 ` [PATCH v20 13/14] xfs: Fix default ASSERT in xfs_attr_set_iter Allison Henderson
2021-06-07 8:33 ` Chandan Babu R [this message]
2021-06-07 16:19 ` Darrick J. Wong
2021-06-07 5:27 ` [PATCH v20 14/14] xfs: Make attr name schemes consistent Allison Henderson
2021-06-07 8:35 ` Chandan Babu R
2021-06-07 16:20 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7iakrau.fsf@garuda \
--to=chandanrlinux@gmail.com \
--cc=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.