From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD7F86E5D3 for ; Thu, 13 May 2021 01:46:52 +0000 (UTC) Date: Wed, 12 May 2021 18:46:30 -0700 Message-ID: <87h7j7csnd.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <87sg3mpyfl.wl-ashutosh.dixit@intel.com> References: <20210419060928.671111-1-viswax.krishna.raveendra.talabattula@intel.com> <87sg3mpyfl.wl-ashutosh.dixit@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH] [i-g-t] tests/i915: Remove I915_CACHING_NONE List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: viswax.krishna.raveendra.talabattula@intel.com Cc: igt-dev@lists.freedesktop.org, hariom.pandey@intel.com, Petri Latvala List-ID: On Sun, 18 Apr 2021 23:42:54 -0700, Dixit, Ashutosh wrote: > > On Sun, 18 Apr 2021 23:09:28 -0700, wrote: > > > > From: Viswa Krishna Raveendra Talabattula > > > > The userptr memory does not support I915_CACHING_NONE(no caching) level > > as per the below commit related to i915 in the kernel > > > > drm/i915: Reject more ioctls for userptr, v2. > > > > Hence removing the cache level of I915_CACHING_NONE from the test case > > Instead of dropping the test should we check for -ENXIO return? Because setting I915_CACHING_NONE on a userptr is not an unreasonable operation, if it is not supported IMO IGT should check for an -ENXIO return if someone tries to set I915_CACHING_NONE. The only complication here is that this is a ABI change. So if IGT runs on an older kernel set_caching() will return 0 whereas it will return -ENXIO with a new kernel. There seems to be no way of determining a priori what the expected return is. I am copying Petri too. Checking for both 0 and -ENXIO would sort of defeat the purpose. Also, having the IGT fail on older kernels is also probably unacceptable. > > > Cc: Maarten Lankhorst > > Signed-off-by: Viswa Krishna Raveendra Talabattula > > --- > > tests/i915/gem_userptr_blits.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tests/i915/gem_userptr_blits.c b/tests/i915/gem_userptr_blits.c > > index aad5f141..f0c63535 100644 > > --- a/tests/i915/gem_userptr_blits.c > > +++ b/tests/i915/gem_userptr_blits.c > > @@ -2011,7 +2011,6 @@ static void test_sd_probe(int i915) > > static void test_set_caching(int i915) > > { > > const int levels[] = { > > - I915_CACHING_NONE, > > I915_CACHING_CACHED, > > }; > > uint32_t handle; > > -- > > 2.30.0 > > > > _______________________________________________ > > igt-dev mailing list > > igt-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev