From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F1BC433E0 for ; Fri, 8 Jan 2021 12:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C66CD23975 for ; Fri, 8 Jan 2021 12:22:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727401AbhAHMWA (ORCPT ); Fri, 8 Jan 2021 07:22:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:54134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbhAHMV7 (ORCPT ); Fri, 8 Jan 2021 07:21:59 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 93195238E4; Fri, 8 Jan 2021 12:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610108478; bh=CGyJVGRnQUYO+Dwo4ILDxEFobjgiAm4vANZ35SFjRV4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MLryRnKHypOReQqOXqkOcMYCuhbGUcwnL3G7NGpCrsl4eVIPM5AisIPpGId1oC5a0 3QmasNX/oubX4G5K3RnPBJialUK24gquHFumpY54G63J7pj1N+0hskyCQJ6K8cv8sn aIQrBdsYmZIVbGsRT4tIF71fu/aFVO46XJXVC7lO2omH6DsxMLPVbNcy9G2YyHY3og 8C2ZQaeZdLndkK5MKaSIIiyVoZ5vpdn4J3yLip7fTbL0iDRdptJoiXneLEOS2qf67P fIrvcHFdrEc2xgMTl1JVMv1Z1n4o0dAdBbtp17/XAUS42b2DP4lT2NmqpbXO9/tyjl 6/UwelUa18wNA== From: Felipe Balbi To: Ryan Chen , BMC-SW@aspeedtech.com, Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Ryan Chen Subject: Re: [PATCH 1/1] usb: gadget: aspeed: fix stop dma register setting. In-Reply-To: <20210108081238.10199-2-ryan_chen@aspeedtech.com> References: <20210108081238.10199-1-ryan_chen@aspeedtech.com> <20210108081238.10199-2-ryan_chen@aspeedtech.com> Date: Fri, 08 Jan 2021 14:21:14 +0200 Message-ID: <87h7nrwret.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Ryan Chen writes: > The vhub engine has two dma mode, one is descriptor list, another > is single stage DMA. Each mode has different stop register setting. > Descriptor list operation (bit2) : 0 disable reset, 1: enable reset > Single mode operation (bit0) : 0 : disable, 1: enable > > Signed-off-by: Ryan Chen I don't have HW, but FWIW: Acked-by: Felipe Balbi -- balbi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85410C433E0 for ; Fri, 8 Jan 2021 12:31:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D28C23975 for ; Fri, 8 Jan 2021 12:31:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D28C23975 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QWwMywh1xLqc8Lq7Q9BY1VS5xnMEvWG1mpgPdKFnq/Q=; b=gwuaef8WIW6dnaP+Kx3KZ79zP DrivlZGf1h0ON8i3jBXcfebEVjxC6KTRkxSNctziE35xzVtdrvoV9/E+1//TTZ1OpJodLja6t9IVH 6CMgXUUP/cd2tRiwOCV8uBR6JHUMMPcYsrRGlzGbI2r9ADmnZI+4kA1DPC2qBvH5xhlb/DjZyRoVG QKiCRCF9Rea2mmGg66nTsin+O+sr2FMEscq5JKGIcdA6sefQ8jm8nz5xfs5at1Hw0oanTdShBddFn es3LcSr2WJPxRCZbqOR+WQX8DowNhI85j2Awq8XcwyGcY0BvfC+RsRbIs6NeyuTxhcjmGz9nZQ4mA int7CXGdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxqta-0004X2-Bv; Fri, 08 Jan 2021 12:29:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxqld-0000oZ-3b for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2021 12:21:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 93195238E4; Fri, 8 Jan 2021 12:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610108478; bh=CGyJVGRnQUYO+Dwo4ILDxEFobjgiAm4vANZ35SFjRV4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MLryRnKHypOReQqOXqkOcMYCuhbGUcwnL3G7NGpCrsl4eVIPM5AisIPpGId1oC5a0 3QmasNX/oubX4G5K3RnPBJialUK24gquHFumpY54G63J7pj1N+0hskyCQJ6K8cv8sn aIQrBdsYmZIVbGsRT4tIF71fu/aFVO46XJXVC7lO2omH6DsxMLPVbNcy9G2YyHY3og 8C2ZQaeZdLndkK5MKaSIIiyVoZ5vpdn4J3yLip7fTbL0iDRdptJoiXneLEOS2qf67P fIrvcHFdrEc2xgMTl1JVMv1Z1n4o0dAdBbtp17/XAUS42b2DP4lT2NmqpbXO9/tyjl 6/UwelUa18wNA== From: Felipe Balbi To: Ryan Chen , BMC-SW@aspeedtech.com, Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] usb: gadget: aspeed: fix stop dma register setting. In-Reply-To: <20210108081238.10199-2-ryan_chen@aspeedtech.com> References: <20210108081238.10199-1-ryan_chen@aspeedtech.com> <20210108081238.10199-2-ryan_chen@aspeedtech.com> Date: Fri, 08 Jan 2021 14:21:14 +0200 Message-ID: <87h7nrwret.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_072121_291217_BBE96997 X-CRM114-Status: UNSURE ( 6.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryan Chen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Ryan Chen writes: > The vhub engine has two dma mode, one is descriptor list, another > is single stage DMA. Each mode has different stop register setting. > Descriptor list operation (bit2) : 0 disable reset, 1: enable reset > Single mode operation (bit0) : 0 : disable, 1: enable > > Signed-off-by: Ryan Chen I don't have HW, but FWIW: Acked-by: Felipe Balbi -- balbi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel