All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Machata <me@pmachata.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH iproute2 1/3] dcb: Set values with RTM_SETDCB type
Date: Sun, 03 Jan 2021 11:47:46 +0100	[thread overview]
Message-ID: <87h7nywb3h.fsf@nvidia.com> (raw)
In-Reply-To: <20210102093423.2033de6a@hermes.local>


Stephen Hemminger <stephen@networkplumber.org> writes:

> On Sat,  2 Jan 2021 00:25:50 +0100
> Petr Machata <me@pmachata.org> wrote:
>
>> dcb currently sends all netlink messages with a type RTM_GETDCB, even the
>> set ones. Change to the appropriate type.
>> 
>> Signed-off-by: Petr Machata <me@pmachata.org>
>> ---
>>  dcb/dcb.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/dcb/dcb.c b/dcb/dcb.c
>> index adec57476e1d..f5c62790e27e 100644
>> --- a/dcb/dcb.c
>> +++ b/dcb/dcb.c
>> @@ -177,7 +177,7 @@ int dcb_set_attribute(struct dcb *dcb, const char *dev, int attr, const void *da
>>  	struct nlattr *nest;
>>  	int ret;
>>  
>> -	nlh = dcb_prepare(dcb, dev, RTM_GETDCB, DCB_CMD_IEEE_SET);
>> +	nlh = dcb_prepare(dcb, dev, RTM_SETDCB, DCB_CMD_IEEE_SET);
>>  
>>  	nest = mnl_attr_nest_start(nlh, DCB_ATTR_IEEE);
>>  	mnl_attr_put(nlh, attr, data_len, data);
>
> Should I add fixes tag to this?

Ha, I forgot that Fixes: tags are a thing in iproute2. Sorry about that,
I'll resend.

  reply	other threads:[~2021-01-03 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-01 23:25 [PATCH iproute2 0/3] dcb: Fixes Petr Machata
2021-01-01 23:25 ` [PATCH iproute2 1/3] dcb: Set values with RTM_SETDCB type Petr Machata
2021-01-02 17:34   ` Stephen Hemminger
2021-01-03 10:47     ` Petr Machata [this message]
2021-01-03 18:22       ` Stephen Hemminger
2021-01-01 23:25 ` [PATCH iproute2 2/3] dcb: Plug a leaking DCB socket buffer Petr Machata
2021-01-01 23:25 ` [PATCH iproute2 3/3] dcb: Change --Netns/-N to --netns/-n Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7nywb3h.fsf@nvidia.com \
    --to=me@pmachata.org \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.