From: Andreas Schwab <schwab@linux-m68k.org>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Taylor Blau <me@ttaylorr.com>, Denton Liu <liu.denton@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/4] builtin/rev-parse: learn --null-oid
Date: Sun, 20 Sep 2020 18:03:24 +0200 [thread overview]
Message-ID: <87h7rsl9kj.fsf@igel.home> (raw)
In-Reply-To: <20200918212609.GC67496@camp.crustytoothpaste.net> (brian m. carlson's message of "Fri, 18 Sep 2020 21:26:09 +0000")
On Sep 18 2020, brian m. carlson wrote:
> What I typically do when I write shell scripts, and which may obviate
> the need for this patch is turn this:
>
> [ "$oid" = 0000000000000000000000000000000000000000 ]
>
> into this:
>
> echo "$oid" | grep -qsE '^0+$'
>
> This is slightly less efficient, but it's also backwards compatible
> with older Git version assuming you have a POSIX grep.
You can also use
case $oid in *[1-9a-f]*) ... ;; *) ... ;; esac
which doesn't need an external process.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2020-09-20 16:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 11:19 [PATCH 0/4] sample hooks: become hash agnostic Denton Liu
2020-09-18 11:19 ` [PATCH 1/4] hooks--pre-push.sample: prefer $() for command substitution Denton Liu
2020-09-18 16:57 ` Eric Sunshine
2020-09-18 11:19 ` [PATCH 2/4] builtin/rev-parse: learn --null-oid Denton Liu
2020-09-18 14:11 ` Taylor Blau
2020-09-18 14:16 ` Taylor Blau
2020-09-18 18:16 ` Junio C Hamano
2020-09-18 18:21 ` Taylor Blau
2020-09-18 21:26 ` brian m. carlson
2020-09-20 4:25 ` Chris Torek
2020-09-20 18:58 ` brian m. carlson
2020-09-20 15:35 ` Taylor Blau
2020-09-20 16:03 ` Andreas Schwab [this message]
2020-09-18 11:19 ` [PATCH 3/4] hooks--pre-push.sample: use hash-agnostic null OID Denton Liu
2020-09-18 17:06 ` Eric Sunshine
2020-09-18 11:19 ` [PATCH 4/4] hooks--update.sample: " Denton Liu
2020-09-18 17:08 ` Eric Sunshine
2020-09-18 21:35 ` [PATCH 0/4] sample hooks: become hash agnostic brian m. carlson
2020-09-23 9:38 ` [PATCH v2 0/3] " Denton Liu
2020-09-23 9:38 ` [PATCH v2 1/3] hooks--pre-push.sample: modernize script Denton Liu
2020-09-23 9:38 ` [PATCH v2 2/3] hooks--pre-push.sample: use hash-agnostic zero OID Denton Liu
2020-09-23 9:38 ` [PATCH v2 3/3] hooks--update.sample: " Denton Liu
2020-09-23 16:34 ` [PATCH v2 0/3] sample hooks: become hash agnostic Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7rsl9kj.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.