From: "Aurélien Aptel" <aaptel@suse.com>
To: Paulo Alcantara <pc@cjr.nz>,
linux-cifs@vger.kernel.org, smfrench@gmail.com
Cc: Paulo Alcantara <pc@cjr.nz>
Subject: Re: [PATCH v2 7/7] cifs: document and cleanup dfs mount
Date: Thu, 09 Jul 2020 16:49:20 +0200 [thread overview]
Message-ID: <87h7ug68wf.fsf@suse.com> (raw)
In-Reply-To: <20200706181609.19480-8-pc@cjr.nz>
Paulo Alcantara <pc@cjr.nz> writes:
> + /* Store DFS full path in both superblock and tree connect structures.
line with /* should be empty
> + *
> + * For DFS root mounts, the prefix path (cifs_sb->prepath) is preversed during reconnect so
^^^^^^^^^^
preserved
> + * only the root path is set in cifs_sb->origin_fullpath and tcon->dfs_path. And for DFS
> + * links, the prefix path is included in both and may be changed during reconnect. See
> + * cifs_tree_connect().
> + */
> + cifs_sb->origin_fullpath = kstrndup(full_path, strlen(full_path), GFP_KERNEL);
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
prev parent reply other threads:[~2020-07-09 14:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 18:16 [PATCH v2 0/7] DFS fixes Paulo Alcantara
2020-07-06 18:16 ` [PATCH v2 1/7] cifs: merge __{cifs,smb2}_reconnect[_tcon]() into cifs_tree_connect() Paulo Alcantara
2020-07-09 14:54 ` Aurélien Aptel
2020-07-06 18:16 ` [PATCH v2 2/7] cifs: reduce number of referral requests in DFS link lookups Paulo Alcantara
2020-07-09 14:52 ` Aurélien Aptel
2020-07-06 18:16 ` [PATCH v2 3/7] cifs: rename reconn_inval_dfs_target() Paulo Alcantara
2020-07-09 14:55 ` Aurélien Aptel
2020-07-06 18:16 ` [PATCH v2 4/7] cifs: handle empty list of targets in cifs_reconnect() Paulo Alcantara
2020-07-09 15:38 ` Aurélien Aptel
2020-07-06 18:16 ` [PATCH v2 5/7] cifs: handle RESP_GET_DFS_REFERRAL.PathConsumed in reconnect Paulo Alcantara
2020-07-06 18:16 ` [PATCH v2 6/7] cifs: only update prefix path of DFS links in cifs_tree_connect() Paulo Alcantara
2020-07-06 18:16 ` [PATCH v2 7/7] cifs: document and cleanup dfs mount Paulo Alcantara
2020-07-09 14:49 ` Aurélien Aptel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7ug68wf.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@cjr.nz \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.