From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC583C433E1 for ; Tue, 2 Jun 2020 08:39:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCD13206A2 for ; Tue, 2 Jun 2020 08:39:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="zjRFqhv5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726026AbgFBIjf (ORCPT ); Tue, 2 Jun 2020 04:39:35 -0400 Received: from esa1.microchip.iphmx.com ([68.232.147.91]:44217 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbgFBIjf (ORCPT ); Tue, 2 Jun 2020 04:39:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1591087174; x=1622623174; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=5oSerVw4BUQ1JnWRjiKwnbjMfhGlmnPWZ9idp3chc+k=; b=zjRFqhv5M3r0zwGkUD5i2LiNnp6m7DpLcE5qgVcf784esxprEfBISV9y zsmyAryr61/wd7BxPm1IDhTxssMkxEjJuwQvYSO/6D/HnTJxE872JhlRV 85eSfwNWcqZeS0HDo0EsBRAN6TcLpDbE4aeiOAT2BB2FdlS34vsF+LGRI NRRNU/NjUywiijUeGz5UhCVy+DXaFr0broUIc+BWAp3an9UocOPRCWLia fQajAzBdXrV6oRD4Ey6u3ZBNeLkWotjMEhq3xx/rg7ebkTasUMjHCJqIK YiFYBaJcIS1YjGRtJi6+jc9aI/3UDSMnPI4UgK1aur6m32cFp5L+DpERg g==; IronPort-SDR: CGzwFgZnx38dfzy3f8q8Xm+puJ33BFnb4DM1BvkqwaF38Hj7IETfB7dGjdAjeim4iMDvI27Bgb +yICiF7lLYVnRVeN2quM6SHW3LNULatRt9IgxD6Hmrc5Mj67Nzo2VUMQ4fhnN8yNRMhhUTlXTw 6KLcvdEp5R6EdhQyGXTqq9+eC3ANvPCnHJ4q7XthvQrOvAPk/fETg5WqPtmUavy+SYUKK8t1lJ womw9WDinln+Lxa2xf8VRHl+rSWUFvWeazBmzkbVMb22LOT8PYyiB7Ovsoosv7e9z3TLTsGs4F G5g= X-IronPort-AV: E=Sophos;i="5.73,463,1583218800"; d="scan'208";a="81897758" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 02 Jun 2020 01:39:34 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 2 Jun 2020 01:39:33 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 2 Jun 2020 01:39:18 -0700 References: <20200513125532.24585-1-lars.povlsen@microchip.com> <20200513125532.24585-11-lars.povlsen@microchip.com> <20200528021826.GA3221035@bogus> From: Lars Povlsen To: Rob Herring List-Id: CC: Lars Povlsen , SoC Team , "Arnd Bergmann" , Stephen Boyd , Linus Walleij , Steen Hegelund , Microchip Linux Driver Support , Olof Johansson , Michael Turquette , , , , , , Alexandre Belloni Subject: Re: [PATCH 10/14] dt-bindings: clock: sparx5: Add Sparx5 SoC DPLL clock In-Reply-To: <20200528021826.GA3221035@bogus> Date: Tue, 2 Jun 2020 10:39:29 +0200 Message-ID: <87h7vtq2ta.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Rob Herring writes: > On Wed, May 13, 2020 at 02:55:28PM +0200, Lars Povlsen wrote: >> This add the DT bindings documentation for the Sparx5 SoC DPLL clock >> >> Reviewed-by: Alexandre Belloni >> Signed-off-by: Lars Povlsen >> --- >> .../bindings/clock/microchip,sparx5-dpll.yaml | 46 +++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/microchip,sparx5-dpll.yaml >> >> diff --git a/Documentation/devicetree/bindings/clock/microchip,sparx5-dpll.yaml b/Documentation/devicetree/bindings/clock/microchip,sparx5-dpll.yaml >> new file mode 100644 >> index 0000000000000..594007d8fc59a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/microchip,sparx5-dpll.yaml >> @@ -0,0 +1,46 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/microchip,sparx5-dpll.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Microchip Sparx5 DPLL Clock >> + >> +maintainers: >> + - Lars Povlsen >> + >> +description: | >> + The Sparx5 DPLL clock controller generates and supplies clock to >> + various peripherals within the SoC. >> + >> + This binding uses common clock bindings >> + [1] Documentation/devicetree/bindings/clock/clock-bindings.txt >> + >> +properties: >> + compatible: >> + const: microchip,sparx5-dpll >> + >> + reg: >> + items: >> + - description: dpll registers > > For a single entry, just: > > maxItems: 1 Ok. > >> + >> + '#clock-cells': >> + const: 1 >> + >> +required: >> + - compatible >> + - reg >> + - '#clock-cells' >> + >> +additionalProperties: false >> + >> +examples: >> + # Clock provider for eMMC: >> + - | >> + clks: clks@61110000c { > > clock-controller@1110000c { > Got that. >> + compatible = "microchip,sparx5-dpll"; >> + #clock-cells = <1>; >> + reg = <0x1110000c 0x24>; > > Looks like this is a sub-block in some other h/w block. What's the > parent device? That should be described and this should be part of it > either as a single node or a child node. Without a complete view of what > this block has I can't provide any guidance. No, as Alex noted to a similar comment in the temp. sensor driver, the chip is using packed register spaces predominantly. So don't put too much into the register offsets. ---Lars > > Rob -- Lars Povlsen, Microchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDD6C433E0 for ; Tue, 2 Jun 2020 08:39:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 119C3206A2 for ; Tue, 2 Jun 2020 08:39:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZDRMIK9/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="ZDgv91OE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 119C3206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-Reply-To:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rsJsbTPuZ1LeWnqFkzONJuJ3lwhnDXn/V7xyeDHg2R8=; b=ZDRMIK9/pNvHuLP0R8valMKnRF hKAejC5DhWRTyUHBilpDfG+WhzgZ5qpQHeH58NkssNYQYB12qNQ+o/IbxZ5xfxIwp82xgTAiFcnlT E9jEnwxny7izIZM4Ekl8NkwJrCKU+ck8CLRyJGoJOTpJfOVFfOFbXH5EM+vTSrM1rYO5l24Mn0lRT 2/KludrUv9dhzckjwHSiJohCSGwjgMurXIfQqcohmUwU0w/X9b1GDDbplJtdvWmTeXFCcF2KgI5Si wTB3BWBXdwFVnYkgqk+FS4g8gomi3mMQvjSYe3gvHGIjAI98wIKA6EoE44CZtwjcifKui6cTGG2Q4 rdSiqhiQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg2SR-00067x-1T; Tue, 02 Jun 2020 08:39:39 +0000 Received: from esa1.microchip.iphmx.com ([68.232.147.91]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg2SO-00066J-Ci for linux-arm-kernel@lists.infradead.org; Tue, 02 Jun 2020 08:39:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1591087176; x=1622623176; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=5oSerVw4BUQ1JnWRjiKwnbjMfhGlmnPWZ9idp3chc+k=; b=ZDgv91OEbVpknGTGkV4xoOlRuIiYtpVnD5rScn7BWRb8Ek8U34LcAsOu ZM8ukhS+sQ/AQeDJ44/ggvhbYHQVjZF7zCPyqbxxtZe/V2PIgWfr6XpRv plf9WD/HbNAfCngavsx8Z4o8FrC7My8PX2IcLW/EEtmJP1IGLu2+uZjsP /O5dFX4+bGIvsOPMDvXevggptdqqGRR0VBMV9LQefctRp53uOGHpz8knK 1//CGJ5NeZtuOGLtb9t7klF5Dn3BGCcqDjDm2QV7hXdlUoDM1UXzGURGl M0kirlhvmTvvMDtgbwGyt6gFwpf1ad3kW9yzCARc7TUn+qnYh8UALKwRI w==; IronPort-SDR: CGzwFgZnx38dfzy3f8q8Xm+puJ33BFnb4DM1BvkqwaF38Hj7IETfB7dGjdAjeim4iMDvI27Bgb +yICiF7lLYVnRVeN2quM6SHW3LNULatRt9IgxD6Hmrc5Mj67Nzo2VUMQ4fhnN8yNRMhhUTlXTw 6KLcvdEp5R6EdhQyGXTqq9+eC3ANvPCnHJ4q7XthvQrOvAPk/fETg5WqPtmUavy+SYUKK8t1lJ womw9WDinln+Lxa2xf8VRHl+rSWUFvWeazBmzkbVMb22LOT8PYyiB7Ovsoosv7e9z3TLTsGs4F G5g= X-IronPort-AV: E=Sophos;i="5.73,463,1583218800"; d="scan'208";a="81897758" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 02 Jun 2020 01:39:34 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 2 Jun 2020 01:39:33 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 2 Jun 2020 01:39:18 -0700 References: <20200513125532.24585-1-lars.povlsen@microchip.com> <20200513125532.24585-11-lars.povlsen@microchip.com> <20200528021826.GA3221035@bogus> From: Lars Povlsen To: Rob Herring Subject: Re: [PATCH 10/14] dt-bindings: clock: sparx5: Add Sparx5 SoC DPLL clock In-Reply-To: <20200528021826.GA3221035@bogus> Date: Tue, 2 Jun 2020 10:39:29 +0200 Message-ID: <87h7vtq2ta.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200602_013936_441332_4BF3308D X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: devicetree@vger.kernel.org, Alexandre Belloni , Arnd Bergmann , linux-gpio@vger.kernel.org, Stephen Boyd , Steen Hegelund , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Microchip Linux Driver Support , Michael Turquette , SoC Team , linux-arm-kernel@lists.infradead.org, Olof Johansson , Linus Walleij , Lars Povlsen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rob Herring writes: > On Wed, May 13, 2020 at 02:55:28PM +0200, Lars Povlsen wrote: >> This add the DT bindings documentation for the Sparx5 SoC DPLL clock >> >> Reviewed-by: Alexandre Belloni >> Signed-off-by: Lars Povlsen >> --- >> .../bindings/clock/microchip,sparx5-dpll.yaml | 46 +++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/microchip,sparx5-dpll.yaml >> >> diff --git a/Documentation/devicetree/bindings/clock/microchip,sparx5-dpll.yaml b/Documentation/devicetree/bindings/clock/microchip,sparx5-dpll.yaml >> new file mode 100644 >> index 0000000000000..594007d8fc59a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/microchip,sparx5-dpll.yaml >> @@ -0,0 +1,46 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/microchip,sparx5-dpll.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Microchip Sparx5 DPLL Clock >> + >> +maintainers: >> + - Lars Povlsen >> + >> +description: | >> + The Sparx5 DPLL clock controller generates and supplies clock to >> + various peripherals within the SoC. >> + >> + This binding uses common clock bindings >> + [1] Documentation/devicetree/bindings/clock/clock-bindings.txt >> + >> +properties: >> + compatible: >> + const: microchip,sparx5-dpll >> + >> + reg: >> + items: >> + - description: dpll registers > > For a single entry, just: > > maxItems: 1 Ok. > >> + >> + '#clock-cells': >> + const: 1 >> + >> +required: >> + - compatible >> + - reg >> + - '#clock-cells' >> + >> +additionalProperties: false >> + >> +examples: >> + # Clock provider for eMMC: >> + - | >> + clks: clks@61110000c { > > clock-controller@1110000c { > Got that. >> + compatible = "microchip,sparx5-dpll"; >> + #clock-cells = <1>; >> + reg = <0x1110000c 0x24>; > > Looks like this is a sub-block in some other h/w block. What's the > parent device? That should be described and this should be part of it > either as a single node or a child node. Without a complete view of what > this block has I can't provide any guidance. No, as Alex noted to a similar comment in the temp. sensor driver, the chip is using packed register spaces predominantly. So don't put too much into the register offsets. ---Lars > > Rob -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel