From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3BF4C433E0 for ; Mon, 1 Jun 2020 08:58:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A437E206C3 for ; Mon, 1 Jun 2020 08:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725778AbgFAI64 (ORCPT ); Mon, 1 Jun 2020 04:58:56 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:46922 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725290AbgFAI64 (ORCPT ); Mon, 1 Jun 2020 04:58:56 -0400 Received: from belgarion ([86.210.245.36]) by mwinf5d56 with ME id lkyc220050nqnCN03kypfp; Mon, 01 Jun 2020 10:58:53 +0200 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 01 Jun 2020 10:58:53 +0200 X-ME-IP: 86.210.245.36 From: Robert Jarzmik To: Christophe JAILLET Cc: daniel@zonque.org, haojian.zhuang@gmail.com, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 01 Jun 2020 10:58:36 +0200 In-Reply-To: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Sun, 31 May 2020 09:37:16 +0200") Message-ID: <87h7vvb1s3.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Christophe JAILLET writes: > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in > 'pxa2xx_pinctrl_init()'. > However, the corresponding 'pinctrl_unregister()' call in > 'pxa2xx_pinctrl_exit()' has not been removed. > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. > Remove it now to avoid some wondering in the future and save a few LoC. > > Signed-off-by: Christophe JAILLET Acked-by: Robert Jarzmik Would be even a better patch with a : Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Date: Mon, 01 Jun 2020 08:58:36 +0000 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-Id: <87h7vvb1s3.fsf@belgarion.home> List-Id: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Sun, 31 May 2020 09:37:16 +0200") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: linus.walleij@linaro.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com, linux-gpio@vger.kernel.org, daniel@zonque.org, linux-arm-kernel@lists.infradead.org Christophe JAILLET writes: > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in > 'pxa2xx_pinctrl_init()'. > However, the corresponding 'pinctrl_unregister()' call in > 'pxa2xx_pinctrl_exit()' has not been removed. > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. > Remove it now to avoid some wondering in the future and save a few LoC. > > Signed-off-by: Christophe JAILLET Acked-by: Robert Jarzmik Would be even a better patch with a : Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B610C433E0 for ; Mon, 1 Jun 2020 08:59:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E15B3206C3 for ; Mon, 1 Jun 2020 08:59:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BsvJyKL2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E15B3206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gKyEfaPO7tbm5fChdcq8xOEYJZhhC/RiRaZjJEdRX+Y=; b=BsvJyKL2ohh8Z7 HjvfsAxBcig7axKeyPZmktezn80pkkvF5NSFKZlkxG1F6c0LBw6VRzr+Tcus3v9N4ax5JGTB/cOxi GSdS6Db7U0Xvi/El2UcTilxtpx1dNtWXLrMP155et57c6XVoohSVLOCp37QRO2DwVBL+XaE4IB5Uf VXIqMYPJ6F2peGZ7d10Z+k/vNReHhktMhITvvLeIZ9mxrDpq1eMbJrmCTk6hqUaKw1nNKjK1vROF1 euv7pYSMTMH4InMU9uEwmkEW8IuxeBPi/S/2WlCHKuMchVUBvX3Slx8Bz6rTJxyIGeK95gYaLF5os eYj/WcXrXMcgYk4enNUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfgHd-0001a9-KE; Mon, 01 Jun 2020 08:59:01 +0000 Received: from smtp02.smtpout.orange.fr ([80.12.242.124] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfgHa-0001Yk-2w for linux-arm-kernel@lists.infradead.org; Mon, 01 Jun 2020 08:58:59 +0000 Received: from belgarion ([86.210.245.36]) by mwinf5d56 with ME id lkyc220050nqnCN03kypfp; Mon, 01 Jun 2020 10:58:53 +0200 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 01 Jun 2020 10:58:53 +0200 X-ME-IP: 86.210.245.36 From: Robert Jarzmik To: Christophe JAILLET Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 01 Jun 2020 10:58:36 +0200 In-Reply-To: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Sun, 31 May 2020 09:37:16 +0200") Message-ID: <87h7vvb1s3.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200601_015858_424109_3ACDE917 X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linus.walleij@linaro.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com, linux-gpio@vger.kernel.org, daniel@zonque.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Christophe JAILLET writes: > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in > 'pxa2xx_pinctrl_init()'. > However, the corresponding 'pinctrl_unregister()' call in > 'pxa2xx_pinctrl_exit()' has not been removed. > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. > Remove it now to avoid some wondering in the future and save a few LoC. > > Signed-off-by: Christophe JAILLET Acked-by: Robert Jarzmik Would be even a better patch with a : Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") Cheers. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel