All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [PATCH v2 21/21] ASoC: cleanup dai / component active code
Date: 14 May 2020 17:43:50 +0900	[thread overview]
Message-ID: <87h7wi7vp5.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87blmq9alx.wl-kuninori.morimoto.gx@renesas.com>


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

No one is using dai->active, snd_soc_component_is_active().
Let's remove these.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
	- adjust to latest patch-set

 include/sound/soc-component.h | 5 -----
 include/sound/soc-dai.h       | 2 --
 sound/soc/soc-dai.c           | 2 +-
 3 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h
index 820b9b618f97..9360936b7963 100644
--- a/include/sound/soc-component.h
+++ b/include/sound/soc-component.h
@@ -389,11 +389,6 @@ static inline void *snd_soc_component_get_drvdata(struct snd_soc_component *c)
 	return dev_get_drvdata(c->dev);
 }
 
-static inline bool snd_soc_component_is_active(
-	struct snd_soc_component *component)
-{
-	return component->active != 0;
-}
 #define snd_soc_component_active(component)  ((component)->active)
 
 /* component pin */
diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h
index d55dd0474096..e87b510f6f54 100644
--- a/include/sound/soc-dai.h
+++ b/include/sound/soc-dai.h
@@ -357,8 +357,6 @@ struct snd_soc_dai {
 	/* DAI runtime info */
 	unsigned int stream_active[SNDRV_PCM_STREAM_LAST + 1]; /* usage count */
 
-	unsigned int active;
-
 	struct snd_soc_dapm_widget *playback_widget;
 	struct snd_soc_dapm_widget *capture_widget;
 
diff --git a/sound/soc/soc-dai.c b/sound/soc/soc-dai.c
index 8172ff42d796..ce4e1fd1ab79 100644
--- a/sound/soc/soc-dai.c
+++ b/sound/soc/soc-dai.c
@@ -393,7 +393,7 @@ void snd_soc_dai_action(struct snd_soc_dai *dai,
 {
 	/* see snd_soc_dai_stream_active() */
 	dai->stream_active[stream]	+= action;
-	dai->active			+= action;
+
 	/* see snd_soc_component_active() */
 	dai->component->active		+= action;
 }
-- 
2.17.1


  parent reply	other threads:[~2020-05-14  8:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14  8:36 [PATCH v2 00/21] ASoC: cleanup DAI/Component activity Kuninori Morimoto
2020-05-14  8:37 ` [PATCH v2 01/21] ASoC: soc-pcm: replace snd_soc_runtime_activate()/deactivate() to macro Kuninori Morimoto
2020-05-14 10:41   ` Mark Brown
2020-05-14 23:35     ` Kuninori Morimoto
2020-05-14  8:37 ` [PATCH v2 02/21] ASoC: soc-dai: add snd_soc_dai_action() Kuninori Morimoto
2020-05-14  8:38 ` [PATCH v2 03/21] ASoC: soc-dapm: use snd_soc_dai_activate()/deactivate() Kuninori Morimoto
2020-05-14  8:39 ` [PATCH v2 04/21] ASoC: soc-dai: add snd_soc_dai_active() Kuninori Morimoto
2020-05-14  8:39 ` [PATCH v2 05/21] ASoC: soc-component: add snd_soc_component_active() Kuninori Morimoto
2020-05-14  8:40 ` [PATCH v2 06/21] ASoC: soc-dai: add snd_soc_dai_stream_active() Kuninori Morimoto
2020-05-14  8:40 ` [PATCH v2 07/21] ASoC: use snd_soc_xxx_active() Kuninori Morimoto
2020-05-14  8:41 ` [PATCH v2 08/21] ASoC: atomel: " Kuninori Morimoto
2020-05-14  8:41 ` [PATCH v2 09/21] ASoC: bcm: " Kuninori Morimoto
2020-05-14  8:41 ` [PATCH v2 10/21] ASoC: cirrus: " Kuninori Morimoto
2020-05-14  8:41 ` [PATCH v2 11/21] ASoC: codecs: " Kuninori Morimoto
2020-05-14  8:42 ` [PATCH v2 12/21] ASoC: fsl: " Kuninori Morimoto
2020-05-14  8:42 ` [PATCH v2 13/21] ASoC: intel: " Kuninori Morimoto
2020-05-14  8:42 ` [PATCH v2 14/21] ASoC: jz4740: " Kuninori Morimoto
2020-05-14  8:42 ` [PATCH v2 15/21] ASoC: mediatek: " Kuninori Morimoto
2020-05-14  8:42 ` [PATCH v2 16/21] ASoC: meson: " Kuninori Morimoto
2020-05-14  8:42 ` [PATCH v2 17/21] ASoC: pxa: " Kuninori Morimoto
2020-05-14  8:43 ` [PATCH v2 18/21] ASoC: ti: " Kuninori Morimoto
2020-05-14  9:08   ` Peter Ujfalusi
2020-05-14  8:43 ` [PATCH v2 19/21] ASoC: uniphier: " Kuninori Morimoto
2020-05-14  8:43 ` [PATCH v2 20/21] ASoC: dwc: " Kuninori Morimoto
2020-05-14  8:43 ` Kuninori Morimoto [this message]
2020-05-14 17:26 ` [PATCH v2 00/21] ASoC: cleanup DAI/Component activity Ranjani Sridharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7wi7vp5.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.