From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E99D9C10F27 for ; Wed, 11 Mar 2020 14:42:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C37320575 for ; Wed, 11 Mar 2020 14:42:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gFUSrBoE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C37320575 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jC2Yq-00022a-QK for qemu-devel@archiver.kernel.org; Wed, 11 Mar 2020 10:42:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47673) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jC2Y0-0001TA-FF for qemu-devel@nongnu.org; Wed, 11 Mar 2020 10:41:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jC2Xx-0000KQ-8c for qemu-devel@nongnu.org; Wed, 11 Mar 2020 10:41:23 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:21843 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jC2Xx-0000JA-58 for qemu-devel@nongnu.org; Wed, 11 Mar 2020 10:41:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583937678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eg2CZjPbTX8SjRwNDnoDsSdouoJltA9NNOsfHqNxAuU=; b=gFUSrBoEMhYKZoZylkVEKkKpImw4UyBPGVlozUqJZd4UrGKJaZCy3VKBQ008y+zZPKtkCc rLVOFQ3/beCetjZ79aZrLcMB/0i2LNLkCN/fou51RiiZwGfRYQPLeO4nyc+mDB6yMKCx+I h1ZMW6taLqxrDZRovlOrmXlGZNZEIhg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-5WOfSgRnO7u9pEUtHmUJ6g-1; Wed, 11 Mar 2020 10:41:15 -0400 X-MC-Unique: 5WOfSgRnO7u9pEUtHmUJ6g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0810A800EBC; Wed, 11 Mar 2020 14:41:13 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E33A9CA3; Wed, 11 Mar 2020 14:41:07 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 99B5711386A6; Wed, 11 Mar 2020 15:41:05 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp References: <20200306051536.27803-1-vsementsov@virtuozzo.com> <20200306051536.27803-3-vsementsov@virtuozzo.com> <87lfo997hs.fsf@dusky.pond.sub.org> <87a74ngriw.fsf@dusky.pond.sub.org> <71ada30b-c72b-6251-cc38-877ddd4156a8@virtuozzo.com> Date: Wed, 11 Mar 2020 15:41:05 +0100 In-Reply-To: <71ada30b-c72b-6251-cc38-877ddd4156a8@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Wed, 11 Mar 2020 17:05:24 +0300") Message-ID: <87h7yvx8ce.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, Paul Durrant , qemu-devel@nongnu.org, Laszlo Ersek , Christian Schoenebeck , Markus Armbruster , Michael Roth , Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Vladimir Sementsov-Ogievskiy writes: > 11.03.2020 12:38, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 09.03.2020 12:56, Markus Armbruster wrote: >>>> Suggest >>>> >>>> scripts: Coccinelle script to use auto-propagated errp >>>> >>>> or >>>> >>>> scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() >>>> >>>> Vladimir Sementsov-Ogievskiy writes: >> [...] >>>>> +// Note, that we update everything related to matched by rule1 funct= ion name >>>>> +// and local_err name. We may match something not related to the pat= tern >>>>> +// matched by rule1. For example, local_err may be defined with the = same name >>>>> +// in different blocks inside one function, and in one block follow = the >>>>> +// propagation pattern and in other block doesn't. Or we may have se= veral >>>>> +// functions with the same name (for different configurations). >>>> >>>> Context: rule1 matches functions that have all three of >>>> >>>> * an Error **errp parameter >>>> >>>> * an Error *local_err =3D NULL variable declaration >>>> >>>> * an error_propagate(errp, local_err) or error_propagate_prepend(errp, >>>> local_err, ...) expression, where @errp is the parameter and >>>> @local_err is the variable. >>>> >>>> If I understand you correctly, you're pointing out two potential issue= s: >>>> >>>> 1. This rule can match functions rule1 does not match if there is >>>> another function with the same name that rule1 does match. >>>> >>>> 2. This rule matches in the entire function matched by rule1, even whe= n >>>> parts of that function use a different @errp or @local_err. >>>> >>>> I figure these apply to all rules with identifier rule1.fn, not just >>>> this one. Correct? >>>> >>>> Regarding 1. There must be a better way to chain rules together, but = I >>>> don't know it. >>> >>> Hmm, what about something like this: >>> >>> @rule1 disable optional_qualifier exists@ >>> identifier fn, local_err; >>> symbol errp; >>> @@ >>> >>> fn(..., Error ** >>> - errp >>> + ___errp_coccinelle_updating___ >>> , ...) >>> { >>> ... >>> Error *local_err =3D NULL; >>> ... >>> ( >>> error_propagate_prepend(errp, local_err, ...); >>> | >>> error_propagate(errp, local_err); >>> ) >>> ... >>> } >>> >>> >>> [..] >>> >>> match symbol ___errp_coccinelle_updating___ in following rules in funct= ion header >>> >>> [..] >>> >>> >>> @ disable optional_qualifier@ >>> identifier fn, local_err; >>> symbol errp; >>> @@ >>> >>> fn(..., Error ** >>> - ___errp_coccinelle_updating___ >>> + errp >>> , ...) >>> { >>> ... >>> } >>> >>> >>> - hacky, but seems not more hacky than python detection, and should wor= k better >> >> As simple, forceful and unsubtle as a sledgehammer. I like it :) >> > > > Hmm, not so simple. > > It leads to reindenting of function header, which is bad. Because ___errp_coccinelle_updating___ is longer than errp, I guess. Try ____? > Possible solution is instead > > fn(...) > { > + ___errp_coccinelle_updating___(); > > > but this slow down coccinelle. For example, on block.c from ~3s to 1m16s. > > . > > So, I'm returning to just a warning. > > I think something simple like > > @@ > identifier rule1.fn; > position p !=3D rule1.p; > @@ > > fn@p(...) {...} > > @ script:python@ > > > > should work. Up to you. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC8EC10F27 for ; Wed, 11 Mar 2020 14:41:48 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EBCD20575 for ; Wed, 11 Mar 2020 14:41:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gtXztGcV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EBCD20575 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jC2Xv-0003JL-RX; Wed, 11 Mar 2020 14:41:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jC2Xt-0003JG-Mq for xen-devel@lists.xenproject.org; Wed, 11 Mar 2020 14:41:17 +0000 X-Inumbo-ID: 5d4dcfb2-63a6-11ea-a6c1-bc764e2007e4 Received: from us-smtp-delivery-1.mimecast.com (unknown [207.211.31.120]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 5d4dcfb2-63a6-11ea-a6c1-bc764e2007e4; Wed, 11 Mar 2020 14:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583937676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eg2CZjPbTX8SjRwNDnoDsSdouoJltA9NNOsfHqNxAuU=; b=gtXztGcVv6ArWlzpdVkft/+DP8v/IIZy4Ry3OAzo9pD6uOUpDDOrNf6rBtFr8XM/DWGie4 5jRz1KoiDttbOi4O5slwQTZjGi/lCmAG+RGAlFezWbUKMoIdQIvm8KW47rtheEGZdyKYFo yoZr/t4nzcaEK35kRraa2tmw1kavMKs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-5WOfSgRnO7u9pEUtHmUJ6g-1; Wed, 11 Mar 2020 10:41:15 -0400 X-MC-Unique: 5WOfSgRnO7u9pEUtHmUJ6g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0810A800EBC; Wed, 11 Mar 2020 14:41:13 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E33A9CA3; Wed, 11 Mar 2020 14:41:07 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 99B5711386A6; Wed, 11 Mar 2020 15:41:05 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy References: <20200306051536.27803-1-vsementsov@virtuozzo.com> <20200306051536.27803-3-vsementsov@virtuozzo.com> <87lfo997hs.fsf@dusky.pond.sub.org> <87a74ngriw.fsf@dusky.pond.sub.org> <71ada30b-c72b-6251-cc38-877ddd4156a8@virtuozzo.com> Date: Wed, 11 Mar 2020 15:41:05 +0100 In-Reply-To: <71ada30b-c72b-6251-cc38-877ddd4156a8@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Wed, 11 Mar 2020 17:05:24 +0300") Message-ID: <87h7yvx8ce.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Xen-devel] [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , qemu-block@nongnu.org, Paul Durrant , qemu-devel@nongnu.org, Laszlo Ersek , Christian Schoenebeck , Markus Armbruster , Michael Roth , Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Berger Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VmxhZGltaXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPiB3 cml0ZXM6Cgo+IDExLjAzLjIwMjAgMTI6MzgsIE1hcmt1cyBBcm1icnVzdGVyIHdyb3RlOgo+PiBW bGFkaW1pciBTZW1lbnRzb3YtT2dpZXZza2l5IDx2c2VtZW50c292QHZpcnR1b3p6by5jb20+IHdy aXRlczoKPj4KPj4+IDA5LjAzLjIwMjAgMTI6NTYsIE1hcmt1cyBBcm1icnVzdGVyIHdyb3RlOgo+ Pj4+IFN1Z2dlc3QKPj4+Pgo+Pj4+ICAgICAgIHNjcmlwdHM6IENvY2NpbmVsbGUgc2NyaXB0IHRv IHVzZSBhdXRvLXByb3BhZ2F0ZWQgZXJycAo+Pj4+Cj4+Pj4gb3IKPj4+Pgo+Pj4+ICAgICAgIHNj cmlwdHM6IENvY2NpbmVsbGUgc2NyaXB0IHRvIHVzZSBFUlJQX0FVVE9fUFJPUEFHQVRFKCkKPj4+ Pgo+Pj4+IFZsYWRpbWlyIFNlbWVudHNvdi1PZ2lldnNraXkgPHZzZW1lbnRzb3ZAdmlydHVvenpv LmNvbT4gd3JpdGVzOgo+PiBbLi4uXQo+Pj4+PiArLy8gTm90ZSwgdGhhdCB3ZSB1cGRhdGUgZXZl cnl0aGluZyByZWxhdGVkIHRvIG1hdGNoZWQgYnkgcnVsZTEgZnVuY3Rpb24gbmFtZQo+Pj4+PiAr Ly8gYW5kIGxvY2FsX2VyciBuYW1lLiBXZSBtYXkgbWF0Y2ggc29tZXRoaW5nIG5vdCByZWxhdGVk IHRvIHRoZSBwYXR0ZXJuCj4+Pj4+ICsvLyBtYXRjaGVkIGJ5IHJ1bGUxLiBGb3IgZXhhbXBsZSwg bG9jYWxfZXJyIG1heSBiZSBkZWZpbmVkIHdpdGggdGhlIHNhbWUgbmFtZQo+Pj4+PiArLy8gaW4g ZGlmZmVyZW50IGJsb2NrcyBpbnNpZGUgb25lIGZ1bmN0aW9uLCBhbmQgaW4gb25lIGJsb2NrIGZv bGxvdyB0aGUKPj4+Pj4gKy8vIHByb3BhZ2F0aW9uIHBhdHRlcm4gYW5kIGluIG90aGVyIGJsb2Nr IGRvZXNuJ3QuIE9yIHdlIG1heSBoYXZlIHNldmVyYWwKPj4+Pj4gKy8vIGZ1bmN0aW9ucyB3aXRo IHRoZSBzYW1lIG5hbWUgKGZvciBkaWZmZXJlbnQgY29uZmlndXJhdGlvbnMpLgo+Pj4+Cj4+Pj4g Q29udGV4dDogcnVsZTEgbWF0Y2hlcyBmdW5jdGlvbnMgdGhhdCBoYXZlIGFsbCB0aHJlZSBvZgo+ Pj4+Cj4+Pj4gKiBhbiBFcnJvciAqKmVycnAgcGFyYW1ldGVyCj4+Pj4KPj4+PiAqIGFuIEVycm9y ICpsb2NhbF9lcnIgPSBOVUxMIHZhcmlhYmxlIGRlY2xhcmF0aW9uCj4+Pj4KPj4+PiAqIGFuIGVy cm9yX3Byb3BhZ2F0ZShlcnJwLCBsb2NhbF9lcnIpIG9yIGVycm9yX3Byb3BhZ2F0ZV9wcmVwZW5k KGVycnAsCj4+Pj4gICAgIGxvY2FsX2VyciwgLi4uKSBleHByZXNzaW9uLCB3aGVyZSBAZXJycCBp cyB0aGUgcGFyYW1ldGVyIGFuZAo+Pj4+ICAgICBAbG9jYWxfZXJyIGlzIHRoZSB2YXJpYWJsZS4K Pj4+Pgo+Pj4+IElmIEkgdW5kZXJzdGFuZCB5b3UgY29ycmVjdGx5LCB5b3UncmUgcG9pbnRpbmcg b3V0IHR3byBwb3RlbnRpYWwgaXNzdWVzOgo+Pj4+Cj4+Pj4gMS4gVGhpcyBydWxlIGNhbiBtYXRj aCBmdW5jdGlvbnMgcnVsZTEgZG9lcyBub3QgbWF0Y2ggaWYgdGhlcmUgaXMKPj4+PiBhbm90aGVy IGZ1bmN0aW9uIHdpdGggdGhlIHNhbWUgbmFtZSB0aGF0IHJ1bGUxIGRvZXMgbWF0Y2guCj4+Pj4K Pj4+PiAyLiBUaGlzIHJ1bGUgbWF0Y2hlcyBpbiB0aGUgZW50aXJlIGZ1bmN0aW9uIG1hdGNoZWQg YnkgcnVsZTEsIGV2ZW4gd2hlbgo+Pj4+IHBhcnRzIG9mIHRoYXQgZnVuY3Rpb24gdXNlIGEgZGlm ZmVyZW50IEBlcnJwIG9yIEBsb2NhbF9lcnIuCj4+Pj4KPj4+PiBJIGZpZ3VyZSB0aGVzZSBhcHBs eSB0byBhbGwgcnVsZXMgd2l0aCBpZGVudGlmaWVyIHJ1bGUxLmZuLCBub3QganVzdAo+Pj4+IHRo aXMgb25lLiAgQ29ycmVjdD8KPj4+Pgo+Pj4+IFJlZ2FyZGluZyAxLiAgVGhlcmUgbXVzdCBiZSBh IGJldHRlciB3YXkgdG8gY2hhaW4gcnVsZXMgdG9nZXRoZXIsIGJ1dCBJCj4+Pj4gZG9uJ3Qga25v dyBpdC4KPj4+Cj4+PiBIbW0sIHdoYXQgYWJvdXQgc29tZXRoaW5nIGxpa2UgdGhpczoKPj4+Cj4+ PiBAcnVsZTEgZGlzYWJsZSBvcHRpb25hbF9xdWFsaWZpZXIgZXhpc3RzQAo+Pj4gaWRlbnRpZmll ciBmbiwgbG9jYWxfZXJyOwo+Pj4gc3ltYm9sIGVycnA7Cj4+PiBAQAo+Pj4KPj4+ICAgZm4oLi4u LCBFcnJvciAqKgo+Pj4gLSBlcnJwCj4+PiArIF9fX2VycnBfY29jY2luZWxsZV91cGRhdGluZ19f Xwo+Pj4gICAgICAsIC4uLikKPj4+ICAgewo+Pj4gICAgICAgLi4uCj4+PiAgICAgICBFcnJvciAq bG9jYWxfZXJyID0gTlVMTDsKPj4+ICAgICAgIC4uLgo+Pj4gKAo+Pj4gICAgICBlcnJvcl9wcm9w YWdhdGVfcHJlcGVuZChlcnJwLCBsb2NhbF9lcnIsIC4uLik7Cj4+PiB8Cj4+PiAgICAgIGVycm9y X3Byb3BhZ2F0ZShlcnJwLCBsb2NhbF9lcnIpOwo+Pj4gKQo+Pj4gICAgICAgLi4uCj4+PiAgIH0K Pj4+Cj4+Pgo+Pj4gWy4uXQo+Pj4KPj4+IG1hdGNoIHN5bWJvbCBfX19lcnJwX2NvY2NpbmVsbGVf dXBkYXRpbmdfX18gaW4gZm9sbG93aW5nIHJ1bGVzIGluIGZ1bmN0aW9uIGhlYWRlcgo+Pj4KPj4+ IFsuLl0KPj4+Cj4+Pgo+Pj4gQCBkaXNhYmxlIG9wdGlvbmFsX3F1YWxpZmllckAKPj4+IGlkZW50 aWZpZXIgZm4sIGxvY2FsX2VycjsKPj4+IHN5bWJvbCBlcnJwOwo+Pj4gQEAKPj4+Cj4+PiAgIGZu KC4uLiwgRXJyb3IgKioKPj4+IC0gX19fZXJycF9jb2NjaW5lbGxlX3VwZGF0aW5nX19fCj4+PiAr IGVycnAKPj4+ICAgICAgLCAuLi4pCj4+PiAgIHsKPj4+ICAgICAgIC4uLgo+Pj4gICB9Cj4+Pgo+ Pj4KPj4+IC0gaGFja3ksIGJ1dCBzZWVtcyBub3QgbW9yZSBoYWNreSB0aGFuIHB5dGhvbiBkZXRl Y3Rpb24sIGFuZCBzaG91bGQgd29yayBiZXR0ZXIKPj4KPj4gQXMgc2ltcGxlLCBmb3JjZWZ1bCBh bmQgdW5zdWJ0bGUgYXMgYSBzbGVkZ2VoYW1tZXIuICBJIGxpa2UgaXQgOikKPj4KPgo+Cj4gSG1t LCBub3Qgc28gc2ltcGxlLgo+Cj4gSXQgbGVhZHMgdG8gcmVpbmRlbnRpbmcgb2YgZnVuY3Rpb24g aGVhZGVyLCB3aGljaCBpcyBiYWQuCgpCZWNhdXNlIF9fX2VycnBfY29jY2luZWxsZV91cGRhdGlu Z19fXyBpcyBsb25nZXIgdGhhbiBlcnJwLCBJIGd1ZXNzLgpUcnkgX19fXz8KCj4gUG9zc2libGUg c29sdXRpb24gaXMgaW5zdGVhZAo+Cj4gZm4oLi4uKQo+IHsKPiArICAgX19fZXJycF9jb2NjaW5l bGxlX3VwZGF0aW5nX19fKCk7Cj4KPgo+IGJ1dCB0aGlzIHNsb3cgZG93biBjb2NjaW5lbGxlLiBG b3IgZXhhbXBsZSwgb24gYmxvY2suYyBmcm9tIH4zcyB0byAxbTE2cy4KPgo+IC4KPgo+IFNvLCBJ J20gcmV0dXJuaW5nIHRvIGp1c3QgYSB3YXJuaW5nLgo+Cj4gSSB0aGluayBzb21ldGhpbmcgc2lt cGxlIGxpa2UKPgo+IEBACj4gaWRlbnRpZmllciBydWxlMS5mbjsKPiBwb3NpdGlvbiBwICE9IHJ1 bGUxLnA7Cj4gQEAKPgo+IGZuQHAoLi4uKSB7Li4ufQo+Cj4gQCBzY3JpcHQ6cHl0aG9uQAo+Cj4g PHByaW50IHdhcm5pbmc+Cj4KPiBzaG91bGQgd29yay4KClVwIHRvIHlvdS4KCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBs aXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2pl Y3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs