From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD15FC10F03 for ; Wed, 13 Mar 2019 06:24:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5392217F5 for ; Wed, 13 Mar 2019 06:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbfCMGYB (ORCPT ); Wed, 13 Mar 2019 02:24:01 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:7180 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726089AbfCMGYB (ORCPT ); Wed, 13 Mar 2019 02:24:01 -0400 Date: 13 Mar 2019 15:23:58 +0900 X-IronPort-AV: E=Sophos;i="5.58,473,1544454000"; d="scan'208";a="10223427" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 13 Mar 2019 15:23:58 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id AFD7D402A1F4; Wed, 13 Mar 2019 15:23:58 +0900 (JST) Message-ID: <87h8c7gv73.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jiada Wang Cc: , , , , , , , , , , , , Subject: Re: [PATCH 5/5] ASoC: rsnd: dma: use extended audio dmac registers when available In-Reply-To: <20190313055811.26135-1-jiada_wang@mentor.com> References: <20190313055811.26135-1-jiada_wang@mentor.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiada > Some of SoCs have both basic and extended dmac registers set > basic set only supports busif0 ~ busif3, in order to use > busif4 ~ busif7, extended audio dmac registers need to be used. > > This patch changes to use extended dmac registers set when it is > available in device-tree. > > Signed-off-by: Jiada Wang > --- 1st of all, if you want to post this kind of patch-set, you *should* post driver side patch 1st, and if it was accepted, you need to post SoC side patch. Then, you need to indicate to SoC maintainer which branch/commit should be based. Otherwise, it will 100% breaks git-bisect. 2nd, in my understanding, our conclusion at Renesas-ML is that we don't need to think about basic/extend DMAC register. Because extend area is 100% covering basic area. In other words, it is compatible. Driver side don't need to think about it. > --- a/sound/soc/sh/rcar/dma.c > +++ b/sound/soc/sh/rcar/dma.c > @@ -830,7 +830,10 @@ int rsnd_dma_probe(struct rsnd_priv *priv) > /* > * for Gen2 or later > */ > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "audmapp"); > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "extaudmapp"); > + if (!res) > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > + "audmapp"); > dmac = devm_kzalloc(dev, sizeof(*dmac), GFP_KERNEL); > if (!dmac || !res) { > dev_err(dev, "dma allocate failed\n"); > -- > 2.19.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 5/5] ASoC: rsnd: dma: use extended audio dmac registers when available Date: 13 Mar 2019 15:23:58 +0900 Message-ID: <87h8c7gv73.wl-kuninori.morimoto.gx@renesas.com> References: <20190313055811.26135-1-jiada_wang@mentor.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20190313055811.26135-1-jiada_wang@mentor.com> Sender: linux-kernel-owner@vger.kernel.org To: Jiada Wang Cc: horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, geert@linux-m68k.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org List-Id: devicetree@vger.kernel.org Hi Jiada > Some of SoCs have both basic and extended dmac registers set > basic set only supports busif0 ~ busif3, in order to use > busif4 ~ busif7, extended audio dmac registers need to be used. > > This patch changes to use extended dmac registers set when it is > available in device-tree. > > Signed-off-by: Jiada Wang > --- 1st of all, if you want to post this kind of patch-set, you *should* post driver side patch 1st, and if it was accepted, you need to post SoC side patch. Then, you need to indicate to SoC maintainer which branch/commit should be based. Otherwise, it will 100% breaks git-bisect. 2nd, in my understanding, our conclusion at Renesas-ML is that we don't need to think about basic/extend DMAC register. Because extend area is 100% covering basic area. In other words, it is compatible. Driver side don't need to think about it. > --- a/sound/soc/sh/rcar/dma.c > +++ b/sound/soc/sh/rcar/dma.c > @@ -830,7 +830,10 @@ int rsnd_dma_probe(struct rsnd_priv *priv) > /* > * for Gen2 or later > */ > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "audmapp"); > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "extaudmapp"); > + if (!res) > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > + "audmapp"); > dmac = devm_kzalloc(dev, sizeof(*dmac), GFP_KERNEL); > if (!dmac || !res) { > dev_err(dev, "dma allocate failed\n"); > -- > 2.19.2 >