From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH net-next v9 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Date: Mon, 14 May 2018 11:08:28 +0200 Message-ID: <87h8nawqnn.fsf@toke.dk> References: <152578993399.4805.688094683770472380.stgit@alrua-kau> <152579005972.4805.2514975750552805066.stgit@alrua-kau> <20180513.200948.1658763899383204062.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net To: David Miller Return-path: Received: from mail.toke.dk ([52.28.52.200]:45755 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbeENJIj (ORCPT ); Mon, 14 May 2018 05:08:39 -0400 In-Reply-To: <20180513.200948.1658763899383204062.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: David Miller writes: > From: Toke H=C3=B8iland-J=C3=B8rgensen > Date: Tue, 08 May 2018 16:34:19 +0200 > >> +struct cake_flow { >> + /* this stuff is all needed per-flow at dequeue time */ >> + struct sk_buff *head; >> + struct sk_buff *tail; > > Please do not invent your own SKB list handling mechanism. We didn't invent it, we inherited it from fq_codel. I was actually about to fix that, but then I noticed it was still around in fq_codel, and so let it be. I can certainly fix it anyway, but, erm, why is it acceptable in fq_codel but not in cake? struct sk_buff_head is not that new, is it? >> +static void cake_heapify(struct cake_sched_data *q, u16 i) >> +{ >> + static const u32 a =3D CAKE_MAX_TINS * CAKE_QUEUES; >> + u32 m =3D i; >> + u32 mb =3D cake_heap_get_backlog(q, m); > > Please order local variables from longest to shortest line. > > The entire submissions has this problem all over the place, please > correct it patch-series wide. Right-oh, one plantation of reverse christmas trees coming right up :) -Toke