All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/physfs: needs threads support
@ 2018-01-19 13:59 Romain Naour
  2018-01-27 10:21 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Romain Naour @ 2018-01-19 13:59 UTC (permalink / raw)
  To: buildroot

When physfs is build for a Linux system the PHYSFS_PLATFORM_POSIX
(which enable code that use pthread_*()) symbol must defined,
so threads support is required.
The physfs build system used by the previous version didn't correctly
set PHYSFS_PLATFORM_POSIX for system without pthread support.

Add pthread dependency.

Fixes:
http://autobuild.buildroot.org/results/75d/75d68ff9da42d61f47d80b463445c12bc51ed1a4

Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
 package/physfs/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/physfs/Config.in b/package/physfs/Config.in
index dad3ab4..c272d88 100644
--- a/package/physfs/Config.in
+++ b/package/physfs/Config.in
@@ -1,10 +1,11 @@
 config BR2_PACKAGE_PHYSFS
 	bool "physfs"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  PhysicsFS; a portable, flexible file i/o abstraction.
 
 	  http://icculus.org/physfs
 
-comment "physfs needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "physfs needs a toolchain w/ C++, threads"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] package/physfs: needs threads support
  2018-01-19 13:59 [Buildroot] [PATCH] package/physfs: needs threads support Romain Naour
@ 2018-01-27 10:21 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2018-01-27 10:21 UTC (permalink / raw)
  To: buildroot

>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:

 > When physfs is build for a Linux system the PHYSFS_PLATFORM_POSIX
 > (which enable code that use pthread_*()) symbol must defined,
 > so threads support is required.
 > The physfs build system used by the previous version didn't correctly
 > set PHYSFS_PLATFORM_POSIX for system without pthread support.

 > Add pthread dependency.

 > Fixes:
 > http://autobuild.buildroot.org/results/75d/75d68ff9da42d61f47d80b463445c12bc51ed1a4

 > Signed-off-by: Romain Naour <romain.naour@smile.fr>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-27 10:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-19 13:59 [Buildroot] [PATCH] package/physfs: needs threads support Romain Naour
2018-01-27 10:21 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.