All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: David Michael <fedora.dm0@gmail.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Cleber Rosa <crosa@redhat.com>,
	qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3
Date: Mon, 02 Oct 2017 08:17:12 +0200	[thread overview]
Message-ID: <87h8virs47.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170918153644.GA12759@stefanha-x1.localdomain> (Stefan Hajnoczi's message of "Mon, 18 Sep 2017 16:36:44 +0100")

Stefan Hajnoczi <stefanha@gmail.com> writes:

> On Sat, Aug 19, 2017 at 10:58:44PM -0700, David Michael wrote:
>> This allows building with "./configure --python=python3", where
>> the python3 program is at least version 3.6.  It preserves
>> compatibility with Python 2.  The changes include:
>> 
>>   - Avoiding "print" usage
>>   - Using bytes with files opened in binary mode
>>   - Switching .iteritems() to .items()
>>   - Adding fallback imports for functions moved to other modules
>> 
>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
>> ---
>> 
>> Hi,
>> 
>> I've been applying these changes when building on Fedora 26, which does
>> not include any Python 2 packages by default.  It was tested with Python
>> 2.7 and 3.6.
>> 
>> I just saw the list of scripts that need updating on the mailing list,
>> and this doesn't cover all of them, but it is enough to build a binary
>> for running virtual machines with KVM.  Maybe it is still useful as a
>> starting point.
>> 
>> Thanks.
>
>
> Markus,
> You wanted to discuss the general direction of Python version support
> before applying this.

Dan has since posted competing patches.

> Has consensus been reached?

I need to decide how much I hate supporting both Python 2 and Python 3,
and that involves looking at both patch sets in more detail.

QAPI is a rather busy subsystem, and right now my review queue is in a
state where I have to decide whom to annoy and disappoint with overly
long delays.

Given the choice between addressing a problem that doesn't really exist,
yet (Python 2 going away) and addressing problems that are hurting us
*now* (such as QAPI's inability to express compile-time conditionals), I
have to prioritize the latter.  I wish I wouldn't have to make such
choices, and I apologize for the inconvenience.

      reply	other threads:[~2017-10-02  6:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-20  5:58 [Qemu-devel] [PATCH] scripts: Support building with Python 3 David Michael
2017-08-21 14:29 ` Markus Armbruster
2017-08-30 17:09   ` Stefan Hajnoczi
2017-08-31  6:35     ` Markus Armbruster
2017-08-31 10:27       ` Peter Maydell
2017-08-31 10:47         ` Daniel P. Berrange
2017-08-31 10:55           ` Peter Maydell
2017-08-31 11:02             ` Daniel P. Berrange
2017-08-31 12:44               ` Markus Armbruster
2017-08-31 13:22                 ` Kashyap Chamarthy
2017-08-31 12:50               ` Peter Maydell
2017-08-31 12:58         ` Markus Armbruster
2017-08-31 13:14           ` Daniel P. Berrange
2017-08-31 13:19             ` Peter Maydell
2017-08-31 13:25               ` Daniel P. Berrange
2017-08-31 13:32                 ` Peter Maydell
2017-09-01 19:26             ` Max Reitz
2017-08-31 13:29           ` Peter Maydell
2017-08-30 17:15 ` Stefan Hajnoczi
2017-09-18 15:36 ` Stefan Hajnoczi
2017-10-02  6:17   ` Markus Armbruster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8virs47.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=fedora.dm0@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.