From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:52692 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753650AbdIYEeA (ORCPT ); Mon, 25 Sep 2017 00:34:00 -0400 From: Kalle Valo To: Arnd Bergmann Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Mauro Carvalho Chehab , Jiri Pirko , "David S. Miller" , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Masahiro Yamada , Michal Marek , Andrew Morton , Kees Cook , Geert Uytterhoeven , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, kasan-dev@googlegroups.com, linux-kbuild@vger.kernel.org, Jakub Jelinek , Martin =?utf-8?Q?Li=C5=A1ka?= Subject: Re: [PATCH v4 1/9] brcmsmac: make some local variables 'static const' to reduce stack size References: <20170922212930.620249-1-arnd@arndb.de> <20170922212930.620249-2-arnd@arndb.de> Date: Mon, 25 Sep 2017 07:33:50 +0300 In-Reply-To: <20170922212930.620249-2-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 22 Sep 2017 23:29:12 +0200") Message-ID: <87h8vr75xt.fsf@kamboji.qca.qualcomm.com> (sfid-20170925_063529_155004_9851D8A1) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Arnd Bergmann writes: > With KASAN and a couple of other patches applied, this driver is one > of the few remaining ones that actually use more than 2048 bytes of > kernel stack: > > broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy_gainctrl': > broadcom/brcm80211/brcmsmac/phy/phy_n.c:16065:1: warning: the frame size of 3264 bytes is larger than 2048 bytes [-Wframe-larger-than=] > broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy': > broadcom/brcm80211/brcmsmac/phy/phy_n.c:17138:1: warning: the frame size of 2864 bytes is larger than 2048 bytes [-Wframe-larger-than=] > > Here, I'm reducing the stack size by marking as many local variables as > 'static const' as I can without changing the actual code. > > This is the first of three patches to improve the stack usage in this > driver. It would be good to have this backported to stabl kernels > to get all drivers in 'allmodconfig' below the 2048 byte limit so > we can turn on the frame warning again globally, but I realize that > the patch is larger than the normal limit for stable backports. > > The other two patches do not need to be backported. > > Acked-by: Arend van Spriel > Signed-off-by: Arnd Bergmann I'll queue this and the two following brcmsmac patches for 4.14. Also I'll add (only for this patch): Cc: -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v4 1/9] brcmsmac: make some local variables 'static const' to reduce stack size Date: Mon, 25 Sep 2017 07:33:50 +0300 Message-ID: <87h8vr75xt.fsf@kamboji.qca.qualcomm.com> References: <20170922212930.620249-1-arnd@arndb.de> <20170922212930.620249-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Mauro Carvalho Chehab , Jiri Pirko , "David S. Miller" , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Masahiro Yamada , Michal Marek , Andrew Morton , Kees Cook , Geert Uytterhoeven , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, To: Arnd Bergmann Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:52692 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753650AbdIYEeA (ORCPT ); Mon, 25 Sep 2017 00:34:00 -0400 In-Reply-To: <20170922212930.620249-2-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 22 Sep 2017 23:29:12 +0200") Sender: netdev-owner@vger.kernel.org List-ID: Arnd Bergmann writes: > With KASAN and a couple of other patches applied, this driver is one > of the few remaining ones that actually use more than 2048 bytes of > kernel stack: > > broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy_gainctrl': > broadcom/brcm80211/brcmsmac/phy/phy_n.c:16065:1: warning: the frame size of 3264 bytes is larger than 2048 bytes [-Wframe-larger-than=] > broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy': > broadcom/brcm80211/brcmsmac/phy/phy_n.c:17138:1: warning: the frame size of 2864 bytes is larger than 2048 bytes [-Wframe-larger-than=] > > Here, I'm reducing the stack size by marking as many local variables as > 'static const' as I can without changing the actual code. > > This is the first of three patches to improve the stack usage in this > driver. It would be good to have this backported to stabl kernels > to get all drivers in 'allmodconfig' below the 2048 byte limit so > we can turn on the frame warning again globally, but I realize that > the patch is larger than the normal limit for stable backports. > > The other two patches do not need to be backported. > > Acked-by: Arend van Spriel > Signed-off-by: Arnd Bergmann I'll queue this and the two following brcmsmac patches for 4.14. Also I'll add (only for this patch): Cc: -- Kalle Valo