From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:44460 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbdBHQY0 (ORCPT ); Wed, 8 Feb 2017 11:24:26 -0500 From: Kalle Valo To: David Miller Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-mips@linux-mips.org, linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, target-devel@vger.kernel.org, andrew@lunn.ch, anna.schumaker@netapp.com, derek.chickles@caviumnetworks.com, felix.manlunas@caviumnetworks.com, bfields@fieldses.org, jlayton@poochiereds.net, jirislaby@gmail.com, mcgrof@do-not-panic.com, madalin.bucur@nxp.com, UNGLinuxDriver@microchip.com, nab@linux-iscsi.org, mickflemm@gmail.com, nicolas.ferre@atmel.com, raghu.vatsavayi@caviumnetworks.com, ralf@linux-mips.org, satananda.burla@caviumnetworks.com, thomas.petazzoni@free-electrons.com, timur@codeaurora.org, trond.myklebust@primarydata.com, vivien.didelot@savoirfairelinux.com, woojung.huh@microchip.com Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include References: <20170207230305.18222-1-f.fainelli@gmail.com> <20170208.110626.346978547122180233.davem@davemloft.net> Date: Wed, 08 Feb 2017 18:11:59 +0200 In-Reply-To: <20170208.110626.346978547122180233.davem@davemloft.net> (David Miller's message of "Wed, 08 Feb 2017 11:06:26 -0500 (EST)") Message-ID: <87h944ll0w.fsf@kamboji.qca.qualcomm.com> (sfid-20170208_172438_599980_8D6EB25D) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: David Miller writes: > From: Florian Fainelli > Date: Tue, 7 Feb 2017 15:02:53 -0800 > >> I'm hoping this doesn't conflict with what's already in net-next... >>=20 >> David, this should probably go via your tree considering the diffstat. > > I think you need one more respin. Are you doing an allmodconfig build? > If not, for something like this it's a must: > > drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected =E2=80= =98)=E2=80=99 before =E2=80=98bool=E2=80=99 > module_param(disable_ap_sme, bool, 0444); > ^ > drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected =E2=80= =98)=E2=80=99 before string constant > MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME"); > ^ > Like like that file needs linux/module.h included. Johannes already fixed a similar (or same) problem in my tree: wil6210: include moduleparam.h https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.gi= t/commit/?id=3D949c2d0096753d518ef6e0bd8418c8086747196b I'm planning to send you a pull request tomorrow which contains that one. --=20 Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include Date: Wed, 08 Feb 2017 18:11:59 +0200 Message-ID: <87h944ll0w.fsf@kamboji.qca.qualcomm.com> References: <20170207230305.18222-1-f.fainelli@gmail.com> <20170208.110626.346978547122180233.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-mips@linux-mips.org, linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, target-devel@vger.kernel.org, andrew@lunn.ch, anna.schumaker@netapp.com, derek.chickles@caviumnetworks.com, felix.manlunas@caviumnetworks.com, bfields@fieldses.org, jlayton@poochiereds.net, jirislaby@gmail.com, mcgrof@do-not-panic.com, madalin.bucur@nxp.com, UNGLinuxDriver@microchip.com, nab@linux-iscsi.org, mickflemm@gmail.com, nicolas.ferre@atmel.com, raghu.vatsavayi@caviumnetworks.com, ralf@linux-mips.org, satananda.burla@caviumnetworks.com, thomas.petazzoni@free-electrons.com, timur@codeaurora.org, trond.myklebust@primarydata.com, vivien.didelot@savoirfairelinux.com, woojung.huh To: David Miller Return-path: In-Reply-To: <20170208.110626.346978547122180233.davem@davemloft.net> (David Miller's message of "Wed, 08 Feb 2017 11:06:26 -0500 (EST)") Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: List-Id: netdev.vger.kernel.org David Miller writes: > From: Florian Fainelli > Date: Tue, 7 Feb 2017 15:02:53 -0800 > >> I'm hoping this doesn't conflict with what's already in net-next... >> >> David, this should probably go via your tree considering the diffstat. > > I think you need one more respin. Are you doing an allmodconfig build? > If not, for something like this it's a must: > > drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’ > module_param(disable_ap_sme, bool, 0444); > ^ > drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant > MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME"); > ^ > Like like that file needs linux/module.h included. Johannes already fixed a similar (or same) problem in my tree: wil6210: include moduleparam.h https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b I'm planning to send you a pull request tomorrow which contains that one. -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 08 Feb 2017 17:12:41 +0100 (CET) Received: from smtp.codeaurora.org ([198.145.29.96]:49544 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23991359AbdBHQMdPwtho convert rfc822-to-8bit (ORCPT ); Wed, 8 Feb 2017 17:12:33 +0100 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 808E560A7F; Wed, 8 Feb 2017 16:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1486570351; bh=9+SoAxT2j2IpWuVIHYHQpMj0t1B6IIEWE/G+MdhaShY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ApZdnnasP1N/IE7D1fZl1fivfQqLKpWmrDO1/o9knwFU/om/YHgsPwN8r3Wio9G8T XCPcFAYwQ1VHMfmcfWgbu7hvzsDXxMXdYOYcz4N1TAyhbGbcXF9dp8ULvO3TyK67rL kiDyMu4FbJLx0sLHX+j9a23vs0r4ERIuZpzr9igg= Received: from potku.adurom.net (a88-115-187-87.elisa-laajakaista.fi [88.115.187.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id CDFFB60A0B; Wed, 8 Feb 2017 16:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1486570349; bh=9+SoAxT2j2IpWuVIHYHQpMj0t1B6IIEWE/G+MdhaShY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZQmmwDq/PXB5BhM4eNvZViz6UULQ8mZhH8mU3j1pYKQNrJRGRZtXupYxzo/DKjus+ hJRCJkbwacHJ4Wh4qHd9Eu1IepYD0F6Dys70VM9GJU0sfwuMySQfBL2+pf6SuC/gir /K/V8FA8qDw5Hwkbormwb74rOtSDufoy23gJcNWE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CDFFB60A0B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: David Miller Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-mips@linux-mips.org, linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, target-devel@vger.kernel.org, andrew@lunn.ch, anna.schumaker@netapp.com, derek.chickles@caviumnetworks.com, felix.manlunas@caviumnetworks.com, bfields@fieldses.org, jlayton@poochiereds.net, jirislaby@gmail.com, mcgrof@do-not-panic.com, madalin.bucur@nxp.com, UNGLinuxDriver@microchip.com, nab@linux-iscsi.org, mickflemm@gmail.com, nicolas.ferre@atmel.com, raghu.vatsavayi@caviumnetworks.com, ralf@linux-mips.org, satananda.burla@caviumnetworks.com, thomas.petazzoni@free-electrons.com, timur@codeaurora.org, trond.myklebust@primarydata.com, vivien.didelot@savoirfairelinux.com, woojung.huh@microchip.com Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include References: <20170207230305.18222-1-f.fainelli@gmail.com> <20170208.110626.346978547122180233.davem@davemloft.net> Date: Wed, 08 Feb 2017 18:11:59 +0200 In-Reply-To: <20170208.110626.346978547122180233.davem@davemloft.net> (David Miller's message of "Wed, 08 Feb 2017 11:06:26 -0500 (EST)") Message-ID: <87h944ll0w.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 56735 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: kvalo@codeaurora.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips David Miller writes: > From: Florian Fainelli > Date: Tue, 7 Feb 2017 15:02:53 -0800 > >> I'm hoping this doesn't conflict with what's already in net-next... >> >> David, this should probably go via your tree considering the diffstat. > > I think you need one more respin. Are you doing an allmodconfig build? > If not, for something like this it's a must: > > drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’ > module_param(disable_ap_sme, bool, 0444); > ^ > drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant > MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME"); > ^ > Like like that file needs linux/module.h included. Johannes already fixed a similar (or same) problem in my tree: wil6210: include moduleparam.h https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b I'm planning to send you a pull request tomorrow which contains that one. -- Kalle Valo