From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753313AbdBAROi (ORCPT ); Wed, 1 Feb 2017 12:14:38 -0500 Received: from foss.arm.com ([217.140.101.70]:39780 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753212AbdBAROg (ORCPT ); Wed, 1 Feb 2017 12:14:36 -0500 From: Punit Agrawal To: Will Deacon Cc: Mark Langsdorf , kvm@vger.kernel.org, Marc Zyngier , Jon Masters , timur@codeaurora.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Paolo Bonzini , Neil Leeder Subject: Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code References: <20170125155232.10277-1-cov@codeaurora.org> <20170125155232.10277-3-cov@codeaurora.org> <20170125193943.GW15850@cbox> <20170127135306.GK21144@arm.com> <87lgtprgi4.fsf@e105922-lin.cambridge.arm.com> <20170201170852.GI8177@arm.com> Date: Wed, 01 Feb 2017 17:14:34 +0000 In-Reply-To: <20170201170852.GI8177@arm.com> (Will Deacon's message of "Wed, 1 Feb 2017 17:08:52 +0000") Message-ID: <87h94drfyd.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Will Deacon writes: > On Wed, Feb 01, 2017 at 05:02:43PM +0000, Punit Agrawal wrote: >> Will Deacon writes: >> >> > On Wed, Jan 25, 2017 at 08:39:43PM +0100, Christoffer Dall wrote: >> >> On Wed, Jan 25, 2017 at 10:52:31AM -0500, Christopher Covington wrote: >> >> > Refactor the KVM code to use the __tlbi macros, which will allow an errata >> >> > workaround that repeats tlbi dsb sequences to only change one location. >> >> > This is not intended to change the generated assembly and comparing before >> >> > and after vmlinux objdump shows no functional changes. >> >> > >> >> > Signed-off-by: Christopher Covington >> >> >> >> Acked-by: Christoffer Dall >> > >> > Thanks, I'll queue this one via arm64. >> >> I just noticed this patch but there's been a similar patch from Mark >> that I've been carrying as part of the KVM TLB monitoring series[0]. >> >> [0] http://www.mail-archive.com/kvmarm@lists.cs.columbia.edu/msg09359.html > > Well I've already queued the one from Christopher. It's weird that Mark's > version appears to miss the local VMID case (but it does have the > flush_icache_all I wanted :). > > Anyway, I'm not reverting anything, so you'll need to rebase when this > lot lands in mainline. Sure. I'll drop the patch the next time around. The patch is unrelated to that series and should've gone in when we introduced the __tlbi() macro but got left out somehow. > > Will > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Punit Agrawal Subject: Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code Date: Wed, 01 Feb 2017 17:14:34 +0000 Message-ID: <87h94drfyd.fsf@e105922-lin.cambridge.arm.com> References: <20170125155232.10277-1-cov@codeaurora.org> <20170125155232.10277-3-cov@codeaurora.org> <20170125193943.GW15850@cbox> <20170127135306.GK21144@arm.com> <87lgtprgi4.fsf@e105922-lin.cambridge.arm.com> <20170201170852.GI8177@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Mark Langsdorf , kvm@vger.kernel.org, Marc Zyngier , Jon Masters , timur@codeaurora.org, linux-kernel@vger.kernel.org, Neil Leeder , Catalin Marinas , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org To: Will Deacon Return-path: In-Reply-To: <20170201170852.GI8177@arm.com> (Will Deacon's message of "Wed, 1 Feb 2017 17:08:52 +0000") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org Will Deacon writes: > On Wed, Feb 01, 2017 at 05:02:43PM +0000, Punit Agrawal wrote: >> Will Deacon writes: >> >> > On Wed, Jan 25, 2017 at 08:39:43PM +0100, Christoffer Dall wrote: >> >> On Wed, Jan 25, 2017 at 10:52:31AM -0500, Christopher Covington wrote: >> >> > Refactor the KVM code to use the __tlbi macros, which will allow an errata >> >> > workaround that repeats tlbi dsb sequences to only change one location. >> >> > This is not intended to change the generated assembly and comparing before >> >> > and after vmlinux objdump shows no functional changes. >> >> > >> >> > Signed-off-by: Christopher Covington >> >> >> >> Acked-by: Christoffer Dall >> > >> > Thanks, I'll queue this one via arm64. >> >> I just noticed this patch but there's been a similar patch from Mark >> that I've been carrying as part of the KVM TLB monitoring series[0]. >> >> [0] http://www.mail-archive.com/kvmarm@lists.cs.columbia.edu/msg09359.html > > Well I've already queued the one from Christopher. It's weird that Mark's > version appears to miss the local VMID case (but it does have the > flush_icache_all I wanted :). > > Anyway, I'm not reverting anything, so you'll need to rebase when this > lot lands in mainline. Sure. I'll drop the patch the next time around. The patch is unrelated to that series and should've gone in when we introduced the __tlbi() macro but got left out somehow. > > Will > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 From: punit.agrawal@arm.com (Punit Agrawal) Date: Wed, 01 Feb 2017 17:14:34 +0000 Subject: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code In-Reply-To: <20170201170852.GI8177@arm.com> (Will Deacon's message of "Wed, 1 Feb 2017 17:08:52 +0000") References: <20170125155232.10277-1-cov@codeaurora.org> <20170125155232.10277-3-cov@codeaurora.org> <20170125193943.GW15850@cbox> <20170127135306.GK21144@arm.com> <87lgtprgi4.fsf@e105922-lin.cambridge.arm.com> <20170201170852.GI8177@arm.com> Message-ID: <87h94drfyd.fsf@e105922-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Will Deacon writes: > On Wed, Feb 01, 2017 at 05:02:43PM +0000, Punit Agrawal wrote: >> Will Deacon writes: >> >> > On Wed, Jan 25, 2017 at 08:39:43PM +0100, Christoffer Dall wrote: >> >> On Wed, Jan 25, 2017 at 10:52:31AM -0500, Christopher Covington wrote: >> >> > Refactor the KVM code to use the __tlbi macros, which will allow an errata >> >> > workaround that repeats tlbi dsb sequences to only change one location. >> >> > This is not intended to change the generated assembly and comparing before >> >> > and after vmlinux objdump shows no functional changes. >> >> > >> >> > Signed-off-by: Christopher Covington >> >> >> >> Acked-by: Christoffer Dall >> > >> > Thanks, I'll queue this one via arm64. >> >> I just noticed this patch but there's been a similar patch from Mark >> that I've been carrying as part of the KVM TLB monitoring series[0]. >> >> [0] http://www.mail-archive.com/kvmarm at lists.cs.columbia.edu/msg09359.html > > Well I've already queued the one from Christopher. It's weird that Mark's > version appears to miss the local VMID case (but it does have the > flush_icache_all I wanted :). > > Anyway, I'm not reverting anything, so you'll need to rebase when this > lot lands in mainline. Sure. I'll drop the patch the next time around. The patch is unrelated to that series and should've gone in when we introduced the __tlbi() macro but got left out somehow. > > Will > _______________________________________________ > kvmarm mailing list > kvmarm at lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm