From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1brkd4-0003qV-4u
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 07:44:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1brkcz-00084O-0Z
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 07:44:53 -0400
Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:35381)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1brkcy-00084F-PS
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 07:44:48 -0400
Received: by mail-wm0-x22c.google.com with SMTP id f193so223889036wmg.0
	for <qemu-devel@nongnu.org>; Wed, 05 Oct 2016 04:44:48 -0700 (PDT)
References: <1474048017-26696-1-git-send-email-rth@twiddle.net>
	<1474048017-26696-17-git-send-email-rth@twiddle.net>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1474048017-26696-17-git-send-email-rth@twiddle.net>
Date: Wed, 05 Oct 2016 12:44:45 +0100
Message-ID: <87h98rrpea.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v4 16/35] tcg: Emit barriers with
 parallel_cpus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org


Richard Henderson <rth@twiddle.net> writes:

> Signed-off-by: Richard Henderson <rth@twiddle.net>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>


> ---
>  tcg/tcg-op.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c
> index cdd61d6..bb2bfee 100644
> --- a/tcg/tcg-op.c
> +++ b/tcg/tcg-op.c
> @@ -150,17 +150,7 @@ void tcg_gen_op6(TCGContext *ctx, TCGOpcode opc, TCGArg a1, TCGArg a2,
>
>  void tcg_gen_mb(TCGBar mb_type)
>  {
> -    bool emit_barriers = true;
> -
> -#ifndef CONFIG_USER_ONLY
> -    /* TODO: When MTTCG is available for system mode, we will check
> -     * the following condition and enable emit_barriers
> -     * (qemu_tcg_mttcg_enabled() && smp_cpus > 1)
> -     */
> -    emit_barriers = false;
> -#endif
> -
> -    if (emit_barriers) {
> +    if (parallel_cpus) {
>          tcg_gen_op1(&tcg_ctx, INDEX_op_mb, mb_type);
>      }
>  }


--
Alex Bennée