From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53898)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bX81p-0007Cx-NT
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 10:29:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bX81m-0005C7-7u
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 10:29:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41708)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bX81m-0005BU-2i
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 10:29:10 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 6BCD0BAF3
	for <qemu-devel@nongnu.org>; Tue,  9 Aug 2016 14:29:09 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <20160808141439.16908-1-marcandre.lureau@redhat.com>
	<20160808141439.16908-13-marcandre.lureau@redhat.com>
	<877fbqglj6.fsf@dusky.pond.sub.org>
	<393082343.564767.1470747025500.JavaMail.zimbra@redhat.com>
Date: Tue, 09 Aug 2016 16:29:07 +0200
In-Reply-To: <393082343.564767.1470747025500.JavaMail.zimbra@redhat.com>
	(=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Tue, 9 Aug 2016
	08:50:25 -0400 (EDT)")
Message-ID: <87h9audnik.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Cc: marcandre lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org

Marc-Andr=C3=A9 Lureau <mlureau@redhat.com> writes:

> Hi
>
> ----- Original Message -----
>> marcandre.lureau@redhat.com writes:
>>=20
>> > From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>> >
>> > Replace the old manual dispatch and validation code by the generic one
>> > provided by qapi common code.
>> >
>> > Note that it is now possible to call the following commands that used =
to
>> > be disabled by compile-time conditionals:
>> > - dump-skeys
>> > - query-spice
>> > - rtc-reset-reinjection
>> > - query-gic-capabilities
>> >
>> > Their fallback functions return an appropriate "feature disabled" erro=
r.
>> >
>> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>>=20
>> Means query-qmp-schema no longer shows whether these commands are
>> supported, doesn't it?
>>=20
>> Eric, could this create difficulties for libvirt or other introspection
>> users?
>
> Thinking a bit about this, I guess it would be fairly straightforward
> to have a new key "c-conditional" : "#ifdef CONFIG_SPICE" that would
> prepend it in C generated files, with a corresponding "#endif". Would
> that be acceptable?

Not exactly pretty, but the only alternative I can think of right now
would be conditional qapi generation, i.e. something like

{ 'if': 'CONFIG_SPICE'
  'then': { 'command': 'query-spice', 'returns': 'SpiceInfo' } }

More general, but *much* more work.  Let's not go there now.

The value of key 'c-conditional' must be a preprocessing directive that
pairs with #endif.  Hmm.

Could make it an expression instead, and call the key just
'conditional'.  If given, wrap the code generated for the QAPI
definition in

    #if <value of conditional>
    ...
    #endif

Feels cleaner, but to avoid -Wundef warnings, we'd have to say
'defined(CONFIG_SPICE)'.

Thoughts?