From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50006)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bWkIB-0008On-HQ
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 09:08:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bWkI7-0004dl-AX
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 09:08:30 -0400
Received: from roura.ac.upc.edu ([147.83.33.10]:54063 helo=roura.ac.upc.es)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bWkI6-0004dh-U3
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 09:08:27 -0400
From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>
References: <147041636348.2523.2954972609232949598.stgit@fimbulvetr.bsc.es>
	<147041637969.2523.4570342042982870131.stgit@fimbulvetr.bsc.es>
	<57A4CB91.6050405@redhat.com>
Date: Mon, 08 Aug 2016 15:08:06 +0200
In-Reply-To: <57A4CB91.6050405@redhat.com> (Eric Blake's message of "Fri, 5
	Aug 2016 11:23:29 -0600")
Message-ID: <87h9av8l3d.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side
 proxy to "guest_hypertrace" event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Riku Voipio <riku.voipio@iki.fi>, Stefan Hajnoczi <stefanha@redhat.com>

Eric Blake writes:

> On 08/05/2016 10:59 AM, Llu=C3=ADs Vilanova wrote:
>> QEMU detects when the guest uses 'mmap' on hypertrace's control channel
>> file, and then uses 'mprotect' to detect accesses to it, which are used
>> to trigger traceing event "guest_hypertrace".

> s/traceing/tracing/

> I'll probably leave the technical review to others, though

Thanks.


>> +++ b/bsd-user/mmap.c
>> @@ -21,6 +21,7 @@
>> #include "qemu.h"
>> #include "qemu-common.h"
>> #include "bsd-mman.h"
>> +#include "hypertrace/user.h"
>>=20
>> //#define DEBUG_MMAP
>>=20
>> @@ -407,6 +408,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len,=
 int prot,
>> }
>> }
>> the_end1:
>> +    hypertrace_guest_mmap(fd, (void *)g2h(start));

> Why is the cast to void* needed?

That's unnecessary, my bad.


Thanks,
  Lluis