From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLSJ4-0004t7-Df for qemu-devel@nongnu.org; Tue, 19 Jan 2016 04:10:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLSJ1-0001X4-5c for qemu-devel@nongnu.org; Tue, 19 Jan 2016 04:10:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLSJ1-0001W9-07 for qemu-devel@nongnu.org; Tue, 19 Jan 2016 04:10:27 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 97F8DC0BF2A4 for ; Tue, 19 Jan 2016 09:10:26 +0000 (UTC) From: Markus Armbruster References: <1450717720-9627-1-git-send-email-eblake@redhat.com> Date: Tue, 19 Jan 2016 10:10:24 +0100 In-Reply-To: <1450717720-9627-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Mon, 21 Dec 2015 10:08:05 -0700") Message-ID: <87h9iahr3z.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v8 00/35] qapi visitor cleanups (post-introspection cleanups subset E) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Eduardo Habkost Eric Blake writes: > Based on qemu.git master. Pending prerequisites: > + Not a strong dependency, but for qapi-tests to consistently pass, > I needed a race fixed: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01827.html > > Also available as a tag at this location: > git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv8e > > and will soon be part of my branch with the rest of the v5 series, at: > http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi > > v8 notes: > Four new patches (13-16/35), plus rebasing on top of them, so that > the code base now consistently passes a 'v, name' pair anywhere a > visitor needs a name, rather than putting other arguments in between > the pair. I got to have fun with Coccinelle :) Also fix a bug in my > changes to visit_next_list() (v7 29/31), so that 'make check' and > qemu-iotests now pass at all points in the series. > > The parameter ordering changes have the potential to be a rebase > magnet, so I'm hoping this series can go in relatively soon after > Markus returns from break. > > I made good on my threat in v7 of writing a qapi-to-JSON output > visitor, but that will remain a separate series based on this one > (the only posting of that series so far now needs rebasing: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01760.html) > > 001/35:[----] [--] 'qobject: Document more shortcomings in our number han= dling' > 002/35:[----] [--] 'qapi: Avoid use of misnamed DO_UPCAST()' > 003/35:[----] [--] 'qapi: Drop dead dealloc visitor variable' > 004/35:[----] [--] 'hmp: Improve use of qapi visitor' > 005/35:[----] [--] 'vl: Improve use of qapi visitor' > 006/35:[----] [--] 'balloon: Improve use of qapi visitor' > 007/35:[----] [--] 'qapi: Improve generated event use of qapi visitor' > 008/35:[----] [--] 'qapi: Track all failures between visit_start/stop' > 009/35:[----] [--] 'qapi: Prefer type_int64 over type_int in visitors' > 010/35:[----] [--] 'qapi: Make all visitors supply uint64 callbacks' > 011/35:[----] [--] 'qapi: Consolidate visitor small integer callbacks' > 012/35:[----] [--] 'qapi: Don't cast Enum* to int*' > 013/35:[down] 'qom: Use typedef for Visitor' Applies cleanly until here. > 014/35:[down] 'qapi: Swap visit_* arguments for consistent 'name' placeme= nt' Doesn't apply. You can either spin v9 addressing Marc-Andr=C3=A9's review, or you can reba= se v8 without changes somewhere I can pull, so I can review it properly. [...]