From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933163AbbDODdS (ORCPT ); Tue, 14 Apr 2015 23:33:18 -0400 Received: from ozlabs.org ([103.22.144.67]:40321 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932313AbbDODcs (ORCPT ); Tue, 14 Apr 2015 23:32:48 -0400 From: Rusty Russell To: Cornelia Huck , "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-api@vger.kernel.org Subject: Re: [PATCH] virtio_balloon: drop virtio_balloon_stat_modern In-Reply-To: <20150414121327.4caacfba.cornelia.huck@de.ibm.com> References: <1429005625-23181-1-git-send-email-mst@redhat.com> <20150414121327.4caacfba.cornelia.huck@de.ibm.com> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 15 Apr 2015 12:45:03 +0930 Message-ID: <87h9sirsjs.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cornelia Huck writes: > On Tue, 14 Apr 2015 12:01:13 +0200 > "Michael S. Tsirkin" wrote: > >> Looks like we are better off sticking with the misaligned stat struct, >> to reduce the amount of virtio 1 specific code in balloon. So let's do >> it. >> >> Add a detailed comment to reduce the chance people copy this bad example. >> >> This also fixes a bug on BE architectures: tag should use >> cpu_to_le16, not cpu_to_le32. >> >> Acked-by: Cornelia Huck >> Signed-off-by: Michael S. Tsirkin >> --- >> >> Just reposting so it's easier to apply. >> Feel free to squash into previous patch if you think it's >> neater. > > +1 for squashing from me. My A-b would also apply to the squashed patch. Yes, I already squashed. TBH, I would have squashed the next patches into one too, that simply got rid of the virtio_device_is_legacy_only() function and all callers. Thanks, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH] virtio_balloon: drop virtio_balloon_stat_modern Date: Wed, 15 Apr 2015 12:45:03 +0930 Message-ID: <87h9sirsjs.fsf@rustcorp.com.au> References: <1429005625-23181-1-git-send-email-mst@redhat.com> <20150414121327.4caacfba.cornelia.huck@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150414121327.4caacfba.cornelia.huck@de.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Cornelia Huck , "Michael S. Tsirkin" Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: linux-api@vger.kernel.org Cornelia Huck writes: > On Tue, 14 Apr 2015 12:01:13 +0200 > "Michael S. Tsirkin" wrote: > >> Looks like we are better off sticking with the misaligned stat struct, >> to reduce the amount of virtio 1 specific code in balloon. So let's do >> it. >> >> Add a detailed comment to reduce the chance people copy this bad example. >> >> This also fixes a bug on BE architectures: tag should use >> cpu_to_le16, not cpu_to_le32. >> >> Acked-by: Cornelia Huck >> Signed-off-by: Michael S. Tsirkin >> --- >> >> Just reposting so it's easier to apply. >> Feel free to squash into previous patch if you think it's >> neater. > > +1 for squashing from me. My A-b would also apply to the squashed patch. Yes, I already squashed. TBH, I would have squashed the next patches into one too, that simply got rid of the virtio_device_is_legacy_only() function and all callers. Thanks, Rusty.