From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW0gl-0002oE-1g for qemu-devel@nongnu.org; Fri, 04 Apr 2014 05:45:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW0ge-0008R9-RH for qemu-devel@nongnu.org; Fri, 04 Apr 2014 05:45:30 -0400 From: Juan Quintela In-Reply-To: <1396543778-22307-25-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Thu, 3 Apr 2014 19:52:28 +0300") References: <1396543778-22307-1-git-send-email-mst@redhat.com> <1396543778-22307-25-git-send-email-mst@redhat.com> Date: Fri, 04 Apr 2014 11:45:18 +0200 Message-ID: <87ha698m35.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 24/24] savevm: Ignore minimum_version_id_old if there is no load_state_old Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , Lei Li , qemu-devel@nongnu.org, Michael Tokarev , mdroth@linux.vnet.ibm.com, qemu-stable@nongnu.org, Alexey Kardashevskiy , Amit Shah , dgilbert@redhat.com "Michael S. Tsirkin" wrote: > From: Peter Maydell > > At the moment we require vmstate definitions to set minimum_version_id_old > to the same value as minimum_version_id if they do not provide a > load_state_old handler. Since the load_state_old functionality is > required only for a handful of devices that need to retain migration > compatibility with a pre-vmstate implementation, this means the bulk > of devices have pointless boilerplate. Relax the definition so that > minimum_version_id_old is ignored if there is no load_state_old handler. > > Note that under the old scheme we would segfault if the vmstate > specified a minimum_version_id_old that was less than minimum_version_id > but did not provide a load_state_old function, and the incoming state > specified a version number between minimum_version_id_old and > minimum_version_id. Under the new scheme this will just result in > our failing the migration. > > Signed-off-by: Peter Maydell > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin Reviewed-by: Juan Quintela Applied