All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <tr@thomasrast.ch>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: <git@vger.kernel.org>, Bo Yang <struggleyb.nku@gmail.com>
Subject: Re: [PATCH 5/6] blame-options.txt: place each -L option variation on its own line
Date: Thu, 18 Jul 2013 13:56:55 +0200	[thread overview]
Message-ID: <87hafs84jc.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <1374096332-7891-6-git-send-email-sunshine@sunshineco.com> (Eric Sunshine's message of "Wed, 17 Jul 2013 17:25:31 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> Standard practice in Git documentation is for each variation of an
> option (such as: -p / --porcelain) to be placed on its own line in the
> OPTIONS table. The -L option does not follow suit. It cuddles
> "-L <start>,<end>" and "-L :<regex>", separated by a comma. This is
> inconsistent and potentially confusing since the comma separating them
> is typeset the same as the comma in "<start>,<end>". Fix this by placing
> each variation on its own line.

Ok, but why not fix them all in one go?

Edited to remove the false positives:

$ git grep -n '^.*,.*::$' Documentation/*.txt
Documentation/blame-options.txt:12:-L <start>,<end>, -L :<regex>::
Documentation/config.txt:1252:gitcvs.dbuser, gitcvs.dbpass::
Documentation/config.txt:1513:http.lowSpeedLimit, http.lowSpeedTime::
Documentation/git-add.txt:90:-e, \--edit::
Documentation/git-check-attr.txt:22:-a, --all::
Documentation/git-check-ignore.txt:26:-q, --quiet::
Documentation/git-check-ignore.txt:30:-v, --verbose::
Documentation/git-check-ignore.txt:42:-n, --non-matching::
Documentation/git-log.txt:65:-L <start>,<end>:<file>, -L :<regex>:<file>::
Documentation/git-log.txt:156:git log -L '/int main/',/^}/:main.c::
Documentation/git-p4.txt:171:--verbose, -v::
Documentation/git-p4.txt:282:--dry-run, -n::

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2013-07-18 12:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 21:25 [PATCH 0/6] fix blame -L regression; add tests Eric Sunshine
2013-07-17 21:25 ` [PATCH 1/6] line-range: fix "blame -L X,-N" regression Eric Sunshine
2013-07-17 21:25 ` [PATCH 2/6] t8001/t8002 (blame): modernize style Eric Sunshine
2013-07-17 21:25 ` [PATCH 3/6] t8001/t8002 (blame): add blame -L tests Eric Sunshine
2013-07-17 21:25 ` [PATCH 4/6] t8001/t8002 (blame): add blame -L :funcname tests Eric Sunshine
2013-07-17 21:25 ` [PATCH 5/6] blame-options.txt: place each -L option variation on its own line Eric Sunshine
2013-07-18 11:56   ` Thomas Rast [this message]
2013-07-18 17:51     ` Junio C Hamano
2013-07-22 10:38       ` Thomas Rast
2013-07-22 17:25         ` Junio C Hamano
2013-07-17 21:25 ` [PATCH 6/6] blame-options.txt: explain that -L <start> and <end> are optional Eric Sunshine
2013-07-18 12:04 ` [PATCH 0/6] fix blame -L regression; add tests Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hafs84jc.fsf@linux-k42r.v.cablecom.net \
    --to=tr@thomasrast.ch \
    --cc=git@vger.kernel.org \
    --cc=struggleyb.nku@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.