All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 01/37] sh-pfc: r8a7740: Add SCIF pin groups and functions
Date: Tue, 23 Apr 2013 01:25:22 +0000	[thread overview]
Message-ID: <87haiy598g.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <1366671618-8796-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>


Hi Laurent

Thank you for your hard work

> +/* - SCIFA0 ----------------------------------------------------------------- */
> +static const unsigned int scifa0_data_pins[] = {
> +	/* RXD, TXD */
> +	197, 198,
> +};

I guess these numbers mean PORT197, PORT198,
but,this kind of "direct numbering" is difficult to read/understand
for non-expert people IMO.
But, it is easy to understand that it is "GPIO PORT something" if there is ...

#define SH_GPIO_PORT(nr)	(nr)

This is just my opinion, and I'm not sure other people.

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2013-04-23  1:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 22:59 [PATCH 01/37] sh-pfc: r8a7740: Add SCIF pin groups and functions Laurent Pinchart
2013-04-23  1:25 ` Kuninori Morimoto [this message]
2013-04-23 10:51 ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haiy598g.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.