All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] connman: remove iptables as a fixed dependency
       [not found] <CAEXMXLRZ5d3RaipEw3ftPfmqLCyYb0CFTyR+oz34COWBVkKfZA@mail.gmail.com>
@ 2021-12-15 12:00 ` Nuno Gonçalves
  2021-12-16 18:24   ` Arnout Vandecappelle
  2022-01-15 15:24   ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Nuno Gonçalves @ 2021-12-15 12:00 UTC (permalink / raw)
  To: buildroot

connman might depend on iptables or nftables, and those dependencies
are already selected later in this file as required.

Signed-off-by: Nuno Goncalves <nunojpg@gmail.com>
---
 package/connman/connman.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/connman/connman.mk b/package/connman/connman.mk
index 0355426e92..e5e596c973 100644
--- a/package/connman/connman.mk
+++ b/package/connman/connman.mk
@@ -7,7 +7,7 @@
 CONNMAN_VERSION = 1.40
 CONNMAN_SOURCE = connman-$(CONNMAN_VERSION).tar.xz
 CONNMAN_SITE = $(BR2_KERNEL_MIRROR)/linux/network/connman
-CONNMAN_DEPENDENCIES = libglib2 dbus iptables
+CONNMAN_DEPENDENCIES = libglib2 dbus
 CONNMAN_INSTALL_STAGING = YES
 CONNMAN_LICENSE = GPL-2.0
 CONNMAN_LICENSE_FILES = COPYING
--
2.32.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] connman: remove iptables as a fixed dependency
  2021-12-15 12:00 ` [Buildroot] [PATCH] connman: remove iptables as a fixed dependency Nuno Gonçalves
@ 2021-12-16 18:24   ` Arnout Vandecappelle
  2022-01-15 15:24   ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2021-12-16 18:24 UTC (permalink / raw)
  To: Nuno Gonçalves, buildroot

  Hi Nuno,

On 15/12/2021 13:00, Nuno Gonçalves wrote:
> connman might depend on iptables or nftables, and those dependencies
> are already selected later in this file as required.
> 
> Signed-off-by: Nuno Goncalves <nunojpg@gmail.com>

  The subject line should start with "package/connman:". I also the following to 
the commit message and applied to master, thanks.

Config.in already only selects iptables if BR2_PACKAGE_CONNMAN_IPTABLES.

  Regards,
  Arnout

> ---
>   package/connman/connman.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> index 0355426e92..e5e596c973 100644
> --- a/package/connman/connman.mk
> +++ b/package/connman/connman.mk
> @@ -7,7 +7,7 @@
>   CONNMAN_VERSION = 1.40
>   CONNMAN_SOURCE = connman-$(CONNMAN_VERSION).tar.xz
>   CONNMAN_SITE = $(BR2_KERNEL_MIRROR)/linux/network/connman
> -CONNMAN_DEPENDENCIES = libglib2 dbus iptables
> +CONNMAN_DEPENDENCIES = libglib2 dbus
>   CONNMAN_INSTALL_STAGING = YES
>   CONNMAN_LICENSE = GPL-2.0
>   CONNMAN_LICENSE_FILES = COPYING
> --
> 2.32.0
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] connman: remove iptables as a fixed dependency
  2021-12-15 12:00 ` [Buildroot] [PATCH] connman: remove iptables as a fixed dependency Nuno Gonçalves
  2021-12-16 18:24   ` Arnout Vandecappelle
@ 2022-01-15 15:24   ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-01-15 15:24 UTC (permalink / raw)
  To: Nuno Gonçalves; +Cc: buildroot

>>>>> "Nuno" == Nuno Gonçalves <nunojpg@gmail.com> writes:

 > connman might depend on iptables or nftables, and those dependencies
 > are already selected later in this file as required.

 > Signed-off-by: Nuno Goncalves <nunojpg@gmail.com>

Committed to 2021.02.x and 2021.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-15 15:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAEXMXLRZ5d3RaipEw3ftPfmqLCyYb0CFTyR+oz34COWBVkKfZA@mail.gmail.com>
2021-12-15 12:00 ` [Buildroot] [PATCH] connman: remove iptables as a fixed dependency Nuno Gonçalves
2021-12-16 18:24   ` Arnout Vandecappelle
2022-01-15 15:24   ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.