All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Balaji Prakash J <bjagadee@codeaurora.org>,
	Rob Herring <robh@kernel.org>,
	Kathiravan T <kathirav@codeaurora.org>,
	Jack Pham <jackp@codeaurora.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Robert Marko <robert.marko@sartura.hr>,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] usb: dwc3: reference clock period configuration
Date: Tue, 31 Aug 2021 10:27:45 +0300	[thread overview]
Message-ID: <87ilzmcbqa.fsf@kernel.org> (raw)
In-Reply-To: <9f399bdf1ff752e31ab7497e3d5ce19bbb3ff247.1630389452.git.baruch@tkos.co.il>


Baruch Siach <baruch@tkos.co.il> writes:

> From: Balaji Prakash J <bjagadee@codeaurora.org>
>
> Set reference clock period when it differs from dwc3 default hardware
> set.
>
> We could calculate clock period based on reference clock frequency. But
> this information is not always available. This is the case of PCI bus
> attached USB host. For that reason we use a custom property.
>
> Tested (USB2 only) on IPQ6010 SoC based board with 24 MHz reference
> clock while hardware default is 19.2 MHz.
>
> Nacked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Balaji Prakash J <bjagadee@codeaurora.org>
> [ baruch: rewrite commit message; drop GFLADJ code; remove 'quirk-' from
>   property name; mention tested hardware ]
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Acked-by: Felipe Balbi <balbi@kernel.org>


-- 
balbi

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Balaji Prakash J <bjagadee@codeaurora.org>,
	Rob Herring <robh@kernel.org>,
	Kathiravan T <kathirav@codeaurora.org>,
	Jack Pham <jackp@codeaurora.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Robert Marko <robert.marko@sartura.hr>,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] usb: dwc3: reference clock period configuration
Date: Tue, 31 Aug 2021 10:27:45 +0300	[thread overview]
Message-ID: <87ilzmcbqa.fsf@kernel.org> (raw)
In-Reply-To: <9f399bdf1ff752e31ab7497e3d5ce19bbb3ff247.1630389452.git.baruch@tkos.co.il>


Baruch Siach <baruch@tkos.co.il> writes:

> From: Balaji Prakash J <bjagadee@codeaurora.org>
>
> Set reference clock period when it differs from dwc3 default hardware
> set.
>
> We could calculate clock period based on reference clock frequency. But
> this information is not always available. This is the case of PCI bus
> attached USB host. For that reason we use a custom property.
>
> Tested (USB2 only) on IPQ6010 SoC based board with 24 MHz reference
> clock while hardware default is 19.2 MHz.
>
> Nacked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Balaji Prakash J <bjagadee@codeaurora.org>
> [ baruch: rewrite commit message; drop GFLADJ code; remove 'quirk-' from
>   property name; mention tested hardware ]
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Acked-by: Felipe Balbi <balbi@kernel.org>


-- 
balbi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-31  7:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  5:57 [PATCH v3 1/4] dt-bindings: usb: dwc3: add reference clock period Baruch Siach
2021-08-31  5:57 ` Baruch Siach
2021-08-31  5:57 ` [PATCH v3 2/4] usb: dwc3: reference clock period configuration Baruch Siach
2021-08-31  5:57   ` Baruch Siach
2021-08-31  7:27   ` Felipe Balbi [this message]
2021-08-31  7:27     ` Felipe Balbi
2021-08-31  5:57 ` [PATCH v3 3/4] dt-bindings: usb: qcom,dwc3: add binding for IPQ6018 Baruch Siach
2021-08-31  5:57   ` Baruch Siach
2021-08-31  5:57 ` [PATCH v3 4/4] arm64: qcom: ipq6018: add usb3 DT description Baruch Siach
2021-08-31  5:57   ` Baruch Siach
2021-08-31  7:27 ` [PATCH v3 1/4] dt-bindings: usb: dwc3: add reference clock period Felipe Balbi
2021-08-31  7:27   ` Felipe Balbi
2021-09-01  1:37 ` Rob Herring
2021-09-01  1:37   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilzmcbqa.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=agross@kernel.org \
    --cc=baruch@tkos.co.il \
    --cc=bjagadee@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jackp@codeaurora.org \
    --cc=kathirav@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.