From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33C216E0D6 for ; Fri, 25 Jun 2021 22:26:19 +0000 (UTC) Date: Fri, 25 Jun 2021 15:26:16 -0700 Message-ID: <87im218ttj.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210617191256.577244-49-jason@jlekstrand.net> References: <20210617191256.577244-1-jason@jlekstrand.net> <20210617191256.577244-49-jason@jlekstrand.net> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 48/79] tests/i915/gem_exec_balancer: Stop cloning engines List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Jason Ekstrand Cc: igt-dev@lists.freedesktop.org List-ID: On Thu, 17 Jun 2021 12:12:55 -0700, Jason Ekstrand wrote: > > We have the list of engines and bonding info in each case. Using clone > is just being lazy for no good reason. Clone was a valid API so can't call it lazy. Probably just say use the engine list and bonding info instead of clone ;) > @@ -2359,7 +2361,7 @@ static void waits(int i915, int timeout) > if (count > 1) { > uint32_t ctx = load_balancer_create(i915, ci, count); > > - __waits(i915, timeout, ctx, count); > + __waits(i915, timeout, ci, count); > > gem_context_destroy(i915, ctx); > } Should delete the ctx create/destroy too but it's done in a later patch so it's fine. Reviewed-by: Ashutosh Dixit _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev