From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6A5EC48BDF for ; Fri, 18 Jun 2021 09:42:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 524F261369 for ; Fri, 18 Jun 2021 09:42:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 524F261369 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luB1G-0003PG-7L for qemu-devel@archiver.kernel.org; Fri, 18 Jun 2021 05:42:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luB0K-0002k9-RM for qemu-devel@nongnu.org; Fri, 18 Jun 2021 05:41:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luB0I-0007zB-1Z for qemu-devel@nongnu.org; Fri, 18 Jun 2021 05:41:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624009293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DHBA1dzXZ8lfVInq6nzgwecQ77kxnstNVeVWKjq6+WY=; b=NmG67nzsgw6pLr0XXsC6L4/8WV2YsN9dSTxFlLGwfSftVKdmTxPLrPqSBO9/t5DlVbouHC fu2yxvbK9fRpxNJ4Lalo6conGufJIi8DMvS6AZbbnJUNt+ekJH/eUcJR9upcQzaeHGSSzh dXYm4au78YsiSUna3hl+pYyBGeiAbdA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-534-7FCLN-zZPmm-xTz1ZuZctA-1; Fri, 18 Jun 2021 05:41:31 -0400 X-MC-Unique: 7FCLN-zZPmm-xTz1ZuZctA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B41F9F92B; Fri, 18 Jun 2021 09:41:30 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-104.ams2.redhat.com [10.36.112.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1DA646A056; Fri, 18 Jun 2021 09:41:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A9413113865F; Fri, 18 Jun 2021 11:41:28 +0200 (CEST) From: Markus Armbruster To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH v5 3/9] qapi: make gen_if/gen_endif take a simple string References: <20210608120723.2268181-1-marcandre.lureau@redhat.com> <20210608120723.2268181-4-marcandre.lureau@redhat.com> <87zgvszkas.fsf@dusky.pond.sub.org> Date: Fri, 18 Jun 2021 11:41:28 +0200 In-Reply-To: (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Wed, 16 Jun 2021 14:44:02 +0400") Message-ID: <87im2btsqf.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.197, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Marc-Andr=C3=A9 Lureau writes: > Hi > > On Mon, Jun 14, 2021 at 4:48 PM Markus Armbruster wro= te: > >> marcandre.lureau@redhat.com writes: >> >> > From: Marc-Andr=C3=A9 Lureau >> > >> > Instead of building prepocessor conditions from a list of string, use >> > the result generated from QAPISchemaIfCond.cgen(). >> >> I understand why you're doing this, but only because I know where you're >> headed. By itself, it is not an improvement: you move C generation out >> of common.py into schema.py. You need to explain why that's useful. >> >> > What about? > > In the following commits, QAPISchemaIfCond is going to hold an internal > tree structure. Moving cgen() there allows to abstract away the condition > representation. Yes, that's better. [...]