From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0FBAC47095 for ; Wed, 9 Jun 2021 09:10:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 688D5610E6 for ; Wed, 9 Jun 2021 09:10:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 688D5610E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lquEV-00059K-FX for qemu-devel@archiver.kernel.org; Wed, 09 Jun 2021 05:10:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lquDk-0004HS-LU for qemu-devel@nongnu.org; Wed, 09 Jun 2021 05:09:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lquDe-0003YM-N9 for qemu-devel@nongnu.org; Wed, 09 Jun 2021 05:09:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623229789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c0RculTvri4dIgZtcuphdUqtMXBsaD24i0DifznD99A=; b=dt2WMYlu9fXLYRx7YIlpzHdMcaeEeZ2dFoPCQbfDtRWXDXt5/g8f7Z14tcN+kYZhn32nye YFgdVoQlLgue49b2X1mrdiVVhWWGPKrgh1OITyN2qYJF/STkfpYSuhVoEgFx0EYxR3YLXq 7w9frEHTXM2C1qbV3XVuMD/8mnoSXC8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-280-e7p56yWrNH63mlk-7wcuvg-1; Wed, 09 Jun 2021 05:09:48 -0400 X-MC-Unique: e7p56yWrNH63mlk-7wcuvg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5394718D6A2C; Wed, 9 Jun 2021 09:09:46 +0000 (UTC) Received: from localhost (ovpn-113-134.ams2.redhat.com [10.36.113.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1FAE60CC9; Wed, 9 Jun 2021 09:09:42 +0000 (UTC) From: Cornelia Huck To: David Hildenbrand , qemu-devel@nongnu.org Subject: Re: [PATCH v4 00/26] s390x/tcg: Implement Vector enhancements facility and switch to z14 In-Reply-To: <20210608092337.12221-1-david@redhat.com> Organization: Red Hat GmbH References: <20210608092337.12221-1-david@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Wed, 09 Jun 2021 11:09:40 +0200 Message-ID: <87im2n1k17.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.197, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Richard Henderson , Laurent Vivier , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 08 2021, David Hildenbrand wrote: > @Conny, I think this should be good to go. > > > This series adds support for the "Vector enhancements facility" and bumps > the qemu CPU model to a stripped-down z14. > > I tested most vector FP instructions by generating random instructions > and vectors, comparing the result with results on actual hardware. I did > not test instructions/instruction variants with (partial) undeterministic > behavior and exception handling. > > Linux' also seems to boot/work fine with it. Howeever, while testing this > series I noticed that Linux checks for the wrong facility bit - see [1]. > I tested by temporarily faking availability of the "wrong" facility bit. > > [1] https://lkml.kernel.org/r/20210503121244.25232-1-david@redhat.com > > v3 -> v4: > - "s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)" > -- Move "const bool ..." into respective blocks > - "linux-user: elf: s390x: Prepare for Vector enhancements facility" > -- Add all currently defined Linux HWCAP. > > v2 -> v3: > - "s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling" > -- Keep proper signal handling in the VECTOR variants > - "s390x/tcg: Simplify vop64_2() handling" > -- uint64_t se -> bool se > - "s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)" > -- Drop special cases when both values are infinity > -- Simplify cases when both values are zero > -- Simplify dcmask handling > -- uint64_t se -> bool se > - "linux-user: elf: Prepare for Vector enhancements facility" > -- Added to properly indicate the new elf capability > > v1 -> v2: > - Too much changed to spell it out explicitly. Mostly addressed feedback > from Richard, a couple of bugfixes found while testing, and some > simplifications/cleanups. > - Rebased on top of Richard's softfloat rework > > Cc: qemu-s390x@nongnu.org > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Thomas Huth > Cc: Richard Henderson > Cc: Laurent Vivier > > > David Hildenbrand (26): > s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling > s390x/tcg: Fix instruction name for VECTOR FP LOAD > (LENGTHENED|ROUNDED) > s390x/tcg: Simplify vop64_3() handling > s390x/tcg: Simplify vop64_2() handling > s390x/tcg: Simplify vfc64() handling > s390x/tcg: Simplify vftci64() handling > s390x/tcg: Simplify vfma64() handling > s390x/tcg: Simplify vfll32() handling > s390x/tcg: Simplify vflr64() handling > s390x/tcg: Simplify wfc64() handling > s390x/tcg: Implement VECTOR BIT PERMUTE > s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL > s390x/tcg: Implement 32/128 bit for VECTOR FP > (ADD|DIVIDE|MULTIPLY|SUBTRACT) > s390x/tcg: Implement 32/128 bit for VECTOR (LOAD FP INTEGER|FP SQUARE > ROOT) > s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE * > s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE (AND SIGNAL) > SCALAR > s390x/tcg: Implement 64 bit for VECTOR FP LOAD LENGTHENED > s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED > s390x/tcg: Implement 32/128 bit for VECTOR FP PERFORM SIGN OPERATION > s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS > IMMEDIATE > s390x/tcg: Implement 32/128 bit for VECTOR FP MULTIPLY AND > (ADD|SUBTRACT) > s390x/tcg: Implement VECTOR FP NEGATIVE MULTIPLY AND (ADD|SUBTRACT) > s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM) > linux-user: elf: s390x: Prepare for Vector enhancements facility > s390x/tcg: We support Vector enhancements facility > s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2 > > hw/s390x/s390-virtio-ccw.c | 3 + > include/elf.h | 7 + > linux-user/elfload.c | 1 + > target/s390x/cpu_models.c | 4 +- > target/s390x/fpu_helper.c | 41 +- > target/s390x/gen-features.c | 14 +- > target/s390x/helper.h | 70 +- > target/s390x/insn-data.def | 16 +- > target/s390x/internal.h | 9 + > target/s390x/translate_vx.c.inc | 633 ++++++++++++++---- > target/s390x/vec_fpu_helper.c | 1079 ++++++++++++++++++++++--------- > target/s390x/vec_helper.c | 22 + > 12 files changed, 1428 insertions(+), 471 deletions(-) Thanks, applied.