From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21F4BC2B9F7 for ; Mon, 24 May 2021 14:16:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3ED26108E for ; Mon, 24 May 2021 14:16:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232944AbhEXOSE (ORCPT ); Mon, 24 May 2021 10:18:04 -0400 Received: from foss.arm.com ([217.140.110.172]:42508 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232929AbhEXORy (ORCPT ); Mon, 24 May 2021 10:17:54 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61598139F; Mon, 24 May 2021 07:16:26 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5ED4B3F719; Mon, 24 May 2021 07:16:24 -0700 (PDT) From: Valentin Schneider To: Srikar Dronamraju , Ingo Molnar , Peter Zijlstra Cc: LKML , Mel Gorman , Rik van Riel , Srikar Dronamraju , Thomas Gleixner , Vincent Guittot , Dietmar Eggemann , linuxppc-dev@lists.ozlabs.org, Nathan Lynch , Michael Ellerman , Scott Cheloha , Gautham R Shenoy , Geetika Moolchandani Subject: Re: [PATCH 2/3] powerpc/numa: Populate distance map correctly In-Reply-To: <20210520154427.1041031-3-srikar@linux.vnet.ibm.com> References: <20210520154427.1041031-1-srikar@linux.vnet.ibm.com> <20210520154427.1041031-3-srikar@linux.vnet.ibm.com> Date: Mon, 24 May 2021 15:16:22 +0100 Message-ID: <87im386wuh.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/21 21:14, Srikar Dronamraju wrote: > +int arch_populate_distance_map(unsigned long *distance_map) > +{ > + int i; > + int distance = LOCAL_DISTANCE; > + > + bitmap_set(distance_map, distance, 1); > + > + if (!form1_affinity) { > + bitmap_set(distance_map, REMOTE_DISTANCE, 1); > + return 0; > + } > + > + for (i = 0; i < distance_ref_points_depth; i++) { > + distance *= 2; > + bitmap_set(distance_map, distance, 1); Do you have guarantees your distance values will always be in the form of LOCAL_DISTANCE * 2^i because that certainly isn't true for x86/arm64. > + } > + return 0; > +} > + > /* > * Returns nid in the range [0..nr_node_ids], or -1 if no useful NUMA > * info is found. > -- > 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 179F1C04FF3 for ; Mon, 24 May 2021 14:16:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5A8060FE5 for ; Mon, 24 May 2021 14:16:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5A8060FE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FpfRF2WKXz3c1p for ; Tue, 25 May 2021 00:16:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=valentin.schneider@arm.com; receiver=) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4FpfQh3NHwz30GS for ; Tue, 25 May 2021 00:16:27 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61598139F; Mon, 24 May 2021 07:16:26 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5ED4B3F719; Mon, 24 May 2021 07:16:24 -0700 (PDT) From: Valentin Schneider To: Srikar Dronamraju , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH 2/3] powerpc/numa: Populate distance map correctly In-Reply-To: <20210520154427.1041031-3-srikar@linux.vnet.ibm.com> References: <20210520154427.1041031-1-srikar@linux.vnet.ibm.com> <20210520154427.1041031-3-srikar@linux.vnet.ibm.com> Date: Mon, 24 May 2021 15:16:22 +0100 Message-ID: <87im386wuh.mognet@arm.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathan Lynch , Gautham R Shenoy , Vincent Guittot , Srikar Dronamraju , Rik van Riel , linuxppc-dev@lists.ozlabs.org, Scott Cheloha , Geetika Moolchandani , LKML , Thomas Gleixner , Mel Gorman , Dietmar Eggemann Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 20/05/21 21:14, Srikar Dronamraju wrote: > +int arch_populate_distance_map(unsigned long *distance_map) > +{ > + int i; > + int distance = LOCAL_DISTANCE; > + > + bitmap_set(distance_map, distance, 1); > + > + if (!form1_affinity) { > + bitmap_set(distance_map, REMOTE_DISTANCE, 1); > + return 0; > + } > + > + for (i = 0; i < distance_ref_points_depth; i++) { > + distance *= 2; > + bitmap_set(distance_map, distance, 1); Do you have guarantees your distance values will always be in the form of LOCAL_DISTANCE * 2^i because that certainly isn't true for x86/arm64. > + } > + return 0; > +} > + > /* > * Returns nid in the range [0..nr_node_ids], or -1 if no useful NUMA > * info is found. > -- > 2.27.0