From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF111C433E0 for ; Sun, 21 Feb 2021 15:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4AD164E4B for ; Sun, 21 Feb 2021 15:00:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229985AbhBUPAQ (ORCPT ); Sun, 21 Feb 2021 10:00:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:56642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229685AbhBUPAO (ORCPT ); Sun, 21 Feb 2021 10:00:14 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0BD6064EB4; Sun, 21 Feb 2021 14:59:33 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lDqCn-00FBf2-Rj; Sun, 21 Feb 2021 14:59:30 +0000 Date: Sun, 21 Feb 2021 14:59:14 +0000 Message-ID: <87im6l1n7h.wl-maz@kernel.org> From: Marc Zyngier To: Hector Martin Cc: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource In-Reply-To: <28128b77-87b4-3595-59fa-44600c5bdbc7@marcan.st> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-21-marcan@marcan.st> <20210215185135.onivzktfscv5myh2@kozik-lap> <20274436-7275-9734-5a07-d6da46b45c5f@marcan.st> <20210220191323.ugmzrtkvcxyqqolj@kozik-lap> <5a4b3d7095d1ec4be97ec154109632dc@kernel.org> <28128b77-87b4-3595-59fa-44600c5bdbc7@marcan.st> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: marcan@marcan.st, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, robh@kernel.org, arnd@kernel.org, olof@lixom.net, mark.kettenis@xs4all.nl, tony@atomide.com, mohamed.mediouni@caramail.com, stan@corellium.com, graf@amazon.com, will@kernel.org, linus.walleij@linaro.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Feb 2021 14:38:16 +0000, Hector Martin wrote: > > On 21/02/2021 04.17, Marc Zyngier wrote: > > On 2021-02-20 19:13, Krzysztof Kozlowski wrote: > >> On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: > >>> On 16/02/2021 03.51, Krzysztof Kozlowski wrote: > >>>>> Also fix a bug checking the return value, which should use IS_ERR(). > >>>> > >>>> No, no, no. We never, never combine fixing bugs with some rework. > >>>> However devm_ioremap() returns NULL so where is the error? > >>> > >>> Sorry, this was a commit message mistake. The code is correct and so > >>> is the > >>> patch: just the NULL check is correct for the previous variant and > >>> IS_ERR is > >>> correct for devm_ioremap_resource. I confused myself while writing the > >>> commit message after the fact. > >>> > >>>> Did you test your patches on existing platforms? If not, please mark all > >>>> of them as RFT on next submission, so Greg does not pick them too fast. > >>> > >>> I unfortunately don't have any Exynos devices where I could test the > >>> code (I > >>> have a couple but no serial connections, and I have no idea if mailine > >>> would > >>> run on them). I'll mark v3 as RFT. > >> > >> If you have one of Odroid boards with Exynos, then you can nicely test > >> Exynos. Others - depends, on board. > >> Anyway I can test them for you. I just want to be sure that Greg waits > >> for this testing. > > > > Worse case, QEMU has some Exynos4210 emulation that is usable. > > That's a good point; better than nothing, certainly. > > Does anyone have a known good example of booting an exynos kernel > under qemu? I tried building a plain 5.11 arm exynos_defconfig and > booting it, but without much luck: > > $ qemu-system-arm -kernel arch/arm/boot/zImage -append > "console=ttySAC0,115200n8 debug" -dtb > arch/arm/boot/dts/exynos4210-universal_c210.dtb -nographic -serial > mon:stdio -M smdkc210 -smp 2 Here's what I've been using last time I had to muck with the 4210 stuff: qemu-system-arm \ -kernel arch/arm/boot/zImage -M smdkc210 \ -append "console=ttySAC0,115200n8 earlycon=smh root=/dev/mmcblk0p2 rootwait" \ -nographic -semihosting -smp 2 \ -dtb arch/arm/boot/dts/exynos4210-smdkv310.dtb \ -drive if=sd,driver=null-co -drive if=sd,driver=null-co \ -drive if=sd,file=../vminstall/bullseye32/MsiKFRxxujYIkiKT.img,format=raw where the last line points to a standard Debian image created separately. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5C9C433E0 for ; Sun, 21 Feb 2021 15:01:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0074564EDE for ; Sun, 21 Feb 2021 15:01:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0074564EDE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7Gx1lTGkTKJ8G81kdHGkKOHp2gNMm/k2lYp/yAeQe4s=; b=Dp/rh29knekTtH+20dCNI/Fu9 Am272XyL6ND+wrXwJcbwixZ/RVK/aWyh/4blxR4jAH7BD7xqG4hWQxAgmDAgzVaxDBYatCT83opGx SuAvG0zBCv20qA26Nw+kyvNnJF0tsxZqLxlVc4SZGUAp+YUrezl8DPYztEH17an3pBDZNhy7lgSl2 NYMCzp2oehEiDKBk3+ceG1x4cXSiTFsyj7xo9Uin73mnhF3lCF63LhGWxdBVqEFknlPzEkJPvDr9j 2cCIdHbl2jrfJ7vlkDgtl3wH9dhHkAHDl3ICDTj3d7WxFR7SjVUTO5fNp8sMeRRvynvUqYcL9hlRE +lEu8Pjzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDqCu-0005HR-Lv; Sun, 21 Feb 2021 14:59:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDqCs-0005H6-63 for linux-arm-kernel@lists.infradead.org; Sun, 21 Feb 2021 14:59:35 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0BD6064EB4; Sun, 21 Feb 2021 14:59:33 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lDqCn-00FBf2-Rj; Sun, 21 Feb 2021 14:59:30 +0000 Date: Sun, 21 Feb 2021 14:59:14 +0000 Message-ID: <87im6l1n7h.wl-maz@kernel.org> From: Marc Zyngier To: Hector Martin Subject: Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource In-Reply-To: <28128b77-87b4-3595-59fa-44600c5bdbc7@marcan.st> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-21-marcan@marcan.st> <20210215185135.onivzktfscv5myh2@kozik-lap> <20274436-7275-9734-5a07-d6da46b45c5f@marcan.st> <20210220191323.ugmzrtkvcxyqqolj@kozik-lap> <5a4b3d7095d1ec4be97ec154109632dc@kernel.org> <28128b77-87b4-3595-59fa-44600c5bdbc7@marcan.st> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: marcan@marcan.st, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, robh@kernel.org, arnd@kernel.org, olof@lixom.net, mark.kettenis@xs4all.nl, tony@atomide.com, mohamed.mediouni@caramail.com, stan@corellium.com, graf@amazon.com, will@kernel.org, linus.walleij@linaro.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210221_095934_393197_768EE2CA X-CRM114-Status: GOOD ( 29.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Arnd Bergmann , Tony Lindgren , Linus Walleij , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 21 Feb 2021 14:38:16 +0000, Hector Martin wrote: > > On 21/02/2021 04.17, Marc Zyngier wrote: > > On 2021-02-20 19:13, Krzysztof Kozlowski wrote: > >> On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: > >>> On 16/02/2021 03.51, Krzysztof Kozlowski wrote: > >>>>> Also fix a bug checking the return value, which should use IS_ERR(). > >>>> > >>>> No, no, no. We never, never combine fixing bugs with some rework. > >>>> However devm_ioremap() returns NULL so where is the error? > >>> > >>> Sorry, this was a commit message mistake. The code is correct and so > >>> is the > >>> patch: just the NULL check is correct for the previous variant and > >>> IS_ERR is > >>> correct for devm_ioremap_resource. I confused myself while writing the > >>> commit message after the fact. > >>> > >>>> Did you test your patches on existing platforms? If not, please mark all > >>>> of them as RFT on next submission, so Greg does not pick them too fast. > >>> > >>> I unfortunately don't have any Exynos devices where I could test the > >>> code (I > >>> have a couple but no serial connections, and I have no idea if mailine > >>> would > >>> run on them). I'll mark v3 as RFT. > >> > >> If you have one of Odroid boards with Exynos, then you can nicely test > >> Exynos. Others - depends, on board. > >> Anyway I can test them for you. I just want to be sure that Greg waits > >> for this testing. > > > > Worse case, QEMU has some Exynos4210 emulation that is usable. > > That's a good point; better than nothing, certainly. > > Does anyone have a known good example of booting an exynos kernel > under qemu? I tried building a plain 5.11 arm exynos_defconfig and > booting it, but without much luck: > > $ qemu-system-arm -kernel arch/arm/boot/zImage -append > "console=ttySAC0,115200n8 debug" -dtb > arch/arm/boot/dts/exynos4210-universal_c210.dtb -nographic -serial > mon:stdio -M smdkc210 -smp 2 Here's what I've been using last time I had to muck with the 4210 stuff: qemu-system-arm \ -kernel arch/arm/boot/zImage -M smdkc210 \ -append "console=ttySAC0,115200n8 earlycon=smh root=/dev/mmcblk0p2 rootwait" \ -nographic -semihosting -smp 2 \ -dtb arch/arm/boot/dts/exynos4210-smdkv310.dtb \ -drive if=sd,driver=null-co -drive if=sd,driver=null-co \ -drive if=sd,file=../vminstall/bullseye32/MsiKFRxxujYIkiKT.img,format=raw where the last line points to a standard Debian image created separately. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel