From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D071C433FE for ; Thu, 10 Dec 2020 20:38:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CDDD23E24 for ; Thu, 10 Dec 2020 20:38:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393822AbgLJUhl (ORCPT ); Thu, 10 Dec 2020 15:37:41 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:52264 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404659AbgLJUhe (ORCPT ); Thu, 10 Dec 2020 15:37:34 -0500 Received: from localhost (unknown [IPv6:2804:14c:132:242d::1000]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: krisman) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id E23071F45C51; Thu, 10 Dec 2020 20:36:51 +0000 (GMT) From: Gabriel Krisman Bertazi To: Arnaud Ferraris Cc: linux-ext4@vger.kernel.org, drosen@google.com, ebiggers@kernel.org, tytso@mit.edu Subject: Re: [PATCH RESEND v2 05/12] e2fsck: add new problem for casefolded name check Organization: Collabora References: <20201210150353.91843-1-arnaud.ferraris@collabora.com> <20201210150353.91843-6-arnaud.ferraris@collabora.com> Date: Thu, 10 Dec 2020 17:36:46 -0300 In-Reply-To: <20201210150353.91843-6-arnaud.ferraris@collabora.com> (Arnaud Ferraris's message of "Thu, 10 Dec 2020 16:03:46 +0100") Message-ID: <87im992yap.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Arnaud Ferraris writes: > --- > Changes in v2: > - added in this version > > e2fsck/problem.c | 5 +++++ > e2fsck/problem.h | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/e2fsck/problem.c b/e2fsck/problem.c > index e79c853b..2b596303 100644 > --- a/e2fsck/problem.c > +++ b/e2fsck/problem.c > @@ -1805,6 +1805,11 @@ static struct e2fsck_problem problem_table[] = { > N_("Encrypted @E references @i %Di, which has a different encryption policy.\n"), > PROMPT_CLEAR, 0, 0, 0, 0 }, > > + /* Casefolded directory entry has illegal characters in its name */ > + { PR_2_BAD_CASEFOLDED_NAME, > + N_("@E has illegal UTF-8 characters in its name.\n"), > + PROMPT_FIX, 0, 0, 0, 0 }, > + > /* Pass 3 errors */ > > /* Pass 3: Checking directory connectivity */ > diff --git a/e2fsck/problem.h b/e2fsck/problem.h > index 4185e517..a8806fd4 100644 > --- a/e2fsck/problem.h > +++ b/e2fsck/problem.h > @@ -1028,6 +1028,9 @@ struct problem_context { > /* Encrypted directory contains file with different encryption policy */ > #define PR_2_INCONSISTENT_ENCRYPTION_POLICY 0x020052 > > +/* Casefolded directory entry has illegal characters in its name */ > +#define PR_2_BAD_CASEFOLDED_NAME 0x0200053 This should be 0x020053 (yours has an extra 0) > + > /* > * Pass 3 errors > */ -- Gabriel Krisman Bertazi