From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00, BUG6152_INVALID_DATE_TZ_ABSURD,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,INVALID_DATE_TZ_ABSURD,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76337C4727F for ; Wed, 30 Sep 2020 10:24:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25876207C3 for ; Wed, 30 Sep 2020 10:24:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="pV+Nhret"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ihpvh3Xd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729086AbgI3KYx (ORCPT ); Wed, 30 Sep 2020 06:24:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728235AbgI3KYw (ORCPT ); Wed, 30 Sep 2020 06:24:52 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A07EFC061755 for ; Wed, 30 Sep 2020 03:24:52 -0700 (PDT) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1601461491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gKnkuO8al5P4LoWzeLQveTlvMQw18ZxOIr1o+kYlmtc=; b=pV+NhretosWvlPSntcohS9342jI6wQ3lO+LllvYpf7nbV5fI4Ujd+nsHkOSsw3IQhEe3Dd WI2zC4ZsxHGHYRbxgM10clyTpHkqm0F5ZOKbWsdjfBwnhqiQ1/KtNRM6Xroe6/Qo/Tk8L5 IQ40+2b5uY0bYBlPOwr0FKGjDFmySR0UvSNo3dprVBIO/e9o0SjeXa0mSUbp5rojWzxfwV QODCVIv7fsvtzbwveVo7+4LD+MVVZzeD6n0ygpNttA1kbkSdktYRhW26CJgHKn8AMHXUbz Iyy3s6TafEG0UCF9xxAXBW3L3QLv17D8Y0kBqYEhg3CH+7kld48R/NgSnl4Chg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1601461491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gKnkuO8al5P4LoWzeLQveTlvMQw18ZxOIr1o+kYlmtc=; b=ihpvh3Xd80g8wEwiOtdPxyf/5yP+VA9PCAkAKSgbWPX3AQ2kO5gaTDbIL1DQa9pymaLW72 CQj4K9pubrMNvcDQ== To: Sergey Senozhatsky Cc: Petr Mladek , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Greg Kroah-Hartman , Thomas Gleixner , Marek Szyprowski , linux-kernel@vger.kernel.org Subject: Re: [PATCH next v2 1/2] printk: avoid and/or handle record truncation In-Reply-To: <20200930094316.GB987@jagdpanzerIV.localdomain> References: <20200930090134.8723-1-john.ogness@linutronix.de> <20200930090134.8723-2-john.ogness@linutronix.de> <20200930094316.GB987@jagdpanzerIV.localdomain> Date: Wed, 30 Sep 2020 12:30:50 +0206 Message-ID: <87imbv1s0d.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-30, Sergey Senozhatsky wrote: > On (20/09/30 11:07), John Ogness wrote: >> bool prb_reserve_in_last(struct prb_reserved_entry *e, struct printk_ringbuffer *rb, >> - struct printk_record *r, u32 caller_id); >> + struct printk_record *r, u32 caller_id, unsigned int max_size); > > Isn't `max_size' always LOG_LINE_MAX? Yes. But I still think it makes sense that it is an argument of the function. It is quite an important setting and hard-coding it within the ringbuffer code might lead to hidden problems later. John Ogness