From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C5CC4727C for ; Tue, 29 Sep 2020 15:27:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D97D20773 for ; Tue, 29 Sep 2020 15:27:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Top+F9cZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D97D20773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNHXQ-0006ni-HV for qemu-devel@archiver.kernel.org; Tue, 29 Sep 2020 11:27:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNHWT-0006Nh-Db for qemu-devel@nongnu.org; Tue, 29 Sep 2020 11:26:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kNHWQ-0001FS-RD for qemu-devel@nongnu.org; Tue, 29 Sep 2020 11:26:32 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601393188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H9l/r8aHWshoEU456JQomRcp4iNj8f0KoAkHAPxjjLA=; b=Top+F9cZdpiO/lfOVaHn5+3/wRHS471fjr1bK9vS3LUWTJjjw9sGE6rkFq5rVZpCqpCKAb sy2gvBo8LJv17e5CtShrkcu58Re6L8d0+MM+oqgA43Klm6Yf4ZLi/9morL3NVVR8JiSneX rNn7oL+0B7MTH10QWbROFj9y9bAFXOI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-nSJcNDhPPme5-7c674F9dQ-1; Tue, 29 Sep 2020 11:26:26 -0400 X-MC-Unique: nSJcNDhPPme5-7c674F9dQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 61C23801F9A; Tue, 29 Sep 2020 15:26:25 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-101.ams2.redhat.com [10.36.112.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3080D60C13; Tue, 29 Sep 2020 15:26:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A9A97113864A; Tue, 29 Sep 2020 17:26:23 +0200 (CEST) From: Markus Armbruster To: Peter Maydell Subject: Re: [PATCH v6 00/21] Convert QAPI doc comments to generate rST instead of texinfo References: <20200925162316.21205-1-peter.maydell@linaro.org> <160106193961.10465.12078546060105198824@66eaa9a8a123> <87h7rif3x3.fsf@dusky.pond.sub.org> Date: Tue, 29 Sep 2020 17:26:23 +0200 In-Reply-To: (Peter Maydell's message of "Mon, 28 Sep 2020 14:05:46 +0100") Message-ID: <87imbwob8g.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/29 02:22:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.687, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Peter Maydell writes: > On Mon, 28 Sep 2020 at 14:04, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > On Fri, 25 Sep 2020 at 20:25, wrote: >> > >> >> In file included from ../src/qapi/qapi-schema.json:78: >> >> ../src/qapi/migration.json:1747:1: unexpected de-indent (expected at least 13 spaces) >> > >> > This is yet another mis-indented line in a change to the QAPI >> > doc-comments (commit 4c437254b807). It hit master in the >> > latest migration pull after I'd sent out this patchseries >> > but before patchew got round to testing.. >> >> Obvious fixup for your PATCH 01: >> >> diff --git a/qapi/migration.json b/qapi/migration.json >> index 7d9342c064..7f5e6fd681 100644 >> --- a/qapi/migration.json >> +++ b/qapi/migration.json >> @@ -1744,9 +1744,9 @@ >> # Information about current dirty page rate of vm. >> # >> # @dirty-rate: @dirtyrate describing the dirty page rate of vm >> -# in units of MB/s. >> -# If this field returns '-1', it means querying has not >> -# yet started or completed. >> +# in units of MB/s. >> +# If this field returns '-1', it means querying has not >> +# yet started or completed. >> # >> # @status: status containing dirtyrate query status includes >> # 'unstarted' or 'measuring' or 'measured' >> >> Happy to fix it up in my tree. > > Yes, please. One more issue: /work/armbru/qemu/docs/../qapi/machine.json:1000: WARNING: Unexpected indentation. /work/armbru/qemu/docs/../qapi/machine.json:1000: WARNING: Block quote ends without a blank line; unexpected unindent. Line 1000 is at the beginning of a comment block. Suboptimal. After a bit of guessing, I arrived at this fix: diff --git a/qapi/machine.json b/qapi/machine.json index 7c9e69a9f5..756dacb06f 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -1001,9 +1001,11 @@ # # Request the balloon driver to change its balloon size. # -# @value: the target logical size of the VM in bytes +# @value: the target logical size of the VM in bytes. # We can deduce the size of the balloon using this formula: +# # logical_vm_size = vm_ram_size - balloon_size +# # From it we have: balloon_size = vm_ram_size - @value # # Returns: - Nothing on success Looks good?