From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF00C433DF for ; Mon, 6 Jul 2020 17:01:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66FDF205CB for ; Mon, 6 Jul 2020 17:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729679AbgGFRBM convert rfc822-to-8bit (ORCPT ); Mon, 6 Jul 2020 13:01:12 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:60400 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729384AbgGFRBL (ORCPT ); Mon, 6 Jul 2020 13:01:11 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsUUL-0005pc-ND; Mon, 06 Jul 2020 11:01:05 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jsUUJ-0005CJ-SN; Mon, 06 Jul 2020 11:01:05 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Lee Jones Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Sumit Garg , Daniel Thompson , Douglas Anderson , Petr Mladek , Yinghai Lu , Jason Wessel References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-26-lee.jones@linaro.org> Date: Mon, 06 Jul 2020 11:56:24 -0500 In-Reply-To: <20200706133341.476881-26-lee.jones@linaro.org> (Lee Jones's message of "Mon, 6 Jul 2020 14:33:34 +0100") Message-ID: <87imf0mvk7.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-XM-SPF: eid=1jsUUJ-0005CJ-SN;;;mid=<87imf0mvk7.fsf@x220.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18khkDaZc3axoG/t6YW4c9dVrDhOpL38K0= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lee Jones writes: > 'ret' hasn't been checked since the driver's inception in 2009. Minor quibble the inception was in 5c05917e7fe3 ("x86: usb debug port early console, v4") in July of 2008. Acked-by: "Eric W. Biederman" > Fixes the following W=1 kernel build warning(s): > > drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’: > drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > 915 | int chunk, ret; > | ^~~ > > Cc: Sumit Garg > Cc: Daniel Thompson > Cc: Douglas Anderson > Cc: Petr Mladek > Cc: "Eric W. Biederman" > Cc: Yinghai Lu > Cc: Jason Wessel > Signed-off-by: Lee Jones > --- > drivers/usb/early/ehci-dbgp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c > index 775cf70cfb3ed..b075dbfad730f 100644 > --- a/drivers/usb/early/ehci-dbgp.c > +++ b/drivers/usb/early/ehci-dbgp.c > @@ -912,7 +912,7 @@ int __init early_dbgp_init(char *s) > > static void early_dbgp_write(struct console *con, const char *str, u32 n) > { > - int chunk, ret; > + int chunk; > char buf[DBGP_MAX_PACKET]; > int use_cr = 0; > u32 cmd, ctrl; > @@ -951,8 +951,8 @@ static void early_dbgp_write(struct console *con, const char *str, u32 n) > buf[chunk] = *str; > } > if (chunk > 0) { > - ret = dbgp_bulk_write(USB_DEBUG_DEVNUM, > - dbgp_endpoint_out, buf, chunk); > + dbgp_bulk_write(USB_DEBUG_DEVNUM, > + dbgp_endpoint_out, buf, chunk); > } > } > if (unlikely(reset_run)) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8ACFC433E0 for ; Mon, 6 Jul 2020 17:02:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9955F206BE for ; Mon, 6 Jul 2020 17:02:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ov+mzRyP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9955F206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xmission.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:Message-ID:In-Reply-To:Date: References:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=639dtE2USLaUx6OnrNYsbtrW2oVYLuvZ9NipPzgbaZg=; b=Ov+mzRyPwMM8ue+4AI3dVNRHW nQ8l5TybWkO5vRRSCD5MaNbJcRPvpmx2SMZ8blJhtGLLbn+XCcSXvISXCJaLx3NgatbbAzm2wSi0C c8HLAy4E20IWDa1T7yumUMv6GNFiCidQ/zFekEl9OHQRb6NiFhXhPsxiidKEYVKxK9Yjg3nvKMn5e 8/kX9n5jpbYLWncDR/AQlcLW/uV+Rw9ogY19YG0ZYvQzM6/jZ+ptZ1Joaj3Q/g3r0CC7nzCwcxBeQ g1df84EqFbUQuSwGD0E+g2a0UMzjhzB3DxkE+Ft/X1j2gjfouZTMes2sgpKBapW0c204TkZiBVQ1E nVmkrBR+Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsUUV-0006CH-8Y; Mon, 06 Jul 2020 17:01:15 +0000 Received: from out02.mta.xmission.com ([166.70.13.232]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsUUS-0006Bf-Vd for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 17:01:13 +0000 Received: from in02.mta.xmission.com ([166.70.13.52]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsUUL-0005pc-ND; Mon, 06 Jul 2020 11:01:05 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jsUUJ-0005CJ-SN; Mon, 06 Jul 2020 11:01:05 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Lee Jones References: <20200706133341.476881-1-lee.jones@linaro.org> <20200706133341.476881-26-lee.jones@linaro.org> Date: Mon, 06 Jul 2020 11:56:24 -0500 In-Reply-To: <20200706133341.476881-26-lee.jones@linaro.org> (Lee Jones's message of "Mon, 6 Jul 2020 14:33:34 +0100") Message-ID: <87imf0mvk7.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-XM-SPF: eid=1jsUUJ-0005CJ-SN; ; ; mid=<87imf0mvk7.fsf@x220.int.ebiederm.org>; ; ; hst=in02.mta.xmission.com; ; ; ip=68.227.160.95; ; ; frm=ebiederm@xmission.com; ; ; spf=neutral X-XM-AID: U2FsdGVkX18khkDaZc3axoG/t6YW4c9dVrDhOpL38K0= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_130113_031397_E8222099 X-CRM114-Status: GOOD ( 16.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Daniel Thompson , Petr Mladek , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson , Yinghai Lu , Jason Wessel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4gd3JpdGVzOgoKPiAncmV0JyBoYXNuJ3Qg IGJlZW4gY2hlY2tlZCBzaW5jZSB0aGUgZHJpdmVyJ3MgaW5jZXB0aW9uIGluIDIwMDkuCgpNaW5v ciBxdWliYmxlIHRoZSBpbmNlcHRpb24gd2FzIGluIDVjMDU5MTdlN2ZlMyAoIng4NjogdXNiIGRl YnVnIHBvcnQKZWFybHkgY29uc29sZSwgdjQiKSBpbiBKdWx5IG9mIDIwMDguCgpBY2tlZC1ieTog IkVyaWMgVy4gQmllZGVybWFuIiA8ZWJpZWRlcm1AeG1pc3Npb24uY29tPgoKPiBGaXhlcyB0aGUg Zm9sbG93aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPgo+ICBkcml2ZXJzL3VzYi9l YXJseS9laGNpLWRiZ3AuYzogSW4gZnVuY3Rpb24g4oCYZWFybHlfZGJncF93cml0ZeKAmToKPiAg ZHJpdmVycy91c2IvZWFybHkvZWhjaS1kYmdwLmM6OTE1OjEzOiB3YXJuaW5nOiB2YXJpYWJsZSDi gJhyZXTigJkgc2V0IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPiAg OTE1IHwgaW50IGNodW5rLCByZXQ7Cj4gIHwgXn5+Cj4KPiBDYzogU3VtaXQgR2FyZyA8c3VtaXQu Z2FyZ0BsaW5hcm8ub3JnPgo+IENjOiBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9tcHNvbkBs aW5hcm8ub3JnPgo+IENjOiBEb3VnbGFzIEFuZGVyc29uIDxkaWFuZGVyc0BjaHJvbWl1bS5vcmc+ Cj4gQ2M6IFBldHIgTWxhZGVrIDxwbWxhZGVrQHN1c2UuY29tPgo+IENjOiAiRXJpYyBXLiBCaWVk ZXJtYW4iIDxlYmllZGVybUB4bWlzc2lvbi5jb20+Cj4gQ2M6IFlpbmdoYWkgTHUgPHlobHUua2Vy bmVsQGdtYWlsLmNvbT4KPiBDYzogSmFzb24gV2Vzc2VsIDxqYXNvbi53ZXNzZWxAd2luZHJpdmVy LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ IC0tLQo+ICBkcml2ZXJzL3VzYi9lYXJseS9laGNpLWRiZ3AuYyB8IDYgKysrLS0tCj4gIDEgZmls ZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy91c2IvZWFybHkvZWhjaS1kYmdwLmMgYi9kcml2ZXJzL3VzYi9lYXJseS9laGNp LWRiZ3AuYwo+IGluZGV4IDc3NWNmNzBjZmIzZWQuLmIwNzVkYmZhZDczMGYgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy91c2IvZWFybHkvZWhjaS1kYmdwLmMKPiArKysgYi9kcml2ZXJzL3VzYi9lYXJs eS9laGNpLWRiZ3AuYwo+IEBAIC05MTIsNyArOTEyLDcgQEAgaW50IF9faW5pdCBlYXJseV9kYmdw X2luaXQoY2hhciAqcykKPiAgCj4gIHN0YXRpYyB2b2lkIGVhcmx5X2RiZ3Bfd3JpdGUoc3RydWN0 IGNvbnNvbGUgKmNvbiwgY29uc3QgY2hhciAqc3RyLCB1MzIgbikKPiAgewo+IC0JaW50IGNodW5r LCByZXQ7Cj4gKwlpbnQgY2h1bms7Cj4gIAljaGFyIGJ1ZltEQkdQX01BWF9QQUNLRVRdOwo+ICAJ aW50IHVzZV9jciA9IDA7Cj4gIAl1MzIgY21kLCBjdHJsOwo+IEBAIC05NTEsOCArOTUxLDggQEAg c3RhdGljIHZvaWQgZWFybHlfZGJncF93cml0ZShzdHJ1Y3QgY29uc29sZSAqY29uLCBjb25zdCBj aGFyICpzdHIsIHUzMiBuKQo+ICAJCQlidWZbY2h1bmtdID0gKnN0cjsKPiAgCQl9Cj4gIAkJaWYg KGNodW5rID4gMCkgewo+IC0JCQlyZXQgPSBkYmdwX2J1bGtfd3JpdGUoVVNCX0RFQlVHX0RFVk5V TSwKPiAtCQkJCSAgICAgIGRiZ3BfZW5kcG9pbnRfb3V0LCBidWYsIGNodW5rKTsKPiArCQkJZGJn cF9idWxrX3dyaXRlKFVTQl9ERUJVR19ERVZOVU0sCj4gKwkJCQkJZGJncF9lbmRwb2ludF9vdXQs IGJ1ZiwgY2h1bmspOwo+ICAJCX0KPiAgCX0KPiAgCWlmICh1bmxpa2VseShyZXNldF9ydW4pKSB7 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg==