From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE637C433DF for ; Mon, 22 Jun 2020 23:55:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39E6920727 for ; Mon, 22 Jun 2020 23:55:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ex/LAvK4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39E6920727 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AE8DF170C; Tue, 23 Jun 2020 01:54:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AE8DF170C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1592870124; bh=Ujjdxzsq5gWcDR1/xFjDP5wC9+Ol1rdhOOFBPg49Kzc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ex/LAvK4SedWfnklHSWmpzCkPQ6uhFzRCGgoMxhJd85L7q221msgQK0l/ca6YAC9A +zMxPPTDBv72bg7EsukRcJfgbkBqprJJzWNOHkwPzXYtWeriap+SPSMAxs7SChFngQ zpDEscrHjq3Jo1gwXHXxeFzX/K62uN7tHZ0G0ODo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 38871F8015A; Tue, 23 Jun 2020 01:54:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 19A97F8015B; Tue, 23 Jun 2020 01:54:32 +0200 (CEST) Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by alsa1.perex.cz (Postfix) with ESMTP id 487C2F8010E for ; Tue, 23 Jun 2020 01:54:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 487C2F8010E Date: 23 Jun 2020 08:54:20 +0900 X-IronPort-AV: E=Sophos;i="5.75,268,1589209200"; d="scan'208";a="50109908" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie6.idc.renesas.com with ESMTP; 23 Jun 2020 08:54:20 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id C6901414FBF0; Tue, 23 Jun 2020 08:54:20 +0900 (JST) Message-ID: <87imfi3bdd.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Pierre-Louis Bossart Subject: Re: [PATCH 1/5] ASoC: soc-link: introduce exit() callback In-Reply-To: <20200622154241.29053-2-pierre-louis.bossart@linux.intel.com> References: <20200622154241.29053-1-pierre-louis.bossart@linux.intel.com> <20200622154241.29053-2-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Guennadi Liakhovetski , alsa-devel@alsa-project.org, tiwai@suse.de, Curtis Malainey , broonie@kernel.org, Andy Shevchenko X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Pierre-Louis > The exit() is invoked in soc_remove_pcm_runtime(), which is not > completely symmetric with the init() invoked in soc_init_pcm_runtime(). (snip) > @@ -945,6 +945,9 @@ void snd_soc_remove_pcm_runtime(struct snd_soc_card *card, > { > lockdep_assert_held(&client_mutex); > > + /* release machine specific resources */ > + snd_soc_link_exit(rtd); I can understand that 100% symmetric calling init()/exit() is difficult. So we can't help it this time. But if so, it is easy to notice that this .exit() is the one of non-symmetric if it has such comment. Thank you for your help !! Best regards --- Kuninori Morimoto