From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) Date: Fri, 10 Jan 2020 15:32:13 +0200 Message-ID: <87imljsahu.fsf@codeaurora.org> References: <20200108200528.4614-1-krzk@kernel.org> <20200108200528.4614-3-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20200108200528.4614-3-krzk@kernel.org> (Krzysztof Kozlowski's message of "Wed, 8 Jan 2020 21:05:21 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Krzysztof Kozlowski Cc: Rich Felker , Jiri Slaby , Geert Uytterhoeven , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , netdev@vger.kernel.org, Paul Mackerras , linux-arch@vger.kernel.org, Dave Jiang , Yoshinori Sato , Helge Deller , linux-sh@vger.kernel.org, Alexey Brodkin , Ben Skeggs , nouveau@lists.freedesktop.org, Dave Airlie , Matt Turner , linux-snps-arc@lists.infradead.org, Nick Kossifidis , Allen Hubbe , Arnd Bergmann List-Id: linux-arch.vger.kernel.org Krzysztof Kozlowski writes: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven > > --- > > Changes since v1: > 1. Add Geert's review. > --- > drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) No need to have "net: wireless: " in the title, this is enough. rtl818x: Constify ioreadX() iomem argument (as in generic implementation) I assume someone else will take this so here's my ack: Acked-by: Kalle Valo -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBBD7C282DD for ; Fri, 10 Jan 2020 13:42:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57E892077C for ; Fri, 10 Jan 2020 13:42:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="kDCpIyfM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57E892077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47vPLM2fQ8zDqbW for ; Sat, 11 Jan 2020 00:42:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=mg.codeaurora.org (client-ip=104.130.122.25; helo=mail25.static.mailgun.info; envelope-from=bounce+ee6c0f.be9e4a-linuxppc-dev=lists.ozlabs.org@mg.codeaurora.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.a=rsa-sha256 header.s=smtp header.b=kDCpIyfM; dkim-atps=neutral X-Greylist: delayed 307 seconds by postgrey-1.36 at bilbo; Sat, 11 Jan 2020 00:37:44 AEDT Received: from mail25.static.mailgun.info (mail25.static.mailgun.info [104.130.122.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with UTF8SMTPS id 47vPDm1HPCzDqbC for ; Sat, 11 Jan 2020 00:37:43 +1100 (AEDT) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1578663463; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=KvNC+ZtmcyAhVZ56ZMn6CaYYHAi0RWpQoUQ7isluNMU=; b=kDCpIyfMwIgPk2yWDIdbZt4pvX85utcEPAGNRwNyopiJmV2fU2aJDZvAD7nXhHQa677QQGo3 Wl5a48b6EKZ3ebVm2k6ehXGL0494ii72HFrl1UnFnhynNcEmBv/D6Zvwp4qisLJcwXlk4/ij 3gJJDrM8xnwiNaCAOoNfc7TxTLA= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI5ZmEyMiIsICJsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e187cee.7f0eb6fae8f0-smtp-out-n02; Fri, 10 Jan 2020 13:32:30 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B4BB8C447AE; Fri, 10 Jan 2020 13:32:28 +0000 (UTC) Received: from x230.qca.qualcomm.com (unknown [83.145.195.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1C016C43383; Fri, 10 Jan 2020 13:32:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1C016C43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Krzysztof Kozlowski Subject: Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) References: <20200108200528.4614-1-krzk@kernel.org> <20200108200528.4614-3-krzk@kernel.org> Date: Fri, 10 Jan 2020 15:32:13 +0200 In-Reply-To: <20200108200528.4614-3-krzk@kernel.org> (Krzysztof Kozlowski's message of "Wed, 8 Jan 2020 21:05:21 +0100") Message-ID: <87imljsahu.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , Geert Uytterhoeven , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , netdev@vger.kernel.org, Paul Mackerras , linux-arch@vger.kernel.org, Dave Jiang , Yoshinori Sato , Helge Deller , linux-sh@vger.kernel.org, Alexey Brodkin , Ben Skeggs , nouveau@lists.freedesktop.org, Dave Airlie , Matt Turner , linux-snps-arc@lists.infradead.org, Nick Kossifidis , Allen Hubbe , Arnd Bergmann , linux-alpha@vger.kernel.org, Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Richard Henderson , linux-parisc@vger.kernel.org, Vineet Gupta , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Daniel Vetter , Jon Mason , linux-ntb@googlegroups.com, linux-media@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Krzysztof Kozlowski writes: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven > > --- > > Changes since v1: > 1. Add Geert's review. > --- > drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) No need to have "net: wireless: " in the title, this is enough. rtl818x: Constify ioreadX() iomem argument (as in generic implementation) I assume someone else will take this so here's my ack: Acked-by: Kalle Valo -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5250C33CA2 for ; Sun, 12 Jan 2020 12:36:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B027214AF for ; Sun, 12 Jan 2020 12:36:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="QtBmriFX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B027214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A965B6E038; Sun, 12 Jan 2020 12:36:11 +0000 (UTC) Received: from mail25.static.mailgun.info (mail25.static.mailgun.info [104.130.122.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A8256EA15 for ; Fri, 10 Jan 2020 13:32:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1578663154; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=KvNC+ZtmcyAhVZ56ZMn6CaYYHAi0RWpQoUQ7isluNMU=; b=QtBmriFXdyg0uiLinXVE2p64k6Ju6zo6uqPnUFpZH/6hnaciHc7l7aHtlBvvVCfWezqnP7oq qZ7kd0VeEBk/zTP5QULSrvYnD7e23sdUDY1PhN6P8V9nKIsaOzLoJgjRv0NXXo6TC1uQxD5d upIG3Vp2KHybR8M6d9NlaTn83b4= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e187cee.7fec0b84d308-smtp-out-n01; Fri, 10 Jan 2020 13:32:30 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A45B3C447AD; Fri, 10 Jan 2020 13:32:28 +0000 (UTC) Received: from x230.qca.qualcomm.com (unknown [83.145.195.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1C016C43383; Fri, 10 Jan 2020 13:32:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1C016C43383 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Krzysztof Kozlowski Subject: Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) References: <20200108200528.4614-1-krzk@kernel.org> <20200108200528.4614-3-krzk@kernel.org> Date: Fri, 10 Jan 2020 15:32:13 +0200 In-Reply-To: <20200108200528.4614-3-krzk@kernel.org> (Krzysztof Kozlowski's message of "Wed, 8 Jan 2020 21:05:21 +0100") Message-ID: <87imljsahu.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 12 Jan 2020 12:36:09 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , Geert Uytterhoeven , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , netdev@vger.kernel.org, Paul Mackerras , linux-arch@vger.kernel.org, Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , linux-sh@vger.kernel.org, Alexey Brodkin , Ben Skeggs , nouveau@lists.freedesktop.org, Dave Airlie , Matt Turner , linux-snps-arc@lists.infradead.org, Nick Kossifidis , Allen Hubbe , Arnd Bergmann , linux-alpha@vger.kernel.org, Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Richard Henderson , linux-parisc@vger.kernel.org, Vineet Gupta , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Jon Mason , linux-ntb@googlegroups.com, linux-media@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Krzysztof Kozlowski writes: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven > > --- > > Changes since v1: > 1. Add Geert's review. > --- > drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) No need to have "net: wireless: " in the title, this is enough. rtl818x: Constify ioreadX() iomem argument (as in generic implementation) I assume someone else will take this so here's my ack: Acked-by: Kalle Valo -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail25.static.mailgun.info (mail25.static.mailgun.info. [104.130.122.25]) by gmr-mx.google.com with UTF8SMTPS id d12si287383pjv.0.2020.01.10.05.32.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2020 05:32:32 -0800 (PST) Sender: kvalo=codeaurora.org@mg.codeaurora.org From: Kalle Valo Subject: Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation) References: <20200108200528.4614-1-krzk@kernel.org> <20200108200528.4614-3-krzk@kernel.org> Date: Fri, 10 Jan 2020 15:32:13 +0200 In-Reply-To: <20200108200528.4614-3-krzk@kernel.org> (Krzysztof Kozlowski's message of "Wed, 8 Jan 2020 21:05:21 +0100") Message-ID: <87imljsahu.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain To: Krzysztof Kozlowski Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Alexey Brodkin , Vineet Gupta , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Yoshinori Sato , Rich Felker , Dave Airlie , David Airlie , Daniel Vetter , Ben Skeggs , Mauro Carvalho Chehab , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , "David S. Miller" , Dave Jiang , Jon Mason , Allen Hubbe , "Michael S. Tsirkin" , Jason Wang , Arnd Bergmann , Geert Uytterhoeven , Thomas Gleixner , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-media@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-ntb@googlegroups.com, virtualization@lists.linux-foundation.org, linux-arch@vger.kernel.org List-ID: Krzysztof Kozlowski writes: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven > > --- > > Changes since v1: > 1. Add Geert's review. > --- > drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) No need to have "net: wireless: " in the title, this is enough. rtl818x: Constify ioreadX() iomem argument (as in generic implementation) I assume someone else will take this so here's my ack: Acked-by: Kalle Valo -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches