From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA6DCC43381 for ; Mon, 4 Mar 2019 17:37:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 838F72070B for ; Mon, 4 Mar 2019 17:37:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727367AbfCDRhF convert rfc822-to-8bit (ORCPT ); Mon, 4 Mar 2019 12:37:05 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:36110 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727268AbfCDRhF (ORCPT ); Mon, 4 Mar 2019 12:37:05 -0500 Received: by mail-ed1-f67.google.com with SMTP id g9so4930025eds.3 for ; Mon, 04 Mar 2019 09:37:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=3uAV2x7aN/aQ9owCroS8OSlmPR35JMsGPV1a7TGQ1Ek=; b=QxfMl0Vf1QXB7dX6SqRUltRPoro2XVQR5Q2k+D8u3eW5pbzk9iFXcUXFGGZGb70N5h DC/eL2kt7uXiiOVnXOqVd7Soz/5Y/LCRvHbwx1IvGZtX7ZolW8GFUV2fohsFqQqQwsev 1jusrcFZ67Qas5gGi6c+vs5auv3QUyZkD1Eovvd+zX8hqRCKI1/xKbXh8wXWvyMKVrFQ xeotka4GtDnmTYRRgMPHtDfnQ0iCX7qwY4EvunlwDCo99ju5F4NZ9Oce6qC1eKgYSorz 5VZqg27Lqgza4HOcxlfWGBh3koBm6XQDqs5tqMvG3VRJs6dJW2ihxl6IX0CoGauKcIm1 bGZg== X-Gm-Message-State: APjAAAXHMvakcEYA4Pxo8+2t+76iTS73pgo/QpFT4F8vxmvO32ur3IJ+ FRy4Wt4T7W2l/2PdRlmBqqRfrQ== X-Google-Smtp-Source: APXvYqx1hcmINXUhLlJ8CXGqv26Rcu61aZ6976LGmcUGuQcD3DvDRMIv/cnsJjcpxW0gIhFThNUeUA== X-Received: by 2002:a17:906:2989:: with SMTP id x9mr13520186eje.218.1551721023560; Mon, 04 Mar 2019 09:37:03 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id a52sm2232891edc.74.2019.03.04.09.37.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Mar 2019 09:37:03 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id AF4A9182E8E; Mon, 4 Mar 2019 18:37:02 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jakub Kicinski Cc: David Miller , netdev@vger.kernel.org, Jesper Dangaard Brouer , Daniel Borkmann , Alexei Starovoitov Subject: Re: [PATCH net-next v3 1/3] xdp: Refactor devmap code in preparation for subsequent additions In-Reply-To: <20190304090839.09a72330@cakuba.netronome.com> References: <155144955030.28287.14029975169967438162.stgit@alrua-x1> <155144955040.28287.1075106871059918653.stgit@alrua-x1> <20190301170831.6ae29baa@cakuba.netronome.com> <87zhqakdqk.fsf@toke.dk> <20190304090839.09a72330@cakuba.netronome.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 04 Mar 2019 18:37:02 +0100 Message-ID: <87imwy35j5.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jakub Kicinski writes: > On Mon, 04 Mar 2019 13:47:47 +0100, Toke Høiland-Jørgensen wrote: >> In an earlier version I had a namespace enter/exit notifier in devmap.c >> as well, to react to new namespaces. And that notifier has a comment >> about avoiding calls to synchronize_rcu(). But since this version >> doesn't actually need that, maybe I can just keep using direct calls and >> synchronize_rcu() and avoid the callback? I'm a bit worried about adding >> both synchronize_rcu() and cond_resched() as a possible side effect of >> every call to bpf_prog_put(), though; so maybe it's better to move the >> cleanup somewhere it's actually safe to call cond_resched(); what would >> that be, a workqueue? > > Workqueue would be my go to. Gotcha! Thanks :) -Toke