From: Vagrant Cascadian <vagrant@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] Changed syntax for dumpimage, failing tests
Date: Wed, 13 Feb 2019 16:16:34 -0800 [thread overview]
Message-ID: <87imxn5in1.fsf@ponder> (raw)
The syntax for dumpimage was changed since v2019.01, but
test/image/test-imagetools.sh wasn't updated with the new syntax.
While the change may make sense, it breaks existing behavior, and that
has it's drawbacks...
In any case, the tests shouldn't fail.
I believe this is the commit that changed it:
commit 12b831879a765722c1a94ca75c6adb6f80759cd9
Author: Martyn Welch <martyn.welch@collabora.com>
Date: Sat Jan 26 02:31:51 2019 +0000
tools: dumpimage: Simplify arguments
The dump image utility has very confusing syntax. If called to list
image contents ("-l") it takes the image name as a positional
argument. If the utility is called to extract something from the
image, the image must be provided via the optional argument "-i" as
well as the positional argument but the value passed in the
positional argument will be completely ignored.
Simplify dumpimage by always providing the image as the first
positional argument. Assume we want to dump something from the image
if we do not provide the "-l" option for now.
live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190213/877695f0/attachment.sig>
next reply other threads:[~2019-02-14 0:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 0:16 Vagrant Cascadian [this message]
2019-02-14 13:11 ` [U-Boot] [PATCH] test: Update test-imagetools.sh to match new syntax Martyn Welch
2019-02-20 1:09 ` Vagrant Cascadian
2019-02-20 10:51 ` Martyn Welch
2019-03-09 3:53 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imxn5in1.fsf@ponder \
--to=vagrant@debian.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.