All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [WIP] support/testing: add xserver + Mesa OpenGL (GLX) + glxinfo
Date: Tue, 05 Feb 2019 10:58:57 +0100	[thread overview]
Message-ID: <87imxypndq.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190107235024.6819-1-romain.naour@gmail.com> (Romain Naour's message of "Tue, 8 Jan 2019 00:50:24 +0100")

>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > This test allow to check if the xserver with GLX is working properly.
 > This is a basic test but it allow to trigger the current bug reported
 > by [1].

 > [1] https://bugs.buildroot.org/show_bug.cgi?id=11591

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > ---
 >  support/testing/tests/package/test_glxinfo.py | 57 +++++++++++++++++++++++++++
 >  1 file changed, 57 insertions(+)
 >  create mode 100644 support/testing/tests/package/test_glxinfo.py

..

 > +    def test_run(self):
 > +        self.login()
 > +

Dont we need to wait for the xserver to start?

 > +        # The test case verifies that the xserver with GLX is working
 > +        cmd = "glxinfo -display :0 2>&1 >/dev/null | grep Error"
 > +        # Error case: "Error: couldn't find RGB GLX visual or fbconfig"

Why the redirect / grep when you ignore the output in emulator.run()?

> +        _, exit_code = self.emulator.run(cmd, GLXINFO_TIMEOUT)
 > +        self.assertEqual(exit_code, 1)

So your expect glxinfo to fail?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2019-02-05  9:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 23:50 [Buildroot] [WIP] support/testing: add xserver + Mesa OpenGL (GLX) + glxinfo Romain Naour
2019-02-05  9:58 ` Peter Korsgaard [this message]
2019-03-20 11:51   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imxypndq.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.