From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v5 01/30] regset: Add support for dynamically sized regsets Date: Wed, 08 Nov 2017 11:50:00 +0000 Message-ID: <87inelq9av.fsf@linaro.org> References: <1509465082-30427-1-git-send-email-Dave.Martin@arm.com> <1509465082-30427-2-git-send-email-Dave.Martin@arm.com> <20171101114228.jm53aj7jx6j4mxhn@armageddon.cambridge.arm.com> <20171101131644.GL19485@e103592.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:47544 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbdKHLuD (ORCPT ); Wed, 8 Nov 2017 06:50:03 -0500 Received: by mail-wr0-f196.google.com with SMTP id k61so2158667wrc.4 for ; Wed, 08 Nov 2017 03:50:02 -0800 (PST) In-reply-to: <20171101131644.GL19485@e103592.cambridge.arm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Martin Cc: Catalin Marinas , linux-arch@vger.kernel.org, "H. J. Lu" , Okamoto Takayuki , libc-alpha@sourceware.org, Ard Biesheuvel , Szabolcs Nagy , Dmitry Safonov , Will Deacon , Oleg Nesterov , Ingo Molnar , Alexander Viro , "H. Peter Anvin" , Thomas Gleixner , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Dave Martin writes: > On Wed, Nov 01, 2017 at 11:42:29AM +0000, Catalin Marinas wrote: >> On Tue, Oct 31, 2017 at 03:50:53PM +0000, Dave P Martin wrote: >> > Currently the regset API doesn't allow for the possibility that >> > regsets (or at least, the amount of meaningful data in a regset) >> > may change in size. >> > >> > In particular, this results in useless padding being added to >> > coredumps if a regset's current size is smaller than its >> > theoretical maximum size. >> > >> > This patch adds a get_size() function to struct user_regset. >> > Individual regset implementations can implement this function to >> > return the current size of the regset data. A regset_size() >> > function is added to provide callers with an abstract interface for >> > determining the size of a regset without needing to know whether >> > the regset is dynamically sized or not. >> > >> > The only affected user of this interface is the ELF coredump code: >> > This patch ports ELF coredump to dump regsets with their actual >> > size in the coredump. This has no effect except for new regsets >> > that are dynamically sized and provide a get_size() implementation. >> > >> > Signed-off-by: Dave Martin >> > Reviewed-by: Alex Benn=C3=A9e >> > Reviewed-by: Catalin Marinas >> > Cc: Oleg Nesterov >> > Cc: Alexander Viro >> > Cc: Thomas Gleixner >> > Cc: Ingo Molnar >> > Cc: "H. Peter Anvin" >> > Cc: Dmitry Safonov >> > Cc: H. J. Lu >> > >> > --- >> > >> > **Dropped** Reviewed-by: Alex Benn=C3=A9e >> > **Dropped** Reviewed-by: Catalin Marinas >> > (due to bug fix applied against v4 of this patch.) >> >> It seems that the Reviewed-by tags are still there ;). Anyway, on the > > Oops, looks like that only happened on this patch. I've removed > Alex's R-b from my own version in case of repost -- can you also > do the same? > >> new patch: >> >> Reviewed-by: Catalin Marinas You can have my: Reviewed-by: Alex Benn=C3=A9e > > Cheers > ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:47544 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751826AbdKHLuD (ORCPT ); Wed, 8 Nov 2017 06:50:03 -0500 Received: by mail-wr0-f196.google.com with SMTP id k61so2158667wrc.4 for ; Wed, 08 Nov 2017 03:50:02 -0800 (PST) References: <1509465082-30427-1-git-send-email-Dave.Martin@arm.com> <1509465082-30427-2-git-send-email-Dave.Martin@arm.com> <20171101114228.jm53aj7jx6j4mxhn@armageddon.cambridge.arm.com> <20171101131644.GL19485@e103592.cambridge.arm.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v5 01/30] regset: Add support for dynamically sized regsets In-reply-to: <20171101131644.GL19485@e103592.cambridge.arm.com> Date: Wed, 08 Nov 2017 11:50:00 +0000 Message-ID: <87inelq9av.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Martin Cc: Catalin Marinas , linux-arch@vger.kernel.org, "H. J. Lu" , Okamoto Takayuki , libc-alpha@sourceware.org, Ard Biesheuvel , Szabolcs Nagy , Dmitry Safonov , Will Deacon , Oleg Nesterov , Ingo Molnar , Alexander Viro , "H. Peter Anvin" , Thomas Gleixner , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Message-ID: <20171108115000.n5ouS8AE7Omt0czjPvFjxTRMDpOSDijtdlqZ-IMqDwI@z> Dave Martin writes: > On Wed, Nov 01, 2017 at 11:42:29AM +0000, Catalin Marinas wrote: >> On Tue, Oct 31, 2017 at 03:50:53PM +0000, Dave P Martin wrote: >> > Currently the regset API doesn't allow for the possibility that >> > regsets (or at least, the amount of meaningful data in a regset) >> > may change in size. >> > >> > In particular, this results in useless padding being added to >> > coredumps if a regset's current size is smaller than its >> > theoretical maximum size. >> > >> > This patch adds a get_size() function to struct user_regset. >> > Individual regset implementations can implement this function to >> > return the current size of the regset data. A regset_size() >> > function is added to provide callers with an abstract interface for >> > determining the size of a regset without needing to know whether >> > the regset is dynamically sized or not. >> > >> > The only affected user of this interface is the ELF coredump code: >> > This patch ports ELF coredump to dump regsets with their actual >> > size in the coredump. This has no effect except for new regsets >> > that are dynamically sized and provide a get_size() implementation. >> > >> > Signed-off-by: Dave Martin >> > Reviewed-by: Alex Benn=C3=A9e >> > Reviewed-by: Catalin Marinas >> > Cc: Oleg Nesterov >> > Cc: Alexander Viro >> > Cc: Thomas Gleixner >> > Cc: Ingo Molnar >> > Cc: "H. Peter Anvin" >> > Cc: Dmitry Safonov >> > Cc: H. J. Lu >> > >> > --- >> > >> > **Dropped** Reviewed-by: Alex Benn=C3=A9e >> > **Dropped** Reviewed-by: Catalin Marinas >> > (due to bug fix applied against v4 of this patch.) >> >> It seems that the Reviewed-by tags are still there ;). Anyway, on the > > Oops, looks like that only happened on this patch. I've removed > Alex's R-b from my own version in case of repost -- can you also > do the same? > >> new patch: >> >> Reviewed-by: Catalin Marinas You can have my: Reviewed-by: Alex Benn=C3=A9e > > Cheers > ---Dave -- Alex Benn=C3=A9e From mboxrd@z Thu Jan 1 00:00:00 1970 From: alex.bennee@linaro.org (Alex =?utf-8?Q?Benn=C3=A9e?=) Date: Wed, 08 Nov 2017 11:50:00 +0000 Subject: [PATCH v5 01/30] regset: Add support for dynamically sized regsets In-Reply-To: <20171101131644.GL19485@e103592.cambridge.arm.com> References: <1509465082-30427-1-git-send-email-Dave.Martin@arm.com> <1509465082-30427-2-git-send-email-Dave.Martin@arm.com> <20171101114228.jm53aj7jx6j4mxhn@armageddon.cambridge.arm.com> <20171101131644.GL19485@e103592.cambridge.arm.com> Message-ID: <87inelq9av.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dave Martin writes: > On Wed, Nov 01, 2017 at 11:42:29AM +0000, Catalin Marinas wrote: >> On Tue, Oct 31, 2017 at 03:50:53PM +0000, Dave P Martin wrote: >> > Currently the regset API doesn't allow for the possibility that >> > regsets (or at least, the amount of meaningful data in a regset) >> > may change in size. >> > >> > In particular, this results in useless padding being added to >> > coredumps if a regset's current size is smaller than its >> > theoretical maximum size. >> > >> > This patch adds a get_size() function to struct user_regset. >> > Individual regset implementations can implement this function to >> > return the current size of the regset data. A regset_size() >> > function is added to provide callers with an abstract interface for >> > determining the size of a regset without needing to know whether >> > the regset is dynamically sized or not. >> > >> > The only affected user of this interface is the ELF coredump code: >> > This patch ports ELF coredump to dump regsets with their actual >> > size in the coredump. This has no effect except for new regsets >> > that are dynamically sized and provide a get_size() implementation. >> > >> > Signed-off-by: Dave Martin >> > Reviewed-by: Alex Benn?e >> > Reviewed-by: Catalin Marinas >> > Cc: Oleg Nesterov >> > Cc: Alexander Viro >> > Cc: Thomas Gleixner >> > Cc: Ingo Molnar >> > Cc: "H. Peter Anvin" >> > Cc: Dmitry Safonov >> > Cc: H. J. Lu >> > >> > --- >> > >> > **Dropped** Reviewed-by: Alex Benn?e >> > **Dropped** Reviewed-by: Catalin Marinas >> > (due to bug fix applied against v4 of this patch.) >> >> It seems that the Reviewed-by tags are still there ;). Anyway, on the > > Oops, looks like that only happened on this patch. I've removed > Alex's R-b from my own version in case of repost -- can you also > do the same? > >> new patch: >> >> Reviewed-by: Catalin Marinas You can have my: Reviewed-by: Alex Benn?e > > Cheers > ---Dave -- Alex Benn?e