Re: [Qemu-devel] qemu-2.9 crashes in tcg_handle_interrupt() during winx64 boot

From: "Alex Bennée" <alex.bennee@linaro.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
	KONRAD Frederic <fred.konrad@greensocs.com>,
	"Emilio G. Cota" <cota@braap.org>,
	Richard Henderson <rth@twiddle.net>,
	Pranith Kumar <bobby.prani@gmail.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] qemu-2.9 crashes in tcg_handle_interrupt() during winx64 boot
Date: Thu, 30 Mar 2017 17:14:47 +0100	[thread overview]
Message-ID: <87inmq4u88.fsf@linaro.org> (raw)
In-Reply-To: <87k2764xex.fsf@linaro.org>

Alex Bennée <alex.bennee@linaro.org> writes:

> Igor Mammedov <imammedo@redhat.com> writes:
>
>> (PS: resend due to wrong qemu-devel mail list address in original
>> email)
>
> Le *sigh* another way of x86 generating IRQs ;-)
>
> Could you test this please?

Sorry I missed you'll also need a:

#include "qemu/main-loop.h"

At the top of misc_helper.c

>
> target/i386/misc_helper: wrap BQL around another IRQ generator
>
> Anything that calls into HW emulation must be protected by the BQL.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> 1 file changed, 2 insertions(+)
> target/i386/misc_helper.c | 2 ++
>
> modified   target/i386/misc_helper.c
> @@ -156,7 +156,9 @@ void helper_write_crN(CPUX86State *env, int reg, target_ulong t0)
>          break;
>      case 8:
>          if (!(env->hflags2 & HF2_VINTR_MASK)) {
> +            qemu_mutex_lock_iothread();
>              cpu_set_apic_tpr(x86_env_get_cpu(env)->apic_state, t0);
> +            qemu_mutex_unlock_iothread();
>          }
>          env->v_tpr = t0 & 0x0f;
>          break;

--
Alex Bennée