All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/aespipe: fix host compile
Date: Sat, 17 Dec 2016 17:55:02 +0100	[thread overview]
Message-ID: <87inqia42h.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20161217155904.4d5b4511@free-electrons.com> (Thomas Petazzoni's message of "Sat, 17 Dec 2016 15:59:04 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Sat, 17 Dec 2016 08:16:59 +0100, Bernd Kuhls wrote:

 >> +HOST_AESPIPE_CONF_ENV = \
 >> +	CFLAGS="$(HOST_CFLAGS) -no-pie" \
 >> +	LDFLAGS="$(HOST_LDFLAGS) -no-pie"

 > I reverted this patch as it breaks the build on systems where gcc does
 > not understand -no-pie:

 >   http://autobuild.buildroot.net/?reason=host-aespipe-2.4d

Crap, so the option is also a Debian specific change? :/

 > A better solution is needed for this problem.

We could do something like the kernel's cc-option to see if HOSTCC
accepts -no-pie - And if so, unconditionally add it to HOST_CFLAGS /
HOST_LDFLAGS.

cc-option is defined in scripts/Kbuild.include:

# cc-option
# Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586)

cc-option = $(call try-run,\
        $(CC) $(KBUILD_CPPFLAGS) $(CC_OPTION_CFLAGS) $(1) -c -x c /dev/null -o "$$TMP",$(1),$(2))

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2016-12-17 16:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-17  7:16 [Buildroot] [PATCH 1/2] package/aespipe: bump version to 2.4d Bernd Kuhls
2016-12-17  7:16 ` [Buildroot] [PATCH 2/2] package/aespipe: fix host compile Bernd Kuhls
2016-12-17  7:56   ` Peter Korsgaard
2016-12-17 14:59   ` Thomas Petazzoni
2016-12-17 16:55     ` Peter Korsgaard [this message]
2017-05-28 15:32       ` Bernd Kuhls
2016-12-17  7:42 ` [Buildroot] [PATCH 1/2] package/aespipe: bump version to 2.4d Peter Korsgaard
2017-07-03  8:41 [Buildroot] [PATCH 1/2] package/Makefile.in: add host-cc-option macro Arnout Vandecappelle
2017-07-03  8:41 ` [Buildroot] [PATCH 2/2] package/aespipe: fix host compile Arnout Vandecappelle
2017-07-25 22:14   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inqia42h.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.