From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933140AbcKVOAX (ORCPT ); Tue, 22 Nov 2016 09:00:23 -0500 Received: from mga11.intel.com ([192.55.52.93]:21436 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933143AbcKVOAT (ORCPT ); Tue, 22 Nov 2016 09:00:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,533,1473145200"; d="asc'?scan'208";a="1062789900" From: Felipe Balbi To: Stefan Wahren , John Youn , Vardan Mikayelyan , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param In-Reply-To: References: <1479677166-13114-1-git-send-email-stefan.wahren@i2se.com> <1479677166-13114-6-git-send-email-stefan.wahren@i2se.com> <87lgwbr9ef.fsf@linux.intel.com> Date: Tue, 22 Nov 2016 15:59:23 +0200 Message-ID: <87inrfr4xw.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Stefan Wahren writes: > Hi Felipe, > > Am 22.11.2016 um 13:23 schrieb Felipe Balbi: >> Hi, >> >> Stefan Wahren writes: >>> Since there is no parameter @value replace it with @legacy. >>> >>> Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params") >>> Signed-off-by: Stefan Wahren >>> --- >>> drivers/usb/dwc2/params.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c >>> index 11fe68a..10407cb 100644 >>> --- a/drivers/usb/dwc2/params.c >>> +++ b/drivers/usb/dwc2/params.c >>> @@ -320,7 +320,7 @@ static void dwc2_set_core_param(void *param, u8 siz= e, u64 value) >>> * @size: The size of the core parameter in bytes, or 0 for bool. >>> * >>> * This function looks up @property and sets the @param to that value. >>> - * If the property doesn't exist it uses the passed-in @value. It will >>> + * If the property doesn't exist it uses the passed-in @legacy value. = It will >> This doesn't fix any bugs.=20 > > you are right. I found this documentation bug while fixing the issues > before. > > Since this is the last patch of the series, you could ignore it. And i > resend it without fixes tag after the merge window. fine by me :-) >> Also, is @legacy a parameter? >> > > |/** * dwc2_set_param() - Set a core parameter * * @hsotg: Programming > view of the DWC_otg controller * @param: Pointer to the parameter to set > * @lookup: True if the property should be looked up * @property: The > device property to read * @legacy: The param value to set if @property > is not available. This * will typically be the legacy value set in the > static * params structure. * @def: The default value * @min: The minimum > value * @max: The maximum value * @size: The size of the core parameter > in bytes, or 0 for bool. * * This function looks up @property and sets > the @param to that value. * If the property doesn't exist it uses the > passed-in @value. It will * verify that the value falls between @min and > @max. If it doesn't, * it will output an error and set the parameter to > either @def or, * failing that, to @min. * * The @size is used to write > to @param and to query the device * properties so that this same > function can be used with different * types of parameters. */ static > void dwc2_set_param(struct dwc2_hsotg *hsotg, void *param, bool lookup, > char *property, u64 legacy, u64 def, u64 min, u64 max, u8 size)| heh, a little difficult to read, but got your point ;-) thanks =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlg0TzsACgkQzL64meEa mQb5Aw/8DHY7TMLvs4RdTLe+NtBpGe0XAPaqBd3JjRxfPZbX8NTQh30cS40ODEJ6 PQJzybuFSy1GkpS9ZFhrGko0HFnqRYUiZxa4Nuzb7iuDy/nAgIYr0dBvZfN+GKvw 0uw66BFg5rewUc1ZAwIr2kHKl9EhH1GjbixQP5LESfvM38O2S5moIQepr7QPW+KD hbKf/NKOboB7DQGFWJ9PhDl1S3LmnN2Lv1i0itZ9xSvybgIw096NgZibTdEtCJJ8 HUstOvgLKE9xEq4mUJjhhEogVSowGG1hP2OeHQV9y+Zf6aR23N421SyBOlL+A6pO abQgF9L9WN3RHgwsO2f6bvpFncDeYlCLb3g62iDiiVIUsSuM6AtuiNCDlQpdtsZm lmvSpAZyVm/tCdB3oSQSwe5kvxJZV8cmND7iBHXtgBFVk9R1ixyzLoisk2peeuKs 49qK5y0NQexllTH+JQtaesHD71/ggwqiaJ2a5hzGXonA8gESo0XQ/S3Vsqa4LcGm iQ7NByUSpHz/ul/nI5OIgBFaCzsa39XPw8vNUomN5o0vuzijrYYlHcEn+ydcMVN2 oJFvS8rqHYLBUHBlBSRNR+/9fviqbh0E1LLyvblXk6O/GhPVsgkAs3xwZVvG0ic3 XQZyviak6Oo45PRBOfF6x+Amv4bO7lX7nx065uAtam+ca0v2NDw= =qT4m -----END PGP SIGNATURE----- --=-=-=--