* [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c
@ 2016-09-09 21:13 Ashijeet Acharya
2016-09-13 8:41 ` Amit Shah
2016-10-05 9:36 ` Juan Quintela
0 siblings, 2 replies; 3+ messages in thread
From: Ashijeet Acharya @ 2016-09-09 21:13 UTC (permalink / raw)
To: quintela; +Cc: amit.shah, dgilbert, eblake, qemu-devel, Ashijeet Acharya
This patch fixes the out-of-bounds check of migration parameters in
qmp_migrate_set_parameters() for cpu-throttle-initial and
cpu-throttle-increment by adding a return statement for both as they
were broken since their introduction in 2.5 via commit 1626fee.
Due to the missing return statements, parameters were getting set to
out-of-bounds values despite the error.
Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
Changes in v4:
-Fix the typo in commit message
-Include the commit id which caused the regression
---
migration/migration.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 9b4aa55..cd8334c 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -805,6 +805,7 @@ void qmp_migrate_set_parameters(MigrationParameters *params, Error **errp)
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
"cpu_throttle_initial",
"an integer in the range of 1 to 99");
+ return;
}
if (params->has_cpu_throttle_increment &&
(params->cpu_throttle_increment < 1 ||
@@ -812,6 +813,7 @@ void qmp_migrate_set_parameters(MigrationParameters *params, Error **errp)
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
"cpu_throttle_increment",
"an integer in the range of 1 to 99");
+ return;
}
if (params->has_max_bandwidth &&
(params->max_bandwidth < 0 || params->max_bandwidth > SIZE_MAX)) {
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c
2016-09-09 21:13 [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c Ashijeet Acharya
@ 2016-09-13 8:41 ` Amit Shah
2016-10-05 9:36 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Amit Shah @ 2016-09-13 8:41 UTC (permalink / raw)
To: Ashijeet Acharya; +Cc: quintela, dgilbert, eblake, qemu-devel
On (Sat) 10 Sep 2016 [02:43:17], Ashijeet Acharya wrote:
> This patch fixes the out-of-bounds check of migration parameters in
> qmp_migrate_set_parameters() for cpu-throttle-initial and
> cpu-throttle-increment by adding a return statement for both as they
> were broken since their introduction in 2.5 via commit 1626fee.
> Due to the missing return statements, parameters were getting set to
> out-of-bounds values despite the error.
>
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> Changes in v4:
> -Fix the typo in commit message
> -Include the commit id which caused the regression
OK - I acked v1, but this is a better commit message.
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c
2016-09-09 21:13 [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c Ashijeet Acharya
2016-09-13 8:41 ` Amit Shah
@ 2016-10-05 9:36 ` Juan Quintela
1 sibling, 0 replies; 3+ messages in thread
From: Juan Quintela @ 2016-10-05 9:36 UTC (permalink / raw)
To: Ashijeet Acharya; +Cc: amit.shah, dgilbert, eblake, qemu-devel
Ashijeet Acharya <ashijeetacharya@gmail.com> wrote:
> This patch fixes the out-of-bounds check of migration parameters in
> qmp_migrate_set_parameters() for cpu-throttle-initial and
> cpu-throttle-increment by adding a return statement for both as they
> were broken since their introduction in 2.5 via commit 1626fee.
> Due to the missing return statements, parameters were getting set to
> out-of-bounds values despite the error.
>
> Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> Changes in v4:
> -Fix the typo in commit message
> -Include the commit id which caused the regression
Reviewed-by: Juan Quintela <quintela@redhat.com>
applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-05 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-09 21:13 [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c Ashijeet Acharya
2016-09-13 8:41 ` Amit Shah
2016-10-05 9:36 ` Juan Quintela
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.